| Message ID | 20200225020937.25028-14-kuhn.chenqun@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | redundant code: Fix warnings reported by Clang static code analyzer | expand |
On 2/25/20 3:09 AM, kuhn.chenqun@huawei.com wrote: > From: Chen Qun <kuhn.chenqun@huawei.com> > > Clang static code analyzer show warning: > monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read > set = true; > ^ ~~~~ > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com> > --- > monitor/hmp-cmds.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index 53bc3f76c4..84f94647cd 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -2864,7 +2864,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict) > > if (group->has_set_eth_dst) { > if (!set) { > - set = true; > monitor_printf(mon, " set"); > } > monitor_printf(mon, " dst %s", group->set_eth_dst); > Can you move the 'set' declaration to the for() statement and also remove the last "set = false;"?
>-----Original Message----- >From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com] >Sent: Tuesday, February 25, 2020 5:45 PM >To: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; qemu- >devel@nongnu.org; qemu-trivial@nongnu.org >Cc: peter.maydell@linaro.org; Zhanghailiang ><zhang.zhanghailiang@huawei.com>; Dr. David Alan Gilbert ><dgilbert@redhat.com> >Subject: Re: [PATCH 13/13] monitor/hmp-cmds: Remove redundant >statement in hmp_rocker_of_dpa_groups() > >On 2/25/20 3:09 AM, kuhn.chenqun@huawei.com wrote: >> From: Chen Qun <kuhn.chenqun@huawei.com> >> >> Clang static code analyzer show warning: >> monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read >> set = true; >> ^ ~~~~ >> >> Reported-by: Euler Robot <euler.robot@huawei.com> >> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> >> --- >> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com> >> --- >> monitor/hmp-cmds.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index >> 53bc3f76c4..84f94647cd 100644 >> --- a/monitor/hmp-cmds.c >> +++ b/monitor/hmp-cmds.c >> @@ -2864,7 +2864,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, >> const QDict *qdict) >> >> if (group->has_set_eth_dst) { >> if (!set) { >> - set = true; >> monitor_printf(mon, " set"); >> } >> monitor_printf(mon, " dst %s", group->set_eth_dst); >> > >Can you move the 'set' declaration to the for() statement and also remove the >last "set = false;"? Yes, you are right! It will be better! I will modify it later in V2. Thanks.
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 53bc3f76c4..84f94647cd 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -2864,7 +2864,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict *qdict) if (group->has_set_eth_dst) { if (!set) { - set = true; monitor_printf(mon, " set"); } monitor_printf(mon, " dst %s", group->set_eth_dst);