| Message ID | 20200206150626.708649-3-gch981213@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | spi: add driver for ar934x spi controller | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Thu, 6 Feb 2020 23:06:26 +0800, Chuanhong Guo wrote: > Add binding documentation for SPI controller in Qualcomm Atheros > AR934x/QCA95xx SoCs. > > Signed-off-by: Chuanhong Guo <gch981213@gmail.com> > --- > Changes since v1: none > .../bindings/spi/qca,ar934x-spi.yaml | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/qca,ar934x-spi.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node Error: Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dts:20.28-29 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dt.yaml' failed make[1]: *** [Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dt.yaml] Error 1 Makefile:1263: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1234394 Please check and re-submit.
On Fri, Feb 7, 2020 at 4:55 AM Rob Herring <robh@kernel.org> wrote: > > On Thu, 6 Feb 2020 23:06:26 +0800, Chuanhong Guo wrote: > > Add binding documentation for SPI controller in Qualcomm Atheros > > AR934x/QCA95xx SoCs. > > > > Signed-off-by: Chuanhong Guo <gch981213@gmail.com> > > --- > > Changes since v1: none > > .../bindings/spi/qca,ar934x-spi.yaml | 40 +++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/spi/qca,ar934x-spi.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node > Error: Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dts:20.28-29 syntax error > FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dt.yaml' failed > make[1]: *** [Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dt.yaml] Error 1 > Makefile:1263: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1234394 > Please check and re-submit. It's caused by "clocks = <&pll ATH79_CLK_AHB>" where ATH79_CLK_AHB isn't defined without a include of dt-bindings/clock/ath79-clk.h I'll replace this with a bogus "clocks = <&spi_clock>" instead in v3. Regards, Chuanhong Guo
On 2/6/20 9:55 PM, Chuanhong Guo wrote: > On Fri, Feb 7, 2020 at 4:55 AM Rob Herring <robh@kernel.org> wrote: >> >> On Thu, 6 Feb 2020 23:06:26 +0800, Chuanhong Guo wrote: >>> Add binding documentation for SPI controller in Qualcomm Atheros >>> AR934x/QCA95xx SoCs. >>> >>> Signed-off-by: Chuanhong Guo <gch981213@gmail.com> >>> --- >>> Changes since v1: none >>> .../bindings/spi/qca,ar934x-spi.yaml | 40 +++++++++++++++++++ >>> 1 file changed, 40 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/spi/qca,ar934x-spi.yaml >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node >> Error: Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dts:20.28-29 syntax error >> FATAL ERROR: Unable to parse input tree >> scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dt.yaml' failed >> make[1]: *** [Documentation/devicetree/bindings/spi/qca,ar934x-spi.example.dt.yaml] Error 1 >> Makefile:1263: recipe for target 'dt_binding_check' failed >> make: *** [dt_binding_check] Error 2 >> >> See https://patchwork.ozlabs.org/patch/1234394 >> Please check and re-submit. > > It's caused by "clocks = <&pll ATH79_CLK_AHB>" where ATH79_CLK_AHB > isn't defined without a include of dt-bindings/clock/ath79-clk.h > I'll replace this with a bogus "clocks = <&spi_clock>" instead in v3. You can include ath79-clk.h in your example, see for instance Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
On Sat, Feb 8, 2020 at 7:54 AM Florian Fainelli <f.fainelli@gmail.com> wrote: > On 2/6/20 9:55 PM, Chuanhong Guo wrote: > > It's caused by "clocks = <&pll ATH79_CLK_AHB>" where ATH79_CLK_AHB > > isn't defined without a include of dt-bindings/clock/ath79-clk.h > > I'll replace this with a bogus "clocks = <&spi_clock>" instead in v3. > > You can include ath79-clk.h in your example, see for instance > Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml Oh. But I've already sent v3 out yesterday :( I think this is just cosmetic changes and doesn't make much difference so I'd like to keep v3 as-is now and if there are other comments for me to send a v4 I'll change this one as well. Regards, Chuanhong Guo
diff --git a/Documentation/devicetree/bindings/spi/qca,ar934x-spi.yaml b/Documentation/devicetree/bindings/spi/qca,ar934x-spi.yaml new file mode 100644 index 000000000000..8f0c520a571c --- /dev/null +++ b/Documentation/devicetree/bindings/spi/qca,ar934x-spi.yaml @@ -0,0 +1,40 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/qca,ar934x-spi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Atheros AR934x/QCA95xx SoC SPI controller + +maintainers: + - Chuanhong Guo <gch981213@gmail.com> + +allOf: + - $ref: spi-controller.yaml# + +properties: + compatible: + const: qca,ar934x-spi + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - '#address-cells' + - '#size-cells' + +examples: + - | + spi: spi@1f000000 { + compatible = "qca,ar934x-spi"; + reg = <0x1f000000 0x1c>; + clocks = <&pll ATH79_CLK_AHB>; + #address-cells = <1>; + #size-cells = <0>; + };
Add binding documentation for SPI controller in Qualcomm Atheros AR934x/QCA95xx SoCs. Signed-off-by: Chuanhong Guo <gch981213@gmail.com> --- Changes since v1: none .../bindings/spi/qca,ar934x-spi.yaml | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/qca,ar934x-spi.yaml