Message ID | 20200128.172544.1405211638887784147.davem@davemloft.net |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | [GIT] Networking | expand |
On Tue, Jan 28, 2020 at 8:26 AM David Miller <davem@davemloft.net> wrote: > > 1) Add WireGuard W00t! Linus
On Tue, Jan 28, 2020 at 8:26 AM David Miller <davem@davemloft.net> wrote: > > 12) Add initial support for MPTCP protocol, from Christoph Paasch, > Matthieu Baerts, Florian Westphal, Peter Krystad, and many > others. Hmm. This adds a MPTCP_HMAC_TEST config variable, and while it is "default n" (which is redundant - 'n' is the default anyway), it should likely instead be "depends on MPTCP". Because right now, if you say no to MPTCP, it will _still_ ask you about MPTCP_HMAC_TEST, which makes no sense. Even if you were to say 'y', there won't be any tests done since MPTCP isn't built at all. Linus
On Wed, 29 Jan 2020, Linus Torvalds wrote: > On Tue, Jan 28, 2020 at 8:26 AM David Miller <davem@davemloft.net> wrote: >> >> 12) Add initial support for MPTCP protocol, from Christoph Paasch, >> Matthieu Baerts, Florian Westphal, Peter Krystad, and many >> others. > > Hmm. This adds a MPTCP_HMAC_TEST config variable, and while it is > "default n" (which is redundant - 'n' is the default anyway), it > should likely instead be "depends on MPTCP". > > Because right now, if you say no to MPTCP, it will _still_ ask you > about MPTCP_HMAC_TEST, which makes no sense. Even if you were to say > 'y', there won't be any tests done since MPTCP isn't built at all. > Thanks for noting this. A fix is on the way: https://patchwork.ozlabs.org/patch/1231045/ -- Mat Martineau Intel