| Message ID | 20190412092923.24919-5-vigneshr@ti.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | MTD: Add Initial Hyperbus support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On 04/12/2019 12:29 PM, Vignesh Raghavendra wrote: > Add binding documentation for TI's HyperBus memory controller present on > AM654 SoC. > > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> > --- > .../devicetree/bindings/mtd/ti,am654-hbmc.txt | 31 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt > > diff --git a/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt b/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt > new file mode 100644 > index 000000000000..00888482df25 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt > @@ -0,0 +1,31 @@ [...] > +Optional properties: > +- mux-controls: phandle to the multiplexer that controls selection of > + HBMC vs OSPI. Mux state of 1 indicates HBMC is selected. I thought this is usually done with the help of drivers/pinctrl/.. > + > +Example: > + hbmc: hbmc@47034000 { > + compatible = "ti,am654-hbmc"; > + reg = <0x0 0x47034000 0x0 0x100>, > + <0x5 0x00000000 0x1 0x0000000>; > + power-domains = <&k3_pds 55>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x5 0x00000000 0x4000000>, /* CS0 - 64MB */ > + <0x1 0x5 0x04000000 0x4000000>; /* CS1 - 64MB > + > + /* Slave flash node */ > + flash@0{ Need space before {. > + compatible = "cypress,hyperflash"; > + reg = <0x0 0x4000000>; > + }; > + }; [...] MBR, Sergei
On 14/04/19 11:25 PM, Sergei Shtylyov wrote: > On 04/12/2019 12:29 PM, Vignesh Raghavendra wrote: > >> Add binding documentation for TI's HyperBus memory controller present on >> AM654 SoC. >> >> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> >> --- >> .../devicetree/bindings/mtd/ti,am654-hbmc.txt | 31 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 32 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt >> >> diff --git a/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt b/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt >> new file mode 100644 >> index 000000000000..00888482df25 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt >> @@ -0,0 +1,31 @@ > [...] >> +Optional properties: >> +- mux-controls: phandle to the multiplexer that controls selection of >> + HBMC vs OSPI. Mux state of 1 indicates HBMC is selected. > > I thought this is usually done with the help of drivers/pinctrl/.. > This mux is internal to SoC and not at SoC pad level. Based on this bit read/write requests at SoC interconnect is routed either to OSPI or HBMC, hence mmio-mux is a good fit OSPI and HBMC data pins are themselves at pad level which is handled by pinctrl-single node. >> + >> +Example: >> + hbmc: hbmc@47034000 { >> + compatible = "ti,am654-hbmc"; >> + reg = <0x0 0x47034000 0x0 0x100>, >> + <0x5 0x00000000 0x1 0x0000000>; >> + power-domains = <&k3_pds 55>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x0 0x5 0x00000000 0x4000000>, /* CS0 - 64MB */ >> + <0x1 0x5 0x04000000 0x4000000>; /* CS1 - 64MB >> + >> + /* Slave flash node */ >> + flash@0{ > > Need space before {. > Will fix. >> + compatible = "cypress,hyperflash"; >> + reg = <0x0 0x4000000>; >> + }; >> + }; > [...] > > MBR, Sergei >
diff --git a/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt b/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt new file mode 100644 index 000000000000..00888482df25 --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt @@ -0,0 +1,31 @@ +Bindings for HyperBus Memory Controller (HBMC) on TI's K3 family of SoCs + +Required properties: +- compatible : "ti,am654-hbmc" for AM654 SoC +- reg : Two entries: + First entry pointed to the register space of HBMC controller + Second entry pointing to the memory map region dedicated for + MMIO access to attached flash devices +- ranges : Address range allocated for each chipselect in the MMIO space + +Optional properties: +- mux-controls: phandle to the multiplexer that controls selection of + HBMC vs OSPI. Mux state of 1 indicates HBMC is selected. + +Example: + hbmc: hbmc@47034000 { + compatible = "ti,am654-hbmc"; + reg = <0x0 0x47034000 0x0 0x100>, + <0x5 0x00000000 0x1 0x0000000>; + power-domains = <&k3_pds 55>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x5 0x00000000 0x4000000>, /* CS0 - 64MB */ + <0x1 0x5 0x04000000 0x4000000>; /* CS1 - 64MB + + /* Slave flash node */ + flash@0{ + compatible = "cypress,hyperflash"; + reg = <0x0 0x4000000>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 7aa1b3454a89..07455035fca9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7249,6 +7249,7 @@ S: Supported F: drivers/mtd/hyperbus/ F: include/linux/mtd/hyperbus.h F: Documentation/devicetree/bindings/mtd/cypress,hyperbus.txt +F: Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt HYPERVISOR VIRTUAL CONSOLE DRIVER L: linuxppc-dev@lists.ozlabs.org
Add binding documentation for TI's HyperBus memory controller present on AM654 SoC. Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> --- .../devicetree/bindings/mtd/ti,am654-hbmc.txt | 31 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt