Message ID | 20190412130447.28304-1-nusiddiq@redhat.com |
---|---|
Headers | show |
Series | Address MTU issue for larger packets in OVN | expand |
Hi Greg, would you mind taking a look at the beginning of this series, to review the backport of the kernel changes that are now in net-next? Thanks, Ben. On Fri, Apr 12, 2019 at 06:34:47PM +0530, nusiddiq@redhat.com wrote: > From: Numan Siddique <nusiddiq@redhat.com> > > This series addresses the MTU issues for OVN reported > here [1]. > > This series has 6 patches > > Patch 1 adds a new OVS action - check_pkt_larger. It makes use > of the datapath action - 'check_pkt_len' which was added > recently to net-next [2]. > > Patch 2 is the datapath patch from [1] for the OVS in tree datapath > code. > > Patch 2 is submitted after patch 1 to avoid the compilation issues > since we are adding a new action attr - OVS_ACTION_ATTR_CHECK_PKT_LEN. > > Patch 3 to 6 are OVN patches. > > This patch series addressed most of the comments received for the RFC > series. > > Patch 1 still hasn't addressed the comment for the usage of > 'check_pkt_larger' action i.e check_pkt_larger(len)->REG_BIT. > > [1] - https://mail.openvswitch.org/pipermail/ovs-discuss/2018-July/047039.html > [2] - https://kernel.googlesource.com/pub/scm/linux/kernel/git/davem/net-next/+/4d5ec89fc8d14dcdab7214a0c13a1c7321dc6ea9 > > > v1 -> v2 > ------ > * Updated the commit message of patch 2 to include the net-next commit > id, author and date. > > No other changes. > > Numan Siddique (6): > Add a new OVS action check_pkt_larger > datapath: Add a new action check_pkt_len > ovn: Add a new OVN field icmp4.frag_mtu > ovn: Add a new OVN action 'icmp4_error' > ovn: Support OVS action 'check_pkt_larger' in OVN > ovn: Generate ICMPv4 packet in router pipeline for larger packets > > NEWS | 2 + > datapath/actions.c | 44 ++++ > datapath/flow_netlink.c | 171 +++++++++++++++ > .../linux/compat/include/linux/openvswitch.h | 39 ++++ > include/openvswitch/ofp-actions.h | 19 ++ > include/ovn/actions.h | 42 +++- > include/ovn/automake.mk | 3 +- > include/ovn/expr.h | 5 + > {ovn/lib => include/ovn}/logical-fields.h | 39 ++++ > lib/dpif-netdev.c | 1 + > lib/dpif.c | 1 + > lib/odp-execute.c | 72 +++++++ > lib/odp-util.c | 86 ++++++++ > lib/ofp-actions.c | 121 ++++++++++- > lib/ofp-parse.c | 10 + > lib/ovs-actions.xml | 31 +++ > ofproto/ofproto-dpif-ipfix.c | 1 + > ofproto/ofproto-dpif-sflow.c | 1 + > ofproto/ofproto-dpif-xlate.c | 131 ++++++++++++ > ofproto/ofproto-dpif.c | 43 ++++ > ofproto/ofproto-dpif.h | 5 +- > ovn/controller/lflow.c | 1 + > ovn/controller/lflow.h | 2 +- > ovn/controller/pinctrl.c | 109 +++++++++- > ovn/lib/actions.c | 121 ++++++++++- > ovn/lib/automake.mk | 1 - > ovn/lib/expr.c | 17 +- > ovn/lib/logical-fields.c | 36 +++- > ovn/northd/ovn-northd.8.xml | 83 +++++++- > ovn/northd/ovn-northd.c | 94 +++++++- > ovn/ovn-sb.xml | 41 +++- > ovn/utilities/ovn-trace.c | 34 ++- > tests/odp.at | 5 + > tests/ofp-actions.at | 6 + > tests/ofproto-dpif.at | 163 ++++++++++++++ > tests/ovn.at | 200 ++++++++++++++++++ > tests/test-ovn.c | 2 +- > 37 files changed, 1753 insertions(+), 29 deletions(-) > rename {ovn/lib => include/ovn}/logical-fields.h (73%) > > -- > 2.20.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
From: Numan Siddique <nusiddiq@redhat.com> This series addresses the MTU issues for OVN reported here [1]. This series has 6 patches Patch 1 adds a new OVS action - check_pkt_larger. It makes use of the datapath action - 'check_pkt_len' which was added recently to net-next [2]. Patch 2 is the datapath patch from [1] for the OVS in tree datapath code. Patch 2 is submitted after patch 1 to avoid the compilation issues since we are adding a new action attr - OVS_ACTION_ATTR_CHECK_PKT_LEN. Patch 3 to 6 are OVN patches. This patch series addressed most of the comments received for the RFC series. Patch 1 still hasn't addressed the comment for the usage of 'check_pkt_larger' action i.e check_pkt_larger(len)->REG_BIT. [1] - https://mail.openvswitch.org/pipermail/ovs-discuss/2018-July/047039.html [2] - https://kernel.googlesource.com/pub/scm/linux/kernel/git/davem/net-next/+/4d5ec89fc8d14dcdab7214a0c13a1c7321dc6ea9 v1 -> v2 ------ * Updated the commit message of patch 2 to include the net-next commit id, author and date. No other changes. Numan Siddique (6): Add a new OVS action check_pkt_larger datapath: Add a new action check_pkt_len ovn: Add a new OVN field icmp4.frag_mtu ovn: Add a new OVN action 'icmp4_error' ovn: Support OVS action 'check_pkt_larger' in OVN ovn: Generate ICMPv4 packet in router pipeline for larger packets NEWS | 2 + datapath/actions.c | 44 ++++ datapath/flow_netlink.c | 171 +++++++++++++++ .../linux/compat/include/linux/openvswitch.h | 39 ++++ include/openvswitch/ofp-actions.h | 19 ++ include/ovn/actions.h | 42 +++- include/ovn/automake.mk | 3 +- include/ovn/expr.h | 5 + {ovn/lib => include/ovn}/logical-fields.h | 39 ++++ lib/dpif-netdev.c | 1 + lib/dpif.c | 1 + lib/odp-execute.c | 72 +++++++ lib/odp-util.c | 86 ++++++++ lib/ofp-actions.c | 121 ++++++++++- lib/ofp-parse.c | 10 + lib/ovs-actions.xml | 31 +++ ofproto/ofproto-dpif-ipfix.c | 1 + ofproto/ofproto-dpif-sflow.c | 1 + ofproto/ofproto-dpif-xlate.c | 131 ++++++++++++ ofproto/ofproto-dpif.c | 43 ++++ ofproto/ofproto-dpif.h | 5 +- ovn/controller/lflow.c | 1 + ovn/controller/lflow.h | 2 +- ovn/controller/pinctrl.c | 109 +++++++++- ovn/lib/actions.c | 121 ++++++++++- ovn/lib/automake.mk | 1 - ovn/lib/expr.c | 17 +- ovn/lib/logical-fields.c | 36 +++- ovn/northd/ovn-northd.8.xml | 83 +++++++- ovn/northd/ovn-northd.c | 94 +++++++- ovn/ovn-sb.xml | 41 +++- ovn/utilities/ovn-trace.c | 34 ++- tests/odp.at | 5 + tests/ofp-actions.at | 6 + tests/ofproto-dpif.at | 163 ++++++++++++++ tests/ovn.at | 200 ++++++++++++++++++ tests/test-ovn.c | 2 +- 37 files changed, 1753 insertions(+), 29 deletions(-) rename {ovn/lib => include/ovn}/logical-fields.h (73%)