Message ID | 20190214065635.GA21768@kadam |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | atm: clean up vcc_seq_next() | expand |
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Thu, 14 Feb 2019 09:56:35 +0300 > It's confusing to call PTR_ERR(v). The PTR_ERR() function is basically > a fancy cast to long so it makes you wonder, was IS_ERR() intended? But > that doesn't make sense because vcc_walk() doesn't return error > pointers. > > This patch doesn't affect runtime, it's just a cleanup. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied.
diff --git a/net/atm/proc.c b/net/atm/proc.c index 0b0495a41bbe..d79221fd4dae 100644 --- a/net/atm/proc.c +++ b/net/atm/proc.c @@ -134,7 +134,8 @@ static void vcc_seq_stop(struct seq_file *seq, void *v) static void *vcc_seq_next(struct seq_file *seq, void *v, loff_t *pos) { v = vcc_walk(seq, 1); - *pos += !!PTR_ERR(v); + if (v) + (*pos)++; return v; }
It's confusing to call PTR_ERR(v). The PTR_ERR() function is basically a fancy cast to long so it makes you wonder, was IS_ERR() intended? But that doesn't make sense because vcc_walk() doesn't return error pointers. This patch doesn't affect runtime, it's just a cleanup. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- net/atm/proc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)