diff mbox series

[bpf-next] bpf: remove obsolete prog->aux sanitation in bpf_insn_prepare_dump

Message ID 20181212094538.10404-1-daniel@iogearbox.net
State Accepted, archived
Delegated to: BPF Maintainers
Headers show
Series [bpf-next] bpf: remove obsolete prog->aux sanitation in bpf_insn_prepare_dump | expand

Commit Message

Daniel Borkmann Dec. 12, 2018, 9:45 a.m. UTC
This logic is not needed anymore since we got rid of the verifier
rewrite that was using prog->aux address in f6069b9aa993 ("bpf:
fix redirect to map under tail calls").

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
---
 kernel/bpf/syscall.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Alexei Starovoitov Dec. 13, 2018, 8:44 p.m. UTC | #1
On Wed, Dec 12, 2018 at 10:45:38AM +0100, Daniel Borkmann wrote:
> This logic is not needed anymore since we got rid of the verifier
> rewrite that was using prog->aux address in f6069b9aa993 ("bpf:
> fix redirect to map under tail calls").
> 
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

Applied, Thanks
diff mbox series

Patch

diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index 5745c78..330010d 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -2031,13 +2031,6 @@  static struct bpf_insn *bpf_insn_prepare_dump(const struct bpf_prog *prog)
 			insns[i + 1].imm = 0;
 			continue;
 		}
-
-		if (!bpf_dump_raw_ok() &&
-		    imm == (unsigned long)prog->aux) {
-			insns[i].imm = 0;
-			insns[i + 1].imm = 0;
-			continue;
-		}
 	}
 
 	return insns;