| Message ID | 20180828154433.5693-1-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] ARM: omap: Convert to using %pOFn instead of device_node.name | expand |
On Tue, Aug 28, 2018 at 10:44:28AM -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. Please don't send new patches in reply to existing threads, it makes it harder to follow what the current versions of things are.
Quoting Rob Herring (2018-08-28 08:44:29) > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org>
On Tue, Aug 28, 2018 at 5:15 PM Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Rob Herring (2018-08-28 08:44:29) > > In preparation to remove the node name pointer from struct device_node, > > convert printf users to use the %pOFn format specifier. > > > > Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> > > Cc: Michael Turquette <mturquette@baylibre.com> > > Cc: Stephen Boyd <sboyd@kernel.org> > > Cc: linux-clk@vger.kernel.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-renesas-soc@vger.kernel.org > > Cc: linux-omap@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > Reviewed-by: Stephen Boyd <sboyd@kernel.org> Please apply to the clock tree. There's no dependencies and removing name will take some time. Rob
Quoting Rob Herring (2018-08-29 04:13:44) > On Tue, Aug 28, 2018 at 5:15 PM Stephen Boyd <sboyd@kernel.org> wrote: > > > > Quoting Rob Herring (2018-08-28 08:44:29) > > > In preparation to remove the node name pointer from struct device_node, > > > convert printf users to use the %pOFn format specifier. > > > > > > Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> > > > Cc: Michael Turquette <mturquette@baylibre.com> > > > Cc: Stephen Boyd <sboyd@kernel.org> > > > Cc: linux-clk@vger.kernel.org > > > Cc: linux-arm-kernel@lists.infradead.org > > > Cc: linux-renesas-soc@vger.kernel.org > > > Cc: linux-omap@vger.kernel.org > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > --- > > > > Reviewed-by: Stephen Boyd <sboyd@kernel.org> > > Please apply to the clock tree. There's no dependencies and removing > name will take some time. > Alright. Applied to clk-next. Thanks!
* Rob Herring <robh@kernel.org> [180828 08:48]: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: "Benoît Cousson" <bcousson@baylibre.com> > Cc: Paul Walmsley <paul@pwsan.com> > Cc: Tony Lindgren <tony@atomide.com> > Cc: linux-omap@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > v2: > - fix error in format specifier position Thanks applying into omap-for-v4.20/soc. Regards, Tony
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 2ceffd85dd3d..9cc339048173 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/mach-omap2/omap_hwmod.c @@ -738,7 +738,7 @@ static int __init _setup_clkctrl_provider(struct device_node *np) provider->size = size | 0xff; provider->node = np; - pr_debug("%s: %s: %x...%x [+%x]\n", __func__, np->parent->name, + pr_debug("%s: %pOFn: %x...%x [+%x]\n", __func__, np->parent, provider->addr, provider->addr + provider->size, provider->offset); @@ -799,9 +799,9 @@ static struct clk *_lookup_clkctrl_clk(struct omap_hwmod *oh) clk = of_clk_get_from_provider(&clkspec); - pr_debug("%s: %s got %p (offset=%x, provider=%s)\n", + pr_debug("%s: %s got %p (offset=%x, provider=%pOFn)\n", __func__, oh->name, clk, clkspec.args[0], - provider->node->parent->name); + provider->node->parent); return clk; } @@ -2107,8 +2107,8 @@ static int of_dev_find_hwmod(struct device_node *np, if (res) continue; if (!strcmp(p, oh->name)) { - pr_debug("omap_hwmod: dt %s[%i] uses hwmod %s\n", - np->name, i, oh->name); + pr_debug("omap_hwmod: dt %pOFn[%i] uses hwmod %s\n", + np, i, oh->name); return i; } } @@ -2210,8 +2210,8 @@ int omap_hwmod_parse_module_range(struct omap_hwmod *oh, return -ENOENT; if (nr_addr != 1 || nr_size != 1) { - pr_err("%s: invalid range for %s->%s\n", __func__, - oh->name, np->name); + pr_err("%s: invalid range for %s->%pOFn\n", __func__, + oh->name, np); return -EINVAL; } @@ -2219,8 +2219,8 @@ int omap_hwmod_parse_module_range(struct omap_hwmod *oh, base = of_translate_address(np, ranges++); size = be32_to_cpup(ranges); - pr_debug("omap_hwmod: %s %s at 0x%llx size 0x%llx\n", - oh->name, np->name, base, size); + pr_debug("omap_hwmod: %s %pOFn at 0x%llx size 0x%llx\n", + oh->name, np, base, size); res->start = base; res->end = base + size - 1; @@ -2322,8 +2322,8 @@ static int __init _init(struct omap_hwmod *oh, void *data) if (r) pr_debug("omap_hwmod: %s missing dt data\n", oh->name); else if (np && index) - pr_warn("omap_hwmod: %s using broken dt data from %s\n", - oh->name, np->name); + pr_warn("omap_hwmod: %s using broken dt data from %pOFn\n", + oh->name, np); r = _init_mpu_rt_base(oh, NULL, index, np); if (r < 0) {
In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: "Benoît Cousson" <bcousson@baylibre.com> Cc: Paul Walmsley <paul@pwsan.com> Cc: Tony Lindgren <tony@atomide.com> Cc: linux-omap@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Rob Herring <robh@kernel.org> --- v2: - fix error in format specifier position arch/arm/mach-omap2/omap_hwmod.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) -- 2.17.1