Message ID | 1531376265-19709-1-git-send-email-alex.hung@canonical.com |
---|---|
State | Accepted |
Headers | show |
Series | klog.json: lower severity of temperature threshold | expand |
On 07/12/2018 02:17 PM, Alex Hung wrote: > Laptop computers are becoming smaller and lighter and thermal design > becomes a trade-off. As a result, it is common to see CPU temperatures > go above threshold. > > Let's lower severity to high instead of critical as it is by design. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > data/klog.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/data/klog.json b/data/klog.json > index f138b82..168effd 100644 > --- a/data/klog.json > +++ b/data/klog.json > @@ -1705,7 +1705,7 @@ atform Communications Channel Table (PCCT) and find the PCC subspace communicati > }, > { > "compare_mode": "regex", > - "log_level": "LOG_LEVEL_CRITICAL", > + "log_level": "LOG_LEVEL_HIGH", > "pattern": "[T|t]emperature above threshold, cpu clock throttled", > "advice": "Test caused CPU temperature above critical threshold. The CPU has been throttled to run slower because of over-heating above the critical threshold. CPU throttling will be turned off once the CPU has cooled sufficiently. Frequent throttling may indicate poor thermal design on the machine.", > "label": "KlogThermalOverrun" Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 12/07/18 07:17, Alex Hung wrote: > Laptop computers are becoming smaller and lighter and thermal design > becomes a trade-off. As a result, it is common to see CPU temperatures > go above threshold. > > Let's lower severity to high instead of critical as it is by design. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > data/klog.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/data/klog.json b/data/klog.json > index f138b82..168effd 100644 > --- a/data/klog.json > +++ b/data/klog.json > @@ -1705,7 +1705,7 @@ atform Communications Channel Table (PCCT) and find the PCC subspace communicati > }, > { > "compare_mode": "regex", > - "log_level": "LOG_LEVEL_CRITICAL", > + "log_level": "LOG_LEVEL_HIGH", > "pattern": "[T|t]emperature above threshold, cpu clock throttled", > "advice": "Test caused CPU temperature above critical threshold. The CPU has been throttled to run slower because of over-heating above the critical threshold. CPU throttling will be turned off once the CPU has cooled sufficiently. Frequent throttling may indicate poor thermal design on the machine.", > "label": "KlogThermalOverrun" > I guess so,, and with tools like thermald this should be managed so that we don't overheat nowadays. Acked-by: Colin Ian King <colin.king@canonical.com> Colin
diff --git a/data/klog.json b/data/klog.json index f138b82..168effd 100644 --- a/data/klog.json +++ b/data/klog.json @@ -1705,7 +1705,7 @@ atform Communications Channel Table (PCCT) and find the PCC subspace communicati }, { "compare_mode": "regex", - "log_level": "LOG_LEVEL_CRITICAL", + "log_level": "LOG_LEVEL_HIGH", "pattern": "[T|t]emperature above threshold, cpu clock throttled", "advice": "Test caused CPU temperature above critical threshold. The CPU has been throttled to run slower because of over-heating above the critical threshold. CPU throttling will be turned off once the CPU has cooled sufficiently. Frequent throttling may indicate poor thermal design on the machine.", "label": "KlogThermalOverrun"
Laptop computers are becoming smaller and lighter and thermal design becomes a trade-off. As a result, it is common to see CPU temperatures go above threshold. Let's lower severity to high instead of critical as it is by design. Signed-off-by: Alex Hung <alex.hung@canonical.com> --- data/klog.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)