Message ID | 1502736308-2047-1-git-send-email-gromero@linux.vnet.ibm.com |
---|---|
State | New |
Headers | show |
On Aug 14 2017, Gustavo Romero <gromero@linux.vnet.ibm.com> wrote: > + * elf/elf.h A (NT_PPC_TAR): New macro. > + (NT_PPC_PPR): Likewise. > + (NT_PPC_DSCR): Likewise. > + (NT_PPC_EBB): Likewise. > + (NT_PPC_PMU): Likewise. > + (NT_PPC_TM_CGPR): Likewise. > + (NT_PPC_TM_CFPR): Likewise. > + (NT_PPC_TM_CVMX): Likewise. > + (NT_PPC_TM_CVSX): Likewise. > + (NT_PPC_TM_SPR): Likewise. > + (NT_PPC_TM_CTAR): Likewise. > + (NT_PPC_TM_CPPR): Likewise. > + (NT_PPC_TM_CDSCR): Likewise. Ok. Andreas.
Hi Andreas, Adhemerval On 15-08-2017 09:45, Andreas Schwab wrote: > On Aug 14 2017, Gustavo Romero <gromero@linux.vnet.ibm.com> wrote: > >> + * elf/elf.h A (NT_PPC_TAR): New macro. >> + (NT_PPC_PPR): Likewise. >> + (NT_PPC_DSCR): Likewise. >> + (NT_PPC_EBB): Likewise. >> + (NT_PPC_PMU): Likewise. >> + (NT_PPC_TM_CGPR): Likewise. >> + (NT_PPC_TM_CFPR): Likewise. >> + (NT_PPC_TM_CVMX): Likewise. >> + (NT_PPC_TM_CVSX): Likewise. >> + (NT_PPC_TM_SPR): Likewise. >> + (NT_PPC_TM_CTAR): Likewise. >> + (NT_PPC_TM_CPPR): Likewise. >> + (NT_PPC_TM_CDSCR): Likewise. > > Ok. > > Andreas. Thanks a lot reviewing the change. Is it ready to be pushed or do I still need a sponsor? Regards, Gustavo
Gustavo Romero <gromero@linux.vnet.ibm.com> writes: > diff --git a/ChangeLog b/ChangeLog > index 56540f5..74faf23 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,19 @@ > +2017-08-14 Gustavo Romero <gromero@linux.vnet.ibm.com> > + > + * elf/elf.h A (NT_PPC_TAR): New macro. > + (NT_PPC_PPR): Likewise. > + (NT_PPC_DSCR): Likewise. > + (NT_PPC_EBB): Likewise. > + (NT_PPC_PMU): Likewise. > + (NT_PPC_TM_CGPR): Likewise. > + (NT_PPC_TM_CFPR): Likewise. > + (NT_PPC_TM_CVMX): Likewise. > + (NT_PPC_TM_CVSX): Likewise. > + (NT_PPC_TM_SPR): Likewise. > + (NT_PPC_TM_CTAR): Likewise. > + (NT_PPC_TM_CPPR): Likewise. > + (NT_PPC_TM_CDSCR): Likewise. > + Please, don't add ChangeLog entries in the diff. Leave them in the commit message. That helps merging your patch. > diff --git a/elf/elf.h b/elf/elf.h > index 3900b4c..2b05546 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -762,6 +762,19 @@ typedef struct > +#define NT_PPC_TM_CTAR 0x10d /* TM checkpointed Target Address Register */ > +#define NT_PPC_TM_CPPR 0x10e /* TM checkpointed Program Priority Register */ > +#define NT_PPC_TM_CDSCR 0x10f /* TM checkpointed Data Stream Control Register */ Lines shouldn't have more than 79 characters. For more information about this, please take a look at this wiki page: https://sourceware.org/glibc/wiki/Contribution%20checklist I fixed these cosmetics issues and pushed your patch as ee72219a497b. Thanks!
Hi Tulio, On 15-08-2017 10:27, Tulio Magno Quites Machado Filho wrote: > Gustavo Romero <gromero@linux.vnet.ibm.com> writes: > >> diff --git a/ChangeLog b/ChangeLog >> index 56540f5..74faf23 100644 >> --- a/ChangeLog >> +++ b/ChangeLog >> @@ -1,3 +1,19 @@ >> +2017-08-14 Gustavo Romero <gromero@linux.vnet.ibm.com> >> + >> + * elf/elf.h A (NT_PPC_TAR): New macro. >> + (NT_PPC_PPR): Likewise. >> + (NT_PPC_DSCR): Likewise. >> + (NT_PPC_EBB): Likewise. >> + (NT_PPC_PMU): Likewise. >> + (NT_PPC_TM_CGPR): Likewise. >> + (NT_PPC_TM_CFPR): Likewise. >> + (NT_PPC_TM_CVMX): Likewise. >> + (NT_PPC_TM_CVSX): Likewise. >> + (NT_PPC_TM_SPR): Likewise. >> + (NT_PPC_TM_CTAR): Likewise. >> + (NT_PPC_TM_CPPR): Likewise. >> + (NT_PPC_TM_CDSCR): Likewise. >> + > > Please, don't add ChangeLog entries in the diff. Leave them in the commit > message. That helps merging your patch. OK, thanks for letting me know. >> diff --git a/elf/elf.h b/elf/elf.h >> index 3900b4c..2b05546 100644 >> --- a/elf/elf.h >> +++ b/elf/elf.h >> @@ -762,6 +762,19 @@ typedef struct >> +#define NT_PPC_TM_CTAR 0x10d /* TM checkpointed Target Address Register */ >> +#define NT_PPC_TM_CPPR 0x10e /* TM checkpointed Program Priority Register */ >> +#define NT_PPC_TM_CDSCR 0x10f /* TM checkpointed Data Stream Control Register */ > > Lines shouldn't have more than 79 characters. > > For more information about this, please take a look at this wiki page: > https://sourceware.org/glibc/wiki/Contribution%20checklist > > I fixed these cosmetics issues and pushed your patch as ee72219a497b. Thanks a lot for reviewing and pushing it. Best regards, Gustavo
diff --git a/ChangeLog b/ChangeLog index 56540f5..74faf23 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,19 @@ +2017-08-14 Gustavo Romero <gromero@linux.vnet.ibm.com> + + * elf/elf.h A (NT_PPC_TAR): New macro. + (NT_PPC_PPR): Likewise. + (NT_PPC_DSCR): Likewise. + (NT_PPC_EBB): Likewise. + (NT_PPC_PMU): Likewise. + (NT_PPC_TM_CGPR): Likewise. + (NT_PPC_TM_CFPR): Likewise. + (NT_PPC_TM_CVMX): Likewise. + (NT_PPC_TM_CVSX): Likewise. + (NT_PPC_TM_SPR): Likewise. + (NT_PPC_TM_CTAR): Likewise. + (NT_PPC_TM_CPPR): Likewise. + (NT_PPC_TM_CDSCR): Likewise. + 2017-08-14 Joseph Myers <joseph@codesourcery.com> * conform/data/sys/wait.h-data (si_value): Do not expect for diff --git a/elf/elf.h b/elf/elf.h index 3900b4c..2b05546 100644 --- a/elf/elf.h +++ b/elf/elf.h @@ -762,6 +762,19 @@ typedef struct #define NT_PPC_VMX 0x100 /* PowerPC Altivec/VMX registers */ #define NT_PPC_SPE 0x101 /* PowerPC SPE/EVR registers */ #define NT_PPC_VSX 0x102 /* PowerPC VSX registers */ +#define NT_PPC_TAR 0x103 /* Target Address Register */ +#define NT_PPC_PPR 0x104 /* Program Priority Register */ +#define NT_PPC_DSCR 0x105 /* Data Stream Control Register */ +#define NT_PPC_EBB 0x106 /* Event Based Branch Registers */ +#define NT_PPC_PMU 0x107 /* Performance Monitor Registers */ +#define NT_PPC_TM_CGPR 0x108 /* TM checkpointed GPR Registers */ +#define NT_PPC_TM_CFPR 0x109 /* TM checkpointed FPR Registers */ +#define NT_PPC_TM_CVMX 0x10a /* TM checkpointed VMX Registers */ +#define NT_PPC_TM_CVSX 0x10b /* TM checkpointed VSX Registers */ +#define NT_PPC_TM_SPR 0x10c /* TM Special Purpose Registers */ +#define NT_PPC_TM_CTAR 0x10d /* TM checkpointed Target Address Register */ +#define NT_PPC_TM_CPPR 0x10e /* TM checkpointed Program Priority Register */ +#define NT_PPC_TM_CDSCR 0x10f /* TM checkpointed Data Stream Control Register */ #define NT_386_TLS 0x200 /* i386 TLS slots (struct user_desc) */ #define NT_386_IOPERM 0x201 /* x86 io permission bitmap (1=deny) */ #define NT_X86_XSTATE 0x202 /* x86 extended state using xsave */