diff mbox

dt-bindings: power: supply: cpcap-battery: Add power-supplies property

Message ID 20170612160400.GY3730@atomide.com
State Not Applicable, archived
Headers show

Commit Message

Tony Lindgren June 12, 2017, 4:04 p.m. UTC
* Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170612 07:26]:
> On Mon, Jun 12, 2017 at 12:20:25AM -0700, Tony Lindgren wrote:
> > +- power-supplies: List of devices that supply power, typically cpcap_charger
> 
> This is missing the info, that its about phandles. Maybe:
> 
> - power-supplies: List of phandles for power-supplying devices, as
>                   described in power_supply.txt. Typically a reference
>                   to cpcap_charger.

Sure, updated patch below.

Regards,

Tony

8< ------
>From tony Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Mon, 12 Jun 2017 00:13:45 -0700
Subject: [PATCH] dt-bindings: power: supply: cpcap-battery: Add
 power-supplies property

The binding for cpcap-battery is missing the standard power-supplies
property as noted by Sebastian Reichel <sebastian.reichel@collabora.co.uk>.

Cc: devicetree@vger.kernel.org
Cc: Marcel Partap <mpartap@gmx.net>
Cc: Michael Scott <michael.scott@linaro.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 Documentation/devicetree/bindings/power/supply/cpcap-battery.txt | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Sebastian Reichel June 15, 2017, 12:54 p.m. UTC | #1
Hi,

On Mon, Jun 12, 2017 at 09:04:00AM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170612 07:26]:
> > On Mon, Jun 12, 2017 at 12:20:25AM -0700, Tony Lindgren wrote:
> > > +- power-supplies: List of devices that supply power, typically cpcap_charger
> > 
> > This is missing the info, that its about phandles. Maybe:
> > 
> > - power-supplies: List of phandles for power-supplying devices, as
> >                   described in power_supply.txt. Typically a reference
> >                   to cpcap_charger.
> 
> Sure, updated patch below.

I queued that one.

-- Sebastian

> 8< ------
> From tony Mon Sep 17 00:00:00 2001
> From: Tony Lindgren <tony@atomide.com>
> Date: Mon, 12 Jun 2017 00:13:45 -0700
> Subject: [PATCH] dt-bindings: power: supply: cpcap-battery: Add
>  power-supplies property
> 
> The binding for cpcap-battery is missing the standard power-supplies
> property as noted by Sebastian Reichel <sebastian.reichel@collabora.co.uk>.
> 
> Cc: devicetree@vger.kernel.org
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  Documentation/devicetree/bindings/power/supply/cpcap-battery.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> --- a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> @@ -8,6 +8,9 @@ Required properties:
>  - io-channels: IIO ADC channel specifier for each name in io-channel-names
>  - io-channel-names: Should contain the following entries:
>  		    "battdetb", "battp", "chg_isense", "batti"
> +- power-supplies: List of phandles for power-supplying devices, as
> +		  described in power_supply.txt. Typically a reference
> +		  to cpcap_charger.
>  
>  Example:
>  
> @@ -24,4 +27,5 @@ cpcap_battery: battery {
>  		       &cpcap_adc 5 &cpcap_adc 6>;
>  	io-channel-names = "battdetb", "battp",
>  			   "chg_isense", "batti";
> +	power-supplies = <&cpcap_charger>;
>  };
> -- 
> 2.13.0
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring (Arm) June 18, 2017, 2:04 p.m. UTC | #2
On Mon, Jun 12, 2017 at 09:04:00AM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170612 07:26]:
> > On Mon, Jun 12, 2017 at 12:20:25AM -0700, Tony Lindgren wrote:
> > > +- power-supplies: List of devices that supply power, typically cpcap_charger
> > 
> > This is missing the info, that its about phandles. Maybe:
> > 
> > - power-supplies: List of phandles for power-supplying devices, as
> >                   described in power_supply.txt. Typically a reference
> >                   to cpcap_charger.
> 
> Sure, updated patch below.
> 
> Regards,
> 
> Tony
> 
> 8< ------
> From tony Mon Sep 17 00:00:00 2001
> From: Tony Lindgren <tony@atomide.com>
> Date: Mon, 12 Jun 2017 00:13:45 -0700
> Subject: [PATCH] dt-bindings: power: supply: cpcap-battery: Add
>  power-supplies property
> 
> The binding for cpcap-battery is missing the standard power-supplies
> property as noted by Sebastian Reichel <sebastian.reichel@collabora.co.uk>.
> 
> Cc: devicetree@vger.kernel.org
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  Documentation/devicetree/bindings/power/supply/cpcap-battery.txt | 4 ++++
>  1 file changed, 4 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
--- a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
+++ b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
@@ -8,6 +8,9 @@  Required properties:
 - io-channels: IIO ADC channel specifier for each name in io-channel-names
 - io-channel-names: Should contain the following entries:
 		    "battdetb", "battp", "chg_isense", "batti"
+- power-supplies: List of phandles for power-supplying devices, as
+		  described in power_supply.txt. Typically a reference
+		  to cpcap_charger.
 
 Example:
 
@@ -24,4 +27,5 @@  cpcap_battery: battery {
 		       &cpcap_adc 5 &cpcap_adc 6>;
 	io-channel-names = "battdetb", "battp",
 			   "chg_isense", "batti";
+	power-supplies = <&cpcap_charger>;
 };