diff mbox

[ovs-dev] windows: netdev report error if query failed

Message ID 20170208064112.2360-1-aserdean@cloudbasesolutions.com
State Accepted
Headers show

Commit Message

Alin Serdean Feb. 8, 2017, 6:41 a.m. UTC
The netdev Windows construct uses query_netdev to see if a port exists
in the datapath, in the case an error occurred in the reply message
we returned 0, meaning netdev_open was successful.

This patch fixes fixes that problem.

Reported-at: https://github.com/openvswitch/ovs-issues/issues/125
Reported-by: Shashank Ram <rams@vmware.com>
Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
---
intended for: branch-2.5, branch-2.6, branch-2.7, master
---
 lib/netdev-windows.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gurucharan Shetty Feb. 8, 2017, 6:18 p.m. UTC | #1
On 7 February 2017 at 22:41, Alin Serdean <aserdean@cloudbasesolutions.com>
wrote:

> The netdev Windows construct uses query_netdev to see if a port exists
> in the datapath, in the case an error occurred in the reply message
> we returned 0, meaning netdev_open was successful.
>
> This patch fixes fixes that problem.
>
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/125
> Reported-by: Shashank Ram <rams@vmware.com>
> Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
> ---
> intended for: branch-2.5, branch-2.6, branch-2.7, master
>
Thanks, applied to all the above branches.


> ---
>  lib/netdev-windows.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/netdev-windows.c b/lib/netdev-windows.c
> index c2fbe42..b22bd09 100644
> --- a/lib/netdev-windows.c
> +++ b/lib/netdev-windows.c
> @@ -295,7 +295,7 @@ query_netdev(const char *devname,
>          }
>      }
>
> -    return 0;
> +    return error;
>  }
>
>  static void
> --
> 2.10.2.windows.1
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox

Patch

diff --git a/lib/netdev-windows.c b/lib/netdev-windows.c
index c2fbe42..b22bd09 100644
--- a/lib/netdev-windows.c
+++ b/lib/netdev-windows.c
@@ -295,7 +295,7 @@  query_netdev(const char *devname,
         }
     }
 
-    return 0;
+    return error;
 }
 
 static void