diff mbox

[ovs-dev,v2,1/2] utilities: ovs-lib: Signal start_daemon failures

Message ID 20160912090757.23511-1-mchandras@suse.de
State Accepted
Headers show

Commit Message

Markos Chandras Sept. 12, 2016, 9:07 a.m. UTC
Make sure we communicate failures to the caller when start_daemon fails
to start a process as the caller may not be able to proceed after this.

Cc: Aaron Conole <aconole@redhat.com>
Signed-off-by: Markos Chandras <mchandras@suse.de>
---
 utilities/ovs-lib.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Aaron Conole Sept. 12, 2016, 12:44 p.m. UTC | #1
Markos Chandras <mchandras@suse.de> writes:

> Make sure we communicate failures to the caller when start_daemon fails
> to start a process as the caller may not be able to proceed after this.
>
> Cc: Aaron Conole <aconole@redhat.com>
> Signed-off-by: Markos Chandras <mchandras@suse.de>

Acked-by: Aaron Conole <aconole@redhat.com>
diff mbox

Patch

diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in
index cbad85a..68197a4 100644
--- a/utilities/ovs-lib.in
+++ b/utilities/ovs-lib.in
@@ -207,7 +207,7 @@  start_daemon () {
         set nice -n "$priority" "$@"
     fi
 
-    action "Starting $daemon" "$@"
+    action "Starting $daemon" "$@" || return 1
 
     if test X"$strace" != X; then
         # Strace doesn't have the -D option so we attach after the fact.