| Message ID | 1464854696-29513-1-git-send-email-kjlu@gatech.edu |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Kangjie Lu <kangjielu@gmail.com> Date: Thu, 2 Jun 2016 04:04:56 -0400 > link_info.str is a char array of size 60. Memory after the NULL > byte is not initialized. Sending the whole object out can cause > a leak. > > Signed-off-by: Kangjie Lu <kjlu@gatech.edu> Applied.
diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index f795b1d..2518014 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -604,7 +604,8 @@ static int tipc_nl_compat_link_dump(struct tipc_nl_compat_msg *msg, link_info.dest = nla_get_flag(link[TIPC_NLA_LINK_DEST]); link_info.up = htonl(nla_get_flag(link[TIPC_NLA_LINK_UP])); - strcpy(link_info.str, nla_data(link[TIPC_NLA_LINK_NAME])); + nla_strlcpy(link_info.str, nla_data(link[TIPC_NLA_LINK_NAME]), + TIPC_MAX_LINK_NAME); return tipc_add_tlv(msg->rep, TIPC_TLV_LINK_INFO, &link_info, sizeof(link_info));
link_info.str is a char array of size 60. Memory after the NULL byte is not initialized. Sending the whole object out can cause a leak. Signed-off-by: Kangjie Lu <kjlu@gatech.edu> --- net/tipc/netlink_compat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)