Message ID | 1448387222-29879-1-git-send-email-clg@fr.ibm.com |
---|---|
State | Accepted |
Headers | show |
Cédric Le Goater <clg@fr.ibm.com> writes: > Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> > --- > include/ipmi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: skiboot.git/include/ipmi.h > =================================================================== > --- skiboot.git.orig/include/ipmi.h > +++ skiboot.git/include/ipmi.h > @@ -117,7 +117,7 @@ > #define IPMI_GET_MESSAGE_FLAGS IPMI_CODE(IPMI_NETFN_APP, 0x31) > #define IPMI_GET_MESSAGE IPMI_CODE(IPMI_NETFN_APP, 0x33) > #define IPMI_READ_EVENT IPMI_CODE(IPMI_NETFN_APP, 0x35) > -#define IPMI_GET_BT_CAPS IPMI_CODE(IPMI_NETFN_APP, 0x56) > +#define IPMI_GET_BT_CAPS IPMI_CODE(IPMI_NETFN_APP, 0x36) > #define IPMI_SET_SENSOR_READING IPMI_CODE(IPMI_NETFN_SE, 0x30) > > /* AMI OEM comamnds. AMI uses NETFN 0x3a and 0x32 */ Which bit of doc/standard has this in it? From quickly leafing through the IPMI spec I didn't see it, but then again, I was doing naive search :)
On Wed, 06 Jan 2016 16:31:51 +1100 Stewart Smith <stewart@linux.vnet.ibm.com> wrote: > Cédric Le Goater <clg@fr.ibm.com> writes: > > Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> > > --- > > include/ipmi.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Index: skiboot.git/include/ipmi.h > > =================================================================== > > --- skiboot.git.orig/include/ipmi.h > > +++ skiboot.git/include/ipmi.h > > @@ -117,7 +117,7 @@ > > #define IPMI_GET_MESSAGE_FLAGS IPMI_CODE(IPMI_NETFN_APP, 0x31) > > #define IPMI_GET_MESSAGE IPMI_CODE(IPMI_NETFN_APP, 0x33) > > #define IPMI_READ_EVENT IPMI_CODE(IPMI_NETFN_APP, 0x35) > > -#define IPMI_GET_BT_CAPS IPMI_CODE(IPMI_NETFN_APP, 0x56) > > +#define IPMI_GET_BT_CAPS IPMI_CODE(IPMI_NETFN_APP, 0x36) > > #define IPMI_SET_SENSOR_READING IPMI_CODE(IPMI_NETFN_SE, 0x30) > > > > /* AMI OEM comamnds. AMI uses NETFN 0x3a and 0x32 */ > > Which bit of doc/standard has this in it? From quickly leafing through > the IPMI spec I didn't see it, but then again, I was doing naive search :) > Those documents are terrible, don't go to section 22.10 because despite being where you might expect to find the information you want, you wont. In http://www.intel.com.au/content/dam/www/public/us/en/documents/product-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf page 587 under BMC Device and Messaging Commands :)
On 01/06/2016 07:36 AM, Cyril Bur wrote: > On Wed, 06 Jan 2016 16:31:51 +1100 > Stewart Smith <stewart@linux.vnet.ibm.com> wrote: > >> Cédric Le Goater <clg@fr.ibm.com> writes: >>> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> >>> --- >>> include/ipmi.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> Index: skiboot.git/include/ipmi.h >>> =================================================================== >>> --- skiboot.git.orig/include/ipmi.h >>> +++ skiboot.git/include/ipmi.h >>> @@ -117,7 +117,7 @@ >>> #define IPMI_GET_MESSAGE_FLAGS IPMI_CODE(IPMI_NETFN_APP, 0x31) >>> #define IPMI_GET_MESSAGE IPMI_CODE(IPMI_NETFN_APP, 0x33) >>> #define IPMI_READ_EVENT IPMI_CODE(IPMI_NETFN_APP, 0x35) >>> -#define IPMI_GET_BT_CAPS IPMI_CODE(IPMI_NETFN_APP, 0x56) >>> +#define IPMI_GET_BT_CAPS IPMI_CODE(IPMI_NETFN_APP, 0x36) >>> #define IPMI_SET_SENSOR_READING IPMI_CODE(IPMI_NETFN_SE, 0x30) >>> >>> /* AMI OEM comamnds. AMI uses NETFN 0x3a and 0x32 */ >> >> Which bit of doc/standard has this in it? From quickly leafing through >> the IPMI spec I didn't see it, but then again, I was doing naive search :) >> > > Those documents are terrible, don't go to section 22.10 because despite being > where you might expect to find the information you want, you wont. In > http://www.intel.com.au/content/dam/www/public/us/en/documents/product-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf > page 587 under BMC Device and Messaging Commands :) > yes. the IPMI specs is a but hard to digest ... Appendix G has all the command numbers. C.
Cyril Bur <cyril.bur@au1.ibm.com> writes: > On Wed, 06 Jan 2016 16:31:51 +1100 > Stewart Smith <stewart@linux.vnet.ibm.com> wrote: > >> Cédric Le Goater <clg@fr.ibm.com> writes: >> > Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> >> > --- >> > include/ipmi.h | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > Index: skiboot.git/include/ipmi.h >> > =================================================================== >> > --- skiboot.git.orig/include/ipmi.h >> > +++ skiboot.git/include/ipmi.h >> > @@ -117,7 +117,7 @@ >> > #define IPMI_GET_MESSAGE_FLAGS IPMI_CODE(IPMI_NETFN_APP, 0x31) >> > #define IPMI_GET_MESSAGE IPMI_CODE(IPMI_NETFN_APP, 0x33) >> > #define IPMI_READ_EVENT IPMI_CODE(IPMI_NETFN_APP, 0x35) >> > -#define IPMI_GET_BT_CAPS IPMI_CODE(IPMI_NETFN_APP, 0x56) >> > +#define IPMI_GET_BT_CAPS IPMI_CODE(IPMI_NETFN_APP, 0x36) >> > #define IPMI_SET_SENSOR_READING IPMI_CODE(IPMI_NETFN_SE, 0x30) >> > >> > /* AMI OEM comamnds. AMI uses NETFN 0x3a and 0x32 */ >> >> Which bit of doc/standard has this in it? From quickly leafing through >> the IPMI spec I didn't see it, but then again, I was doing naive search :) >> > > Those documents are terrible, don't go to section 22.10 because despite being > where you might expect to find the information you want, you wont. In > http://www.intel.com.au/content/dam/www/public/us/en/documents/product-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf > page 587 under BMC Device and Messaging Commands :) Thanks! Looks good to merge, so merged as of 82a7884 with the added bit of note about where the spec is found.
Index: skiboot.git/include/ipmi.h =================================================================== --- skiboot.git.orig/include/ipmi.h +++ skiboot.git/include/ipmi.h @@ -117,7 +117,7 @@ #define IPMI_GET_MESSAGE_FLAGS IPMI_CODE(IPMI_NETFN_APP, 0x31) #define IPMI_GET_MESSAGE IPMI_CODE(IPMI_NETFN_APP, 0x33) #define IPMI_READ_EVENT IPMI_CODE(IPMI_NETFN_APP, 0x35) -#define IPMI_GET_BT_CAPS IPMI_CODE(IPMI_NETFN_APP, 0x56) +#define IPMI_GET_BT_CAPS IPMI_CODE(IPMI_NETFN_APP, 0x36) #define IPMI_SET_SENSOR_READING IPMI_CODE(IPMI_NETFN_SE, 0x30) /* AMI OEM comamnds. AMI uses NETFN 0x3a and 0x32 */
Signed-off-by: Cédric Le Goater <clg@fr.ibm.com> --- include/ipmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)