| Message ID | 1451908927-11605-1-git-send-email-cristian@samknows.com |
|---|---|
| State | Accepted |
| Headers | show |
2016-01-04 13:02 GMT+01:00, Cristian Morales Vega <cristian@samknows.com>: > Signed-off-by: Cristian Morales Vega <cristian@samknows.com> > --- > target/linux/ramips/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/linux/ramips/Makefile b/target/linux/ramips/Makefile > index 9d7bb5b..378e2f5 100644 > --- a/target/linux/ramips/Makefile > +++ b/target/linux/ramips/Makefile > @@ -10,7 +10,7 @@ ARCH:=mipsel > BOARD:=ramips > BOARDNAME:=Ralink RT288x/RT3xxx > SUBTARGETS:=rt305x mt7620 mt7621 mt7628 mt7688 rt3883 rt288x > -FEATURES:=squashfs gpio > +FEATURES:=squashfs gpio mips16 > MAINTAINER:=John Crispin <blogic@openwrt.org> > > KERNEL_PATCHVER:=4.3 > -- > 2.5.0 AFAIK the RT288X family do not support mips16 (they have a MIPS 4KEc cpu if I'm not wrong).
On 2016-01-05 13:18, José Vázquez wrote: > 2016-01-04 13:02 GMT+01:00, Cristian Morales Vega <cristian@samknows.com>: >> Signed-off-by: Cristian Morales Vega <cristian@samknows.com> >> --- >> target/linux/ramips/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target/linux/ramips/Makefile b/target/linux/ramips/Makefile >> index 9d7bb5b..378e2f5 100644 >> --- a/target/linux/ramips/Makefile >> +++ b/target/linux/ramips/Makefile >> @@ -10,7 +10,7 @@ ARCH:=mipsel >> BOARD:=ramips >> BOARDNAME:=Ralink RT288x/RT3xxx >> SUBTARGETS:=rt305x mt7620 mt7621 mt7628 mt7688 rt3883 rt288x >> -FEATURES:=squashfs gpio >> +FEATURES:=squashfs gpio mips16 >> MAINTAINER:=John Crispin <blogic@openwrt.org> >> >> KERNEL_PATCHVER:=4.3 >> -- >> 2.5.0 > > AFAIK the RT288X family do not support mips16 (they have a MIPS 4KEc > cpu if I'm not wrong). Nice catch, thanks. Fixed in r48137 - Felix
On 5 January 2016 at 12:22, Felix Fietkau <nbd@openwrt.org> wrote: > On 2016-01-05 13:18, José Vázquez wrote: >> 2016-01-04 13:02 GMT+01:00, Cristian Morales Vega <cristian@samknows.com>: >>> Signed-off-by: Cristian Morales Vega <cristian@samknows.com> >>> --- >>> target/linux/ramips/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/target/linux/ramips/Makefile b/target/linux/ramips/Makefile >>> index 9d7bb5b..378e2f5 100644 >>> --- a/target/linux/ramips/Makefile >>> +++ b/target/linux/ramips/Makefile >>> @@ -10,7 +10,7 @@ ARCH:=mipsel >>> BOARD:=ramips >>> BOARDNAME:=Ralink RT288x/RT3xxx >>> SUBTARGETS:=rt305x mt7620 mt7621 mt7628 mt7688 rt3883 rt288x >>> -FEATURES:=squashfs gpio >>> +FEATURES:=squashfs gpio mips16 >>> MAINTAINER:=John Crispin <blogic@openwrt.org> >>> >>> KERNEL_PATCHVER:=4.3 >>> -- >>> 2.5.0 >> >> AFAIK the RT288X family do not support mips16 (they have a MIPS 4KEc >> cpu if I'm not wrong). > Nice catch, thanks. Fixed in r48137 Not arguing either against or in favour of backporting it to 15.05. But I see the RT288x fix has been backported... but not the MIPS16 support. It was intended to be backported?
diff --git a/target/linux/ramips/Makefile b/target/linux/ramips/Makefile index 9d7bb5b..378e2f5 100644 --- a/target/linux/ramips/Makefile +++ b/target/linux/ramips/Makefile @@ -10,7 +10,7 @@ ARCH:=mipsel BOARD:=ramips BOARDNAME:=Ralink RT288x/RT3xxx SUBTARGETS:=rt305x mt7620 mt7621 mt7628 mt7688 rt3883 rt288x -FEATURES:=squashfs gpio +FEATURES:=squashfs gpio mips16 MAINTAINER:=John Crispin <blogic@openwrt.org> KERNEL_PATCHVER:=4.3
Signed-off-by: Cristian Morales Vega <cristian@samknows.com> --- target/linux/ramips/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)