| Message ID | 1447654883-8097-2-git-send-email-diproiettod@vmware.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Sun, Nov 15, 2015 at 10:21:12PM -0800, Daniele Di Proietto wrote: > Linux and FreeBSD have different names for these constants. Windows > doesn't define them. It is simpler to redefine them from scratch for > OVS. > > These definitions will be used by a future commit. > > Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com> I guess that the names used here don't conflict with any of the others? Acked-by: Ben Pfaff <blp@ovn.org>
diff --git a/lib/packets.h b/lib/packets.h index de8d4b6..e1b310c 100644 --- a/lib/packets.h +++ b/lib/packets.h @@ -606,9 +606,21 @@ struct ip_header { ovs_16aligned_be32 ip_src; ovs_16aligned_be32 ip_dst; }; - BUILD_ASSERT_DECL(IP_HEADER_LEN == sizeof(struct ip_header)); +/* ICMP types. */ +#define ICMP_ECHO_REPLY 0 +#define ICMP_DST_UNREACH 3 +#define ICMP_SOURCEQUENCH 4 +#define ICMP_REDIRECT 5 +#define ICMP_ECHO_REQUEST 8 +#define ICMP_TIME_EXCEEDED 11 +#define ICMP_PARAM_PROB 12 +#define ICMP_TIMESTAMP 13 +#define ICMP_TIMESTAMPREPLY 14 +#define ICMP_INFOREQUEST 15 +#define ICMP_INFOREPLY 16 + #define ICMP_HEADER_LEN 8 struct icmp_header { uint8_t icmp_type;
Linux and FreeBSD have different names for these constants. Windows doesn't define them. It is simpler to redefine them from scratch for OVS. These definitions will be used by a future commit. Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com> --- lib/packets.h | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)