| Message ID | 1447687238-11559-1-git-send-email-fabio.estevam@freescale.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Nov 16, 2015 at 01:20:38PM -0200, Fabio Estevam wrote: > Select CONFIG_DRM_DW_HDMI_AHB_AUDIO so that we have HDMI audio > supported by default. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > Changes since v1: > - Select the driver as module instead of built-in I've applied a previous version. Should I replace it with this one? Shawn > > arch/arm/configs/imx_v6_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig > index 4187f69..f5ca938 100644 > --- a/arch/arm/configs/imx_v6_v7_defconfig > +++ b/arch/arm/configs/imx_v6_v7_defconfig > @@ -224,6 +224,7 @@ CONFIG_SOC_CAMERA_OV2640=y > CONFIG_IMX_IPUV3_CORE=y > CONFIG_DRM=y > CONFIG_DRM_PANEL_SIMPLE=y > +CONFIG_DRM_DW_HDMI_AHB_AUDIO=m > CONFIG_DRM_IMX=y > CONFIG_DRM_IMX_FB_HELPER=y > CONFIG_DRM_IMX_PARALLEL_DISPLAY=y > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
On Tue, Nov 24, 2015 at 4:20 AM, Shawn Guo <shawnguo@kernel.org> wrote: > On Mon, Nov 16, 2015 at 01:20:38PM -0200, Fabio Estevam wrote: >> Select CONFIG_DRM_DW_HDMI_AHB_AUDIO so that we have HDMI audio >> supported by default. >> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >> --- >> Changes since v1: >> - Select the driver as module instead of built-in > > I've applied a previous version. Should I replace it with this one? Yes, please. The latest version uses module instead of built-in. Selecting the driver as module is better as it will not impact current users. For example: currently on a mx6qsabresd when we do 'aplay file.wav' it will play through the wm8962 card. If the HDMI audio driver is selected as built-in, then 'aplay file.wav' will play through the HDMI audio port, which may confuse the end user. If we select the HDMI audio driver as module then we keep the original behaviour. Thanks
On Tue, Nov 24, 2015 at 07:25:13AM -0200, Fabio Estevam wrote: > On Tue, Nov 24, 2015 at 4:20 AM, Shawn Guo <shawnguo@kernel.org> wrote: > > On Mon, Nov 16, 2015 at 01:20:38PM -0200, Fabio Estevam wrote: > >> Select CONFIG_DRM_DW_HDMI_AHB_AUDIO so that we have HDMI audio > >> supported by default. > >> > >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > >> --- > >> Changes since v1: > >> - Select the driver as module instead of built-in > > > > I've applied a previous version. Should I replace it with this one? > > Yes, please. Done.
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 4187f69..f5ca938 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -224,6 +224,7 @@ CONFIG_SOC_CAMERA_OV2640=y CONFIG_IMX_IPUV3_CORE=y CONFIG_DRM=y CONFIG_DRM_PANEL_SIMPLE=y +CONFIG_DRM_DW_HDMI_AHB_AUDIO=m CONFIG_DRM_IMX=y CONFIG_DRM_IMX_FB_HELPER=y CONFIG_DRM_IMX_PARALLEL_DISPLAY=y
Select CONFIG_DRM_DW_HDMI_AHB_AUDIO so that we have HDMI audio supported by default. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- Changes since v1: - Select the driver as module instead of built-in arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+)