Message ID | 1441365913-30214-2-git-send-email-hegdevasant@linux.vnet.ibm.com |
---|---|
State | Accepted |
Headers | show |
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes: > eSEL logging fails, if eSEL event size is multiples of IPMI > buffer size. > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > -- > Stewart, > Accidently I happened to log event with PEL log size = 0x2e6. Then > I observed this bug. Well, that was unlucky to find (or lucky, depending on your point of view :) merged as of 3066b4a
diff --git a/hw/ipmi/ipmi-sel.c b/hw/ipmi/ipmi-sel.c index 343ca02..d711a1a 100644 --- a/hw/ipmi/ipmi-sel.c +++ b/hw/ipmi/ipmi-sel.c @@ -312,7 +312,7 @@ static void ipmi_elog_poll(struct ipmi_msg *msg) return; } - if ((esel_size - esel_index) < (IPMI_MAX_REQ_SIZE - ESEL_HDR_SIZE)) { + if ((esel_size - esel_index) <= (IPMI_MAX_REQ_SIZE - ESEL_HDR_SIZE)) { /* Last data to send */ msg->data[6] = 1; req_size = esel_size - esel_index + ESEL_HDR_SIZE;
eSEL logging fails, if eSEL event size is multiples of IPMI buffer size. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> -- Stewart, Accidently I happened to log event with PEL log size = 0x2e6. Then I observed this bug. -Vasant --- hw/ipmi/ipmi-sel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)