diff mbox

[OpenWrt-Devel,04/13] ramips: sort boards alphabetically and optimize base-files/etc/{diag.sh, board.d/*} scripts

Message ID 632289031.913.1437989861829.JavaMail.open-xchange@cc-app3.netcologne.de
State Superseded
Headers show

Commit Message

Michael Bastian July 27, 2015, 9:37 a.m. UTC 
> diff --git a/target/linux/ramips/base-files/etc/board.d/02_network
> b/target/linux/ramips/base-files/etc/board.d/02_network
> index 334e889..a781f46 100755
[...]
> + re6500)
> + ucidef_set_interface_lan "eth0.1"
> + ucidef_add_switch "switch0" "1" "1"
> + ucidef_add_switch_vlan "switch0" "1" "1 2 3 4 6t"
> + ;;

The four physical lan ports on the Linksys RE6500 are connected to switchport 0-3 so it must read:

+ ucidef_add_switch_vlan "switch0" "1" "0 1 2 3 6t"

Personally I build my images with a WAN port on physical port 1 but since this box has no dedicated WAN port labeled on
the backside it might be confusing use something like this as a default?

https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Comments

Piotr Dymacz July 27, 2015, 10:15 a.m. UTC | #1 
2015-07-27 11:37 GMT+02:00 Michael Bastian <mbastian@netcologne.de>:
>> diff --git a/target/linux/ramips/base-files/etc/board.d/02_network
>> b/target/linux/ramips/base-files/etc/board.d/02_network
>> index 334e889..a781f46 100755
> [...]
>> + re6500)
>> + ucidef_set_interface_lan "eth0.1"
>> + ucidef_add_switch "switch0" "1" "1"
>> + ucidef_add_switch_vlan "switch0" "1" "1 2 3 4 6t"
>> + ;;
>
> The four physical lan ports on the Linksys RE6500 are connected to switchport 0-3 so it must read:
>
> + ucidef_add_switch_vlan "switch0" "1" "0 1 2 3 6t"

So it's a mistake, but that's not the aspect of my patch.
I just removed wrong indentation and reordered boards, without
touching configuration.

Cheers,
Piotr
Michael Bastian July 27, 2015, 11:17 a.m. UTC | #2 
> >> diff --git a/target/linux/ramips/base-files/etc/board.d/02_network
> >> b/target/linux/ramips/base-files/etc/board.d/02_network
> >> index 334e889..a781f46 100755
> > [...]
> >> + re6500)
> >> + ucidef_set_interface_lan "eth0.1"
> >> + ucidef_add_switch "switch0" "1" "1"
> >> + ucidef_add_switch_vlan "switch0" "1" "1 2 3 4 6t"
> >> + ;;
> >
> > The four physical lan ports on the Linksys RE6500 are connected to switchport 0-3 so it must read:
> >
> > + ucidef_add_switch_vlan "switch0" "1" "0 1 2 3 6t"
> 
> So it's a mistake, but that's not the aspect of my patch.
> I just removed wrong indentation and reordered boards, without
> touching configuration.

Apologies, I misinterpreted your patch. I'll come back to this issue to a separate thread.


Michael
diff mbox

Patch

--- a/target/linux/ramips/base-files/etc/board.d/02_network
+++ b/target/linux/ramips/base-files/etc/board.d/02_network
@@ -104,7 +104,13 @@  ramips_setup_interfaces()
 		ucidef_add_switch_vlan "switch0" "2" "0 9t"
 		;;
 
-        re6500 | \
+        re6500)
+		ucidef_set_interfaces_lan_wan "eth0.1" "eth0.2"
+		ucidef_add_switch "switch0" "1" "1"
+		ucidef_add_switch_vlan "switch0" "1" "1 2 3 6t"
+		ucidef_add_switch_vlan "switch0" "2" "0 6t"
+		;;
+
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org