| Message ID | 1426878721-2618-2-git-send-email-alexanders83@web.de |
|---|---|
| State | New |
| Headers | show |
On 20:12 Fri 20 Mar , Alexander Stein wrote: > This fixes the sparse warning: > drivers/pinctrl/pinctrl-at91.c:1556:6: warning: symbol > 'at91_pinctrl_gpio_suspend' was not declared. Should it be static? > drivers/pinctrl/pinctrl-at91.c:1580:6: warning: symbol > 'at91_pinctrl_gpio_resume' was not declared. Should it be static? > > Signed-off-by: Alexander Stein <alexanders83@web.de> > --- > drivers/pinctrl/pinctrl-at91.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c > index a882523..02f6477 100644 > --- a/drivers/pinctrl/pinctrl-at91.c > +++ b/drivers/pinctrl/pinctrl-at91.c > @@ -25,6 +25,8 @@ > /* Since we request GPIOs from ourself */ > #include <linux/pinctrl/consumer.h> > > +#include <mach/hardware.h> NACK this will break multi arch support Best Regards, J. > + > #include "pinctrl-at91.h" > #include "core.h" > > -- > 2.3.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 02 April 2015, 10:19:41 wrote Jean-Christophe PLAGNIOL-VILLARD: > On 20:12 Fri 20 Mar , Alexander Stein wrote: > > This fixes the sparse warning: > > drivers/pinctrl/pinctrl-at91.c:1556:6: warning: symbol > > 'at91_pinctrl_gpio_suspend' was not declared. Should it be static? > > drivers/pinctrl/pinctrl-at91.c:1580:6: warning: symbol > > 'at91_pinctrl_gpio_resume' was not declared. Should it be static? > > > > Signed-off-by: Alexander Stein <alexanders83@web.de> > > --- > > drivers/pinctrl/pinctrl-at91.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c > > index a882523..02f6477 100644 > > --- a/drivers/pinctrl/pinctrl-at91.c > > +++ b/drivers/pinctrl/pinctrl-at91.c > > @@ -25,6 +25,8 @@ > > /* Since we request GPIOs from ourself */ > > #include <linux/pinctrl/consumer.h> > > > > +#include <mach/hardware.h> > NACK this will break multi arch support Mh, i see. So I guess this sparse warning will stay there then. Best regards, Alexander -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c index a882523..02f6477 100644 --- a/drivers/pinctrl/pinctrl-at91.c +++ b/drivers/pinctrl/pinctrl-at91.c @@ -25,6 +25,8 @@ /* Since we request GPIOs from ourself */ #include <linux/pinctrl/consumer.h> +#include <mach/hardware.h> + #include "pinctrl-at91.h" #include "core.h"
This fixes the sparse warning: drivers/pinctrl/pinctrl-at91.c:1556:6: warning: symbol 'at91_pinctrl_gpio_suspend' was not declared. Should it be static? drivers/pinctrl/pinctrl-at91.c:1580:6: warning: symbol 'at91_pinctrl_gpio_resume' was not declared. Should it be static? Signed-off-by: Alexander Stein <alexanders83@web.de> --- drivers/pinctrl/pinctrl-at91.c | 2 ++ 1 file changed, 2 insertions(+)