Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/985246/?format=api
{ "id": 985246, "url": "http://patchwork.ozlabs.org/api/patches/985246/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-6-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-6-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:26:29", "name": "[v4,05/38] vfio: Use warn_report() & friends to report warnings", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "018e21da7145ef65d7628a84c870fd0ee40d7446", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20181017082702.5581-6-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/985246/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/985246/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42ZmCp0JKfz9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:52:54 +1100 (AEDT)", "from localhost ([::1]:34628 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChZT-00048o-Hb\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:52:51 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51468)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChB4-0000Kt-TB\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:39 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChB2-0001zI-MY\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:38 -0400", "from mx1.redhat.com ([209.132.183.28]:41770)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChB2-00018G-6u\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:36 -0400", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1194C120EE\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:11 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 227FC19E25;\n\tWed, 17 Oct 2018 08:27:05 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 279841132D9B; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:26:29 +0200", "Message-Id": "<20181017082702.5581-6-armbru@redhat.com>", "In-Reply-To": "<20181017082702.5581-1-armbru@redhat.com>", "References": "<20181017082702.5581-1-armbru@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 17 Oct 2018 08:27:11 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 05/38] vfio: Use warn_report() & friends to\n\treport warnings", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Alex Williamson <alex.williamson@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The vfio code reports warnings like\n\n error_report(WARN_PREFIX \"Could not frobnicate\", DEV-NAME);\n\nwhere WARN_PREFIX is defined so the message comes out as\n\n vfio warning: DEV-NAME: Could not frobnicate\n\nThis usage predates the introduction of warn_report() & friends in\ncommit 97f40301f1d. It's time to convert to that interface. Since\nthese functions already prefix the message with \"warning: \", replace\nWARN_PREFIX by VFIO_MSG_PREFIX, so the messages come out like\n\n warning: vfio DEV-NAME: Could not frobnicate\n\nThe next commit will replace ERR_PREFIX.\n\nCc: Alex Williamson <alex.williamson@redhat.com>\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nAcked-by: Alex Williamson <alex.williamson@redhat.com>\nReviewed-by: Eric Blake <eblake@redhat.com>\n---\n hw/vfio/pci.c | 14 +++++++-------\n hw/vfio/platform.c | 4 ++--\n include/hw/vfio/vfio-common.h | 2 +-\n 3 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c\nindex 4404c28360..0c3d245932 100644\n--- a/hw/vfio/pci.c\n+++ b/hw/vfio/pci.c\n@@ -252,7 +252,7 @@ static void vfio_intx_update(PCIDevice *pdev)\n \n vfio_intx_enable_kvm(vdev, &err);\n if (err) {\n- error_reportf_err(err, WARN_PREFIX, vdev->vbasedev.name);\n+ warn_reportf_err(err, VFIO_MSG_PREFIX, vdev->vbasedev.name);\n }\n \n /* Re-enable the interrupt in cased we missed an EOI */\n@@ -317,7 +317,7 @@ static int vfio_intx_enable(VFIOPCIDevice *vdev, Error **errp)\n \n vfio_intx_enable_kvm(vdev, &err);\n if (err) {\n- error_reportf_err(err, WARN_PREFIX, vdev->vbasedev.name);\n+ warn_reportf_err(err, VFIO_MSG_PREFIX, vdev->vbasedev.name);\n }\n \n vdev->interrupt = VFIO_INT_INTx;\n@@ -1557,7 +1557,7 @@ static int vfio_msix_setup(VFIOPCIDevice *vdev, int pos, Error **errp)\n &err);\n if (ret < 0) {\n if (ret == -ENOTSUP) {\n- error_report_err(err);\n+ warn_report_err(err);\n return 0;\n }\n \n@@ -2590,9 +2590,9 @@ static void vfio_populate_device(VFIOPCIDevice *vdev, Error **errp)\n } else if (irq_info.count == 1) {\n vdev->pci_aer = true;\n } else {\n- error_report(WARN_PREFIX\n- \"Could not enable error recovery for the device\",\n- vbasedev->name);\n+ warn_report(VFIO_MSG_PREFIX\n+ \"Could not enable error recovery for the device\",\n+ vbasedev->name);\n }\n }\n \n@@ -2717,7 +2717,7 @@ static void vfio_req_notifier_handler(void *opaque)\n \n qdev_unplug(&vdev->pdev.qdev, &err);\n if (err) {\n- error_reportf_err(err, WARN_PREFIX, vdev->vbasedev.name);\n+ warn_reportf_err(err, VFIO_MSG_PREFIX, vdev->vbasedev.name);\n }\n }\n \ndiff --git a/hw/vfio/platform.c b/hw/vfio/platform.c\nindex 64c1af653d..baf236ae79 100644\n--- a/hw/vfio/platform.c\n+++ b/hw/vfio/platform.c\n@@ -679,8 +679,8 @@ static void vfio_platform_realize(DeviceState *dev, Error **errp)\n \n for (i = 0; i < vbasedev->num_regions; i++) {\n if (vfio_region_mmap(vdev->regions[i])) {\n- error_report(\"%s mmap unsupported. Performance may be slow\",\n- memory_region_name(vdev->regions[i]->mem));\n+ warn_report(\"%s mmap unsupported, performance may be slow\",\n+ memory_region_name(vdev->regions[i]->mem));\n }\n sysbus_init_mmio(sbdev, vdev->regions[i]->mem);\n }\ndiff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h\nindex e46a28910a..1d7630345b 100644\n--- a/include/hw/vfio/vfio-common.h\n+++ b/include/hw/vfio/vfio-common.h\n@@ -32,7 +32,7 @@\n #endif\n \n #define ERR_PREFIX \"vfio error: %s: \"\n-#define WARN_PREFIX \"vfio warning: %s: \"\n+#define VFIO_MSG_PREFIX \"vfio %s: \"\n \n enum {\n VFIO_DEVICE_TYPE_PCI = 0,\n", "prefixes": [ "v4", "05/38" ] }