Comment List
List comments
GET /api/patches/964079/comments/?format=api
[ { "id": 1982452, "web_url": "http://patchwork.ozlabs.org/comment/1982452/", "msgid": "<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>", "list_archive_url": null, "date": "2018-08-30T19:11:18", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 4515, "url": "http://patchwork.ozlabs.org/api/people/4515/?format=api", "name": "Jens Axboe", "email": "axboe@kernel.dk" }, "content": "On 8/30/18 12:53 PM, Logan Gunthorpe wrote:\n> QUEUE_FLAG_PCI_P2P is introduced meaning a driver's request queue\n> supports targeting P2P memory.\n> \n> When a request is submitted we check if PCI P2PDMA memory is assigned\n> to the first page in the bio. If it is, we ensure the queue it's\n> submitted to supports it, and enforce REQ_NOMERGE.\n\nI think this belongs in the caller - both the validity check, and\npassing in NOMERGE for this type of request. I don't want to impose\nthis overhead on everything, for a pretty niche case.", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.dk", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel-dk.20150623.gappssmtp.com\n\theader.i=@kernel-dk.20150623.gappssmtp.com\n\theader.b=\"V+Sm+tjU\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 421XCc2Yh5z9s0n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 31 Aug 2018 05:11:24 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727173AbeH3XPB (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tThu, 30 Aug 2018 19:15:01 -0400", "from mail-it0-f54.google.com ([209.85.214.54]:37272 \"EHLO\n\tmail-it0-f54.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1725836AbeH3XPA (ORCPT\n\t<rfc822; linux-pci@vger.kernel.org>); Thu, 30 Aug 2018 19:15:00 -0400", "by mail-it0-f54.google.com with SMTP id h20-v6so4163117itf.2\n\tfor <linux-pci@vger.kernel.org>; Thu, 30 Aug 2018 12:11:22 -0700 (PDT)", "from [192.168.1.56] ([216.160.245.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tw20-v6sm3281113ioa.82.2018.08.30.12.11.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 30 Aug 2018 12:11:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=kernel-dk.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=g7v8KVcLqnDf+9fgon1CPhLtcLM3PxMlyVE5fEOaYy8=;\n\tb=V+Sm+tjU4jJvxkGil6YXxVdlrRSp9QEl9ThCk6xJOptUlf7rcKWJ7QywM9/+d6lgg9\n\tCv2bMEuuW6zPwi6zn1dRmYpPY/sXubUICzIBxrBKZNy2uuJsAdBSqhYUNdgNy6MTdCeu\n\tgRnHOW+Jl2J0ClRNlgGwt5L/HlQoSXMvnFGOa7eeTAWMKuvtPO8XPr0HpxMlw4CK7lvu\n\t7z7qXzGLMtBUYqMJsy6wSElWea9uf1LnMHM3GhlusIPLLXdVEL/UzY2JYrMltm7Sc0X1\n\ttZETb3g76uK7wTQj+fcjWY1NqVNJ1qBu+9hpsS3TCFFMUOybny97iVbmMbI2NKz5KnzV\n\tpr1g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=g7v8KVcLqnDf+9fgon1CPhLtcLM3PxMlyVE5fEOaYy8=;\n\tb=FzYSJt1/+NSQ+rHfrsdmQBNbRRfJl50BmNsLP8KfTGjSuz3YRe68uCQSFbuEVsMODa\n\tJYoEYQeHsaocMa2Z3B6EcyiK2fOfbNyt5LlD/+KaaKecWz9GUhyeFB5iI19frT9yqro3\n\tM/zcKkhNgOS3g3cnn3NGWd0uVi6Y4FLC4X31G2HBxm3ZaAkaIKKNueOQe46Cu1Uz3gnO\n\tzqYbOBDmbGpFLuVS1qNBzmzew9xwmGJt3sDstUtPR1Bywjf762pmhZiQZcTMv+zQzem+\n\tgVZs6lGuynUt0+1eKqGEqIOGF/d6XXuaGHfWVXp9hwgunSWNvsgUdwEVOYMf7bGWSX45\n\tvhkQ==", "X-Gm-Message-State": "APzg51AJbInx152iGoQ7MQkfkTxa3jyTZTn5WR7A03+HKylXlqSU6oPX\n\tnt+vLQL13rRcagSbRNdEx3SzQA==", "X-Google-Smtp-Source": "ANB0Vda0Exfhiz84XQu61c86kGqnTxHSzBX9wkNI8HaU9Ht+W9qzUsiL+NZEHukB1XbFEi31AjAscA==", "X-Received": "by 2002:a24:9d84:: with SMTP id\n\tf126-v6mr3258556itd.130.1535656281718; \n\tThu, 30 Aug 2018 12:11:21 -0700 (PDT)", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "To": "Logan Gunthorpe <logang@deltatee.com>,\n\tlinux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org", "Cc": "Stephen Bates <sbates@raithlin.com>, Christoph Hellwig <hch@lst.de>,\n\tKeith Busch <keith.busch@intel.com>, Sagi Grimberg <sagi@grimberg.me>,\n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>,\n\tDan Williams <dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xp?=\n\t=?utf-8?q?sse?= <jglisse@redhat.com>,\n\tBenjamin Herrenschmidt <benh@kernel.crashing.org>, Alex Williamson\n\t<alex.williamson@redhat.com>, =?utf-8?q?Christian_K=C3=B6nig?=\n\t<christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>", "From": "Jens Axboe <axboe@kernel.dk>", "Message-ID": "<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>", "Date": "Thu, 30 Aug 2018 13:11:18 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.0", "MIME-Version": "1.0", "In-Reply-To": "<20180830185352.3369-8-logang@deltatee.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1982455, "web_url": "http://patchwork.ozlabs.org/comment/1982455/", "msgid": "<7c5b9d2c-d94e-582c-f1d7-0827dbb7df7c@deltatee.com>", "list_archive_url": null, "date": "2018-08-30T19:17:40", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 70191, "url": "http://patchwork.ozlabs.org/api/people/70191/?format=api", "name": "Logan Gunthorpe", "email": "logang@deltatee.com" }, "content": "On 30/08/18 01:11 PM, Jens Axboe wrote:\n> On 8/30/18 12:53 PM, Logan Gunthorpe wrote:\n>> QUEUE_FLAG_PCI_P2P is introduced meaning a driver's request queue\n>> supports targeting P2P memory.\n>>\n>> When a request is submitted we check if PCI P2PDMA memory is assigned\n>> to the first page in the bio. If it is, we ensure the queue it's\n>> submitted to supports it, and enforce REQ_NOMERGE.\n> \n> I think this belongs in the caller - both the validity check, and\n> passing in NOMERGE for this type of request. I don't want to impose\n> this overhead on everything, for a pretty niche case.\n\nWell, the point was to prevent driver writers from doing the wrong\nthing. The WARN_ON would be a bit pointless in the driver if we rely on\nthe driver to either do the right thing or add the WARN_ON themselves.\n\nIf I'm going to change anything I'd drop the warning entirely and move\nthe NO_MERGE back into the caller...\n\nNote: the check will be compiled out if the kernel does not support PCI P2P.\n\nLogan", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=deltatee.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 421XMF0Fgrz9s1x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 31 Aug 2018 05:18:01 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727203AbeH3XVe (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tThu, 30 Aug 2018 19:21:34 -0400", "from ale.deltatee.com ([207.54.116.67]:40596 \"EHLO\n\tale.deltatee.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1727098AbeH3XVd (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tThu, 30 Aug 2018 19:21:33 -0400", "from guinness.priv.deltatee.com ([172.16.1.162])\n\tby ale.deltatee.com with esmtp (Exim 4.89)\n\t(envelope-from <logang@deltatee.com>)\n\tid 1fvSRq-0006wf-LJ; Thu, 30 Aug 2018 13:17:43 -0600" ], "To": "Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org,\n\tlinux-pci@vger.kernel.org, linux-nvme@lists.infradead.org,\n\tlinux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org,\n\tlinux-block@vger.kernel.org", "Cc": "Stephen Bates <sbates@raithlin.com>, Christoph Hellwig <hch@lst.de>,\n\tKeith Busch <keith.busch@intel.com>, Sagi Grimberg <sagi@grimberg.me>,\n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>,\n\tDan Williams <dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xp?=\n\t=?utf-8?q?sse?= <jglisse@redhat.com>,\n\tBenjamin Herrenschmidt <benh@kernel.crashing.org>, Alex Williamson\n\t<alex.williamson@redhat.com>, =?utf-8?q?Christian_K=C3=B6nig?=\n\t<christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>", "From": "Logan Gunthorpe <logang@deltatee.com>", "Message-ID": "<7c5b9d2c-d94e-582c-f1d7-0827dbb7df7c@deltatee.com>", "Date": "Thu, 30 Aug 2018 13:17:40 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-SA-Exim-Connect-IP": "172.16.1.162", "X-SA-Exim-Rcpt-To": "christian.koenig@amd.com, alex.williamson@redhat.com,\n\tbenh@kernel.crashing.org, jglisse@redhat.com,\n\tdan.j.williams@intel.com, maxg@mellanox.com, jgg@mellanox.com,\n\tbhelgaas@google.com, sagi@grimberg.me, keith.busch@intel.com,\n\thch@lst.de, sbates@raithlin.com, linux-block@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, axboe@kernel.dk", "X-SA-Exim-Mail-From": "logang@deltatee.com", "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00,\n\tGREYLIST_ISWHITE autolearn=ham autolearn_force=no version=3.4.1", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "X-SA-Exim-Version": "4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000)", "X-SA-Exim-Scanned": "Yes (on ale.deltatee.com)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1982457, "web_url": "http://patchwork.ozlabs.org/comment/1982457/", "msgid": "<56e1a633-bad3-cac7-13b4-747f0001f5c8@kernel.dk>", "list_archive_url": null, "date": "2018-08-30T19:19:25", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 4515, "url": "http://patchwork.ozlabs.org/api/people/4515/?format=api", "name": "Jens Axboe", "email": "axboe@kernel.dk" }, "content": "On 8/30/18 1:17 PM, Logan Gunthorpe wrote:\n> \n> \n> On 30/08/18 01:11 PM, Jens Axboe wrote:\n>> On 8/30/18 12:53 PM, Logan Gunthorpe wrote:\n>>> QUEUE_FLAG_PCI_P2P is introduced meaning a driver's request queue\n>>> supports targeting P2P memory.\n>>>\n>>> When a request is submitted we check if PCI P2PDMA memory is assigned\n>>> to the first page in the bio. If it is, we ensure the queue it's\n>>> submitted to supports it, and enforce REQ_NOMERGE.\n>>\n>> I think this belongs in the caller - both the validity check, and\n>> passing in NOMERGE for this type of request. I don't want to impose\n>> this overhead on everything, for a pretty niche case.\n> \n> Well, the point was to prevent driver writers from doing the wrong\n> thing. The WARN_ON would be a bit pointless in the driver if we rely on\n> the driver to either do the right thing or add the WARN_ON themselves.\n> \n> If I'm going to change anything I'd drop the warning entirely and move\n> the NO_MERGE back into the caller...\n\nOf course, if you move it into the caller, the warning makes no sense.\n\n> Note: the check will be compiled out if the kernel does not support PCI P2P.\n\nSure, but then distros tend to enable everything...", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.dk", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel-dk.20150623.gappssmtp.com\n\theader.i=@kernel-dk.20150623.gappssmtp.com\n\theader.b=\"MaO7F6Iw\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 421XNz5hBLz9s0n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 31 Aug 2018 05:19:31 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727229AbeH3XXJ (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tThu, 30 Aug 2018 19:23:09 -0400", "from mail-io0-f195.google.com ([209.85.223.195]:33197 \"EHLO\n\tmail-io0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1727232AbeH3XXJ (ORCPT\n\t<rfc822; linux-pci@vger.kernel.org>); Thu, 30 Aug 2018 19:23:09 -0400", "by mail-io0-f195.google.com with SMTP id r196-v6so8519991iod.0\n\tfor <linux-pci@vger.kernel.org>; Thu, 30 Aug 2018 12:19:29 -0700 (PDT)", "from [192.168.1.56] ([216.160.245.98])\n\tby smtp.gmail.com with ESMTPSA id\n\ti20-v6sm1345140iti.15.2018.08.30.12.19.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 30 Aug 2018 12:19:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=kernel-dk.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=mroj/0Oz64/AelOC6y8tjEVjwRywlncLvvzQ9lzBmq8=;\n\tb=MaO7F6Iwfon4A9vMqZ6iGa6VQrUonYavelIy5l3wWW/GhTkrcFZoiIoy0YhLPItOvA\n\t5vCNKwnl++rm19iJ+64S+u9MHP8E6Q9iuir7bLcgPsxa96fwMVTCr055gs/n7rPmFAXS\n\tOfIwMR4LFPO3yccTESsMHXwlf31bbV5vszNZsPx0X66U25XpoiIMhyr2h97c2meyF6ju\n\tuARhuUQWTOo4SjB1TeIn5ZwkTNUcsL4zj2SGndR6jUPn4SqKwkKh1lkxiWpDX7NvPDwZ\n\twJPTqUEfyXZIVnPp4MCIL9a481+B4YBtQFEqv5sblzin8bfy17oZ+BJeORXIch0cUjoN\n\toazw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=mroj/0Oz64/AelOC6y8tjEVjwRywlncLvvzQ9lzBmq8=;\n\tb=QRG9KcqnSuX0TNv1bfMqWAnCutZPvz9n/Io76mbzwUM1fmNu3gV4QLgJSJUC7ir+KN\n\tc8b17C0QDoSJmzbaMKhS6R9I4Bv38TSrmZ/WPtw77/kYxsIyq1eR/xzJ0NMVTa7+c9P+\n\tpAMLBMhuiUYu0uGQGlLVs/4AqizZiKwhrNXHDeFqdNx4OJe1ZQp4E7zaAv8xgbY5w4nS\n\txHVlwSH+6iM4kAzLEqcyb+P30wo8p7wpjX0q1lhvoG8dI/AWRftuHKx8YC9gLV4fEXlM\n\t3lxRiQA5R+wXKm8Ivmjtu2L5QvroPmg8tdKJwAhwyEfYV7wvjipPnlR8z0EQ4MJw1zcc\n\tJCLg==", "X-Gm-Message-State": "APzg51Cv7JQfvLnetZGZJ/qUCmxpP/ZZKz/Z0WiWO9aeR6MYceZUzUNF\n\txgy6GOiFggAHHVIm02m+BgUyHg==", "X-Google-Smtp-Source": "ANB0VdaW5AlaaaNjQ4bSLZjuX9NnuxMaLw7sfiM8lhfROJzuBkx6Wg0nwu6RuDBAWFzMLD+k7Py8YA==", "X-Received": "by 2002:a5e:9615:: with SMTP id\n\ta21-v6mr9982289ioq.53.1535656768604; \n\tThu, 30 Aug 2018 12:19:28 -0700 (PDT)", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "To": "Logan Gunthorpe <logang@deltatee.com>,\n\tlinux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org", "Cc": "Stephen Bates <sbates@raithlin.com>, Christoph Hellwig <hch@lst.de>,\n\tKeith Busch <keith.busch@intel.com>, Sagi Grimberg <sagi@grimberg.me>,\n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>,\n\tDan Williams <dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xp?=\n\t=?utf-8?q?sse?= <jglisse@redhat.com>,\n\tBenjamin Herrenschmidt <benh@kernel.crashing.org>, Alex Williamson\n\t<alex.williamson@redhat.com>, =?utf-8?q?Christian_K=C3=B6nig?=\n\t<christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<7c5b9d2c-d94e-582c-f1d7-0827dbb7df7c@deltatee.com>", "From": "Jens Axboe <axboe@kernel.dk>", "Message-ID": "<56e1a633-bad3-cac7-13b4-747f0001f5c8@kernel.dk>", "Date": "Thu, 30 Aug 2018 13:19:25 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.0", "MIME-Version": "1.0", "In-Reply-To": "<7c5b9d2c-d94e-582c-f1d7-0827dbb7df7c@deltatee.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1983362, "web_url": "http://patchwork.ozlabs.org/comment/1983362/", "msgid": "<20180901082812.GB670@lst.de>", "list_archive_url": null, "date": "2018-09-01T08:28:12", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "content": "On Thu, Aug 30, 2018 at 01:11:18PM -0600, Jens Axboe wrote:\n> I think this belongs in the caller - both the validity check, and\n> passing in NOMERGE for this type of request. I don't want to impose\n> this overhead on everything, for a pretty niche case.\n\nIt is just a single branch, which will be predicted as not taken\nfor non-P2P users. The benefit is that we get proper error checking\nby doing it in the block code.", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=lst.de" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 422Tn939Ytz9s4V\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 1 Sep 2018 18:25:17 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727247AbeIAMgW (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tSat, 1 Sep 2018 08:36:22 -0400", "from verein.lst.de ([213.95.11.211]:56610 \"EHLO newverein.lst.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1725973AbeIAMgW (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tSat, 1 Sep 2018 08:36:22 -0400", "by newverein.lst.de (Postfix, from userid 2407)\n\tid 20D1268D00; Sat, 1 Sep 2018 10:28:12 +0200 (CEST)" ], "Date": "Sat, 1 Sep 2018 10:28:12 +0200", "From": "Christoph Hellwig <hch@lst.de>", "To": "Jens Axboe <axboe@kernel.dk>", "Cc": "Logan Gunthorpe <logang@deltatee.com>, linux-kernel@vger.kernel.org,\n\tlinux-pci@vger.kernel.org, linux-nvme@lists.infradead.org,\n\tlinux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org,\n\tlinux-block@vger.kernel.org, Stephen Bates <sbates@raithlin.com>,\n\tChristoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, Bjorn Helgaas <bhelgaas@google.com>,\n\tJason Gunthorpe <jgg@mellanox.com>, Max Gurtovoy <maxg@mellanox.com>,\n\tDan Williams <dan.j.williams@intel.com>, =?iso-8859-1?q?J=E9r=F4me?=\n\tGlisse <jglisse@redhat.com>, Benjamin Herrenschmidt\n\t<benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, Christian\n\t=?iso-8859-1?q?K=F6nig?= <christian.koenig@amd.com>", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "Message-ID": "<20180901082812.GB670@lst.de>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>", "User-Agent": "Mutt/1.5.17 (2007-11-01)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1984210, "web_url": "http://patchwork.ozlabs.org/comment/1984210/", "msgid": "<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>", "list_archive_url": null, "date": "2018-09-03T22:26:27", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 70191, "url": "http://patchwork.ozlabs.org/api/people/70191/?format=api", "name": "Logan Gunthorpe", "email": "logang@deltatee.com" }, "content": "On 01/09/18 02:28 AM, Christoph Hellwig wrote:\n> On Thu, Aug 30, 2018 at 01:11:18PM -0600, Jens Axboe wrote:\n>> I think this belongs in the caller - both the validity check, and\n>> passing in NOMERGE for this type of request. I don't want to impose\n>> this overhead on everything, for a pretty niche case.\n> \n> It is just a single branch, which will be predicted as not taken\n> for non-P2P users. The benefit is that we get proper error checking\n> by doing it in the block code.\n\nI personally agree with Christoph. But if there's consensus in the other\ndirection or this is a real blocker moving this forward, I can remove it\nfor the next version.\n\nLogan", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=deltatee.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 4244Mg72Nzz9s1x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 4 Sep 2018 08:27:11 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1726048AbeIDCtK (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tMon, 3 Sep 2018 22:49:10 -0400", "from ale.deltatee.com ([207.54.116.67]:38918 \"EHLO\n\tale.deltatee.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1725955AbeIDCtK (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tMon, 3 Sep 2018 22:49:10 -0400", "from s0106602ad0811846.cg.shawcable.net ([68.147.191.165]\n\thelo=[192.168.0.18]) by ale.deltatee.com with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89)\n\t(envelope-from <logang@deltatee.com>)\n\tid 1fwxIo-0006QC-HP; Mon, 03 Sep 2018 16:26:35 -0600" ], "To": "Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>", "From": "Logan Gunthorpe <logang@deltatee.com>", "Message-ID": "<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>", "Date": "Mon, 3 Sep 2018 16:26:27 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.8.0", "MIME-Version": "1.0", "In-Reply-To": "<20180901082812.GB670@lst.de>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-SA-Exim-Connect-IP": "68.147.191.165", "X-SA-Exim-Rcpt-To": "christian.koenig@amd.com, alex.williamson@redhat.com,\n\tbenh@kernel.crashing.org, jglisse@redhat.com,\n\tdan.j.williams@intel.com, maxg@mellanox.com, jgg@mellanox.com,\n\tbhelgaas@google.com, sagi@grimberg.me, keith.busch@intel.com,\n\tsbates@raithlin.com, linux-block@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, axboe@kernel.dk, hch@lst.de", "X-SA-Exim-Mail-From": "logang@deltatee.com", "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-6.9 required=5.0 tests=ALL_TRUSTED,BAYES_00\n\tautolearn=ham autolearn_force=no version=3.4.1", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "X-SA-Exim-Version": "4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000)", "X-SA-Exim-Scanned": "Yes (on ale.deltatee.com)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985556, "web_url": "http://patchwork.ozlabs.org/comment/1985556/", "msgid": "<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>", "list_archive_url": null, "date": "2018-09-05T19:26:51", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 4515, "url": "http://patchwork.ozlabs.org/api/people/4515/?format=api", "name": "Jens Axboe", "email": "axboe@kernel.dk" }, "content": "On 9/3/18 4:26 PM, Logan Gunthorpe wrote:\n> \n> \n> On 01/09/18 02:28 AM, Christoph Hellwig wrote:\n>> On Thu, Aug 30, 2018 at 01:11:18PM -0600, Jens Axboe wrote:\n>>> I think this belongs in the caller - both the validity check, and\n>>> passing in NOMERGE for this type of request. I don't want to impose\n>>> this overhead on everything, for a pretty niche case.\n>>\n>> It is just a single branch, which will be predicted as not taken\n>> for non-P2P users. The benefit is that we get proper error checking\n>> by doing it in the block code.\n> \n> I personally agree with Christoph. But if there's consensus in the other\n> direction or this is a real blocker moving this forward, I can remove it\n> for the next version.\n\nIt's a simple branch because the check isn't exhaustive. It just checks\nthe first page. At that point you may as well just require the caller to\nflag the bio/rq as being P2P, and then do a check for P2P compatibility\nwith the queue.", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.dk", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel-dk.20150623.gappssmtp.com\n\theader.i=@kernel-dk.20150623.gappssmtp.com\n\theader.b=\"A9rhysN9\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425DGn5gSxz9sB5\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 05:26:57 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727827AbeIEX6a (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 19:58:30 -0400", "from mail-it0-f67.google.com ([209.85.214.67]:39106 \"EHLO\n\tmail-it0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1727818AbeIEX6a (ORCPT\n\t<rfc822;linux-pci@vger.kernel.org>); Wed, 5 Sep 2018 19:58:30 -0400", "by mail-it0-f67.google.com with SMTP id h1-v6so10978625itj.4\n\tfor <linux-pci@vger.kernel.org>; Wed, 05 Sep 2018 12:26:55 -0700 (PDT)", "from [192.168.1.56] ([216.160.245.98])\n\tby smtp.gmail.com with ESMTPSA id\n\t84-v6sm1297805ita.35.2018.09.05.12.26.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 05 Sep 2018 12:26:53 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=kernel-dk.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=hQCQhTXw4V+d8atsoQwkUG9QlqO6wLo/3cSY1ircY4U=;\n\tb=A9rhysN9fbBL1LBne6JNLTqJg1JYq7llU1Vpo0xV3DW5lMF0v4qfWsGnJ0qxHMQ+Z4\n\tMdwiuGwAaD6t4kjGjOz4akpWfI4yL3KNEtltbxHgu9bPnUrb7XV/yb17kRJZ6F275bZn\n\t0bCHNCQ8T+mCvB5/gUdd8gS8LPuj/Z9JUU8+dXBV8y9hbWLqnLWrc+7P0q6pgrrAySB3\n\tshAsy6TPkQw9qIrfXocRiuQyVTYapZmDaLKHFFT1HTNKvCLDSMvTpZFsYGv2z0WRUI6I\n\tbFIJtdOINhsVpjvvP8kMmqc0WqBlUYsNhPZ3KVr/dbgk3cc7d7vWM+oBERd9+MrgHSQb\n\t7G9Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=hQCQhTXw4V+d8atsoQwkUG9QlqO6wLo/3cSY1ircY4U=;\n\tb=qN9fTWaCH90hUj5QsmwfiAzVI2p3D/UbdipPkmFiGpWUG+z0L4l9PPfvssFufYHiwT\n\tbGsfD63kRhhcSCSkhAPjuFGNRW9/nSR9NfkzC2KAzqLSgqSUW1GiSSccTn0JfBW890hu\n\tLH8nwLFH7lwujniVcGuHiUSsGSjApm0R7539qngrrWILBUR3hmAWydVKo3LszISPTCqo\n\taJWSbB8LqDSjoSX/6SS8JcJYoYaftDsoK7N2COcNgUCGZzpNbOWuAbU84ucDJ6xJ8zsp\n\tSs2eMy6Gbg0XOSda+NL014ZHfLRvsFiPAp3DFk1RPi72N9E5N6dUa9LAjgRsCYgC1nGV\n\t40Mg==", "X-Gm-Message-State": "APzg51DJISagPMXjlbDN82zbKRhmFq67xTtYSvUk6peZ47bnBDm41JVe\n\t9jXjZOL4C6p3eHoKRM3KjGt0zQ==", "X-Google-Smtp-Source": "ANB0VdapXKOqjXouem4uxXPvFcDadOQ2OG/hA0PXyR8EzKrdg1wh6lLsH8AcWo7c7VRpNdLpPkGQkg==", "X-Received": "by 2002:a24:2552:: with SMTP id\n\tg79-v6mr1625767itg.84.1536175615162; \n\tWed, 05 Sep 2018 12:26:55 -0700 (PDT)", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "To": "Logan Gunthorpe <logang@deltatee.com>, Christoph Hellwig <hch@lst.de>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>", "From": "Jens Axboe <axboe@kernel.dk>", "Message-ID": "<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>", "Date": "Wed, 5 Sep 2018 13:26:51 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.0", "MIME-Version": "1.0", "In-Reply-To": "<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985557, "web_url": "http://patchwork.ozlabs.org/comment/1985557/", "msgid": "<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>", "list_archive_url": null, "date": "2018-09-05T19:33:23", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 70191, "url": "http://patchwork.ozlabs.org/api/people/70191/?format=api", "name": "Logan Gunthorpe", "email": "logang@deltatee.com" }, "content": "On 05/09/18 01:26 PM, Jens Axboe wrote:\n> On 9/3/18 4:26 PM, Logan Gunthorpe wrote:\n>> I personally agree with Christoph. But if there's consensus in the other\n>> direction or this is a real blocker moving this forward, I can remove it\n>> for the next version.\n> \n> It's a simple branch because the check isn't exhaustive. It just checks\n> the first page. At that point you may as well just require the caller to\n> flag the bio/rq as being P2P, and then do a check for P2P compatibility\n> with the queue.\n\nHmm, we had something like that in v4[1] but it just seemed redundant to\ncreate a flag when the information was already in the bio and kind of\nugly for the caller to check for, then set, the flag. I'm not _that_\naverse to going back to that though...\n\nLogan\n\n[1]\nhttps://lore.kernel.org/lkml/20180423233046.21476-8-logang@deltatee.com/T/#u", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=deltatee.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425DQq0rWVz9sCh\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 05:33:55 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727494AbeIFAFa (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 20:05:30 -0400", "from ale.deltatee.com ([207.54.116.67]:53516 \"EHLO\n\tale.deltatee.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1727267AbeIFAFa (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tWed, 5 Sep 2018 20:05:30 -0400", "from guinness.priv.deltatee.com ([172.16.1.162])\n\tby ale.deltatee.com with esmtp (Exim 4.89)\n\t(envelope-from <logang@deltatee.com>)\n\tid 1fxdYN-0004yR-Rs; Wed, 05 Sep 2018 13:33:28 -0600" ], "To": "Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>", "From": "Logan Gunthorpe <logang@deltatee.com>", "Message-ID": "<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>", "Date": "Wed, 5 Sep 2018 13:33:23 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-SA-Exim-Connect-IP": "172.16.1.162", "X-SA-Exim-Rcpt-To": "christian.koenig@amd.com, alex.williamson@redhat.com,\n\tbenh@kernel.crashing.org, jglisse@redhat.com,\n\tdan.j.williams@intel.com, maxg@mellanox.com, jgg@mellanox.com,\n\tbhelgaas@google.com, sagi@grimberg.me, keith.busch@intel.com,\n\tsbates@raithlin.com, linux-block@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, hch@lst.de, axboe@kernel.dk", "X-SA-Exim-Mail-From": "logang@deltatee.com", "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00,\n\tGREYLIST_ISWHITE autolearn=ham autolearn_force=no version=3.4.1", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "X-SA-Exim-Version": "4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000)", "X-SA-Exim-Scanned": "Yes (on ale.deltatee.com)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985562, "web_url": "http://patchwork.ozlabs.org/comment/1985562/", "msgid": "<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>", "list_archive_url": null, "date": "2018-09-05T19:45:04", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 4515, "url": "http://patchwork.ozlabs.org/api/people/4515/?format=api", "name": "Jens Axboe", "email": "axboe@kernel.dk" }, "content": "On 9/5/18 1:33 PM, Logan Gunthorpe wrote:\n> \n> \n> On 05/09/18 01:26 PM, Jens Axboe wrote:\n>> On 9/3/18 4:26 PM, Logan Gunthorpe wrote:\n>>> I personally agree with Christoph. But if there's consensus in the other\n>>> direction or this is a real blocker moving this forward, I can remove it\n>>> for the next version.\n>>\n>> It's a simple branch because the check isn't exhaustive. It just checks\n>> the first page. At that point you may as well just require the caller to\n>> flag the bio/rq as being P2P, and then do a check for P2P compatibility\n>> with the queue.\n> \n> Hmm, we had something like that in v4[1] but it just seemed redundant to\n> create a flag when the information was already in the bio and kind of\n> ugly for the caller to check for, then set, the flag. I'm not _that_\n> averse to going back to that though...\n\nThe point is that the caller doesn't necessarily know where the bio\nwill end up, hence the caller can't fully check if the whole stack\nsupports P2P.\n\nWhat happens if a P2P request ends up with a driver that doesn't\nsupport it?", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.dk", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel-dk.20150623.gappssmtp.com\n\theader.i=@kernel-dk.20150623.gappssmtp.com\n\theader.b=\"C0JO0Hzl\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425Dgp2KNbz9sCq\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 05:45:10 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727267AbeIFAQs (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 20:16:48 -0400", "from mail-it0-f66.google.com ([209.85.214.66]:40151 \"EHLO\n\tmail-it0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1727674AbeIFAQs (ORCPT\n\t<rfc822;linux-pci@vger.kernel.org>); Wed, 5 Sep 2018 20:16:48 -0400", "by mail-it0-f66.google.com with SMTP id h23-v6so11046102ita.5\n\tfor <linux-pci@vger.kernel.org>; Wed, 05 Sep 2018 12:45:08 -0700 (PDT)", "from [192.168.1.56] ([216.160.245.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tb3-v6sm1166648itj.32.2018.09.05.12.45.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 05 Sep 2018 12:45:06 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=kernel-dk.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=0fECAhizIBhNxKtSSNpeEPwN82HgUK6SANPtOTiRX3A=;\n\tb=C0JO0HzlyB6DKiLtE+2ATnwMKLPynRriso+Qzb6qlfy5Ol/7zCj9bRH9bmCQWXjnEM\n\t8AcikyaqX9nUpVA2qoB6XUdxmo6kB1xCMyHOzIfVlROITrttDe2V4j7eseNMha8TUVfi\n\teFwawxNh25mM5Bt+DyZzdxyPTGfV5QiXJXDJgyzBLTJCEc6PmNVsO1OVH2+LQHe2ljih\n\tfWE3RJm6KQvqUYhJiYVlXrw2V+DHq6EoSk6Y/rIRE18FAiZXMlaodC2lIrvvHjOzQoiI\n\tFwg3YLivA18CKpLLUjgW8jDrQY+UrdDwwM+mw3JHV29OHUT3JJIvPz9Yhm7bDc2SNDTv\n\tmDTQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=0fECAhizIBhNxKtSSNpeEPwN82HgUK6SANPtOTiRX3A=;\n\tb=Ee2BwO6OJCHDVmGLTg/2YAe7v0XSb8nr90ztjLL1R4p6mTU/Z3cDu4R5dl5t7Y3fln\n\tEm7ZQWV+6YcWL3m3JodjY+mkto6AZ8wGXFfXd745PIhsAhUNGLutzZr9cXbI17NrTaq/\n\tCXEbcHV9+VCN3cRDcrWGKhK75dRxLDzEklQqdSJvlvu3tbKhCxRw79131vvf5RbVejuB\n\tZEXNgc+L+RA4J6mxh0T2WhqPJQoruteRhguqEhZlzvKs1KIbDJlUcCkdhUP25hGBYkhm\n\t8+VlGZfNw7H6WfaulqE2uo6El/+wkdEY+n5M22iAgvWSjEdgzd4sw/l9zYa+c9aEF1ZI\n\tuYjQ==", "X-Gm-Message-State": "APzg51ADiBRz9igJ1aSSgtmh5DBhPYG2FqXItTgr47L6nqzmuKfPSEnA\n\tLU0d/VAQFBKidYjJsky3nEeWTQ==", "X-Google-Smtp-Source": "ANB0VdbM4mEHbZ6kEbfGcMvYUTS6B8esz+nJHvNXOgiBuOKqRQp41EeH1IPDe7RHGhrt3waSl6Kvuw==", "X-Received": "by 2002:a02:b459:: with SMTP id\n\tw25-v6mr26739326jaj.32.1536176707638; \n\tWed, 05 Sep 2018 12:45:07 -0700 (PDT)", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "To": "Logan Gunthorpe <logang@deltatee.com>, Christoph Hellwig <hch@lst.de>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>", "From": "Jens Axboe <axboe@kernel.dk>", "Message-ID": "<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>", "Date": "Wed, 5 Sep 2018 13:45:04 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.0", "MIME-Version": "1.0", "In-Reply-To": "<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985564, "web_url": "http://patchwork.ozlabs.org/comment/1985564/", "msgid": "<20180905195647.GA1626@lst.de>", "list_archive_url": null, "date": "2018-09-05T19:56:47", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "content": "On Wed, Sep 05, 2018 at 01:45:04PM -0600, Jens Axboe wrote:\n> The point is that the caller doesn't necessarily know where the bio\n> will end up, hence the caller can't fully check if the whole stack\n> supports P2P.\n\nThe caller must necessarily know where the bio will end up, as for P2P\nsupport we need to query if the bio target is P2P capable vs the\nsource of the P2P memory.", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=lst.de" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425Ds35mydz9sCh\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 05:53:11 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727527AbeIFAYv (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 20:24:51 -0400", "from verein.lst.de ([213.95.11.211]:47027 \"EHLO newverein.lst.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1727364AbeIFAYv (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tWed, 5 Sep 2018 20:24:51 -0400", "by newverein.lst.de (Postfix, from userid 2407)\n\tid 96C0568D40; Wed, 5 Sep 2018 21:56:47 +0200 (CEST)" ], "Date": "Wed, 5 Sep 2018 21:56:47 +0200", "From": "Christoph Hellwig <hch@lst.de>", "To": "Jens Axboe <axboe@kernel.dk>", "Cc": "Logan Gunthorpe <logang@deltatee.com>, Christoph Hellwig <hch@lst.de>,\n\tlinux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org,\n\tStephen Bates <sbates@raithlin.com>, \n\tKeith Busch <keith.busch@intel.com>, Sagi Grimberg <sagi@grimberg.me>,\n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>,\n\tDan Williams <dan.j.williams@intel.com>, =?iso-8859-1?q?J=E9r=F4me?=\n\tGlisse <jglisse@redhat.com>, Benjamin Herrenschmidt\n\t<benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, Christian\n\t=?iso-8859-1?q?K=F6nig?= <christian.koenig@amd.com>", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "Message-ID": "<20180905195647.GA1626@lst.de>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>\n\t<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>", "User-Agent": "Mutt/1.5.17 (2007-11-01)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985567, "web_url": "http://patchwork.ozlabs.org/comment/1985567/", "msgid": "<5e2c8d24-fe09-ad4a-9b11-9238e176be58@deltatee.com>", "list_archive_url": null, "date": "2018-09-05T19:53:43", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 70191, "url": "http://patchwork.ozlabs.org/api/people/70191/?format=api", "name": "Logan Gunthorpe", "email": "logang@deltatee.com" }, "content": "On 05/09/18 01:45 PM, Jens Axboe wrote:\n> The point is that the caller doesn't necessarily know where the bio\n> will end up, hence the caller can't fully check if the whole stack\n> supports P2P.\n> \n> What happens if a P2P request ends up with a driver that doesn't\n> support it?\n\nYes, that's the whole point this check. Although we expect the caller to\ndo other checks before submitting a P2P request to a queue, so if a\ndriver does submit a P2P request to an unsupported queue, it is\ndefinitely a problem in the driver (which is why we want to WARN).\n\nQueues that support P2P (only PCI NVMe at this time, see patch 10) must\nset QUEUE_FLAG_PCI_P2PDMA to indicate it. The check we are adding in\nblk-core is meant to ensure any broken drivers that submit requests with\nP2P memory do not get sent to a queue that doesn't indicate support.\n\nOn top of that, the code in NVMe target ensures that all namespaces on a\nport are backed by queues that support P2P and, if not, it never\nallocates any P2P SGLs.\n\nLogan", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=deltatee.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425Dt75jQrz9sCq\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 05:54:07 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727869AbeIFAZn (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 20:25:43 -0400", "from ale.deltatee.com ([207.54.116.67]:53662 \"EHLO\n\tale.deltatee.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1727364AbeIFAZn (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tWed, 5 Sep 2018 20:25:43 -0400", "from guinness.priv.deltatee.com ([172.16.1.162])\n\tby ale.deltatee.com with esmtp (Exim 4.89)\n\t(envelope-from <logang@deltatee.com>)\n\tid 1fxds1-00058e-Jo; Wed, 05 Sep 2018 13:53:46 -0600" ], "To": "Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>\n\t<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>", "From": "Logan Gunthorpe <logang@deltatee.com>", "Message-ID": "<5e2c8d24-fe09-ad4a-9b11-9238e176be58@deltatee.com>", "Date": "Wed, 5 Sep 2018 13:53:43 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-SA-Exim-Connect-IP": "172.16.1.162", "X-SA-Exim-Rcpt-To": "christian.koenig@amd.com, alex.williamson@redhat.com,\n\tbenh@kernel.crashing.org, jglisse@redhat.com,\n\tdan.j.williams@intel.com, maxg@mellanox.com, jgg@mellanox.com,\n\tbhelgaas@google.com, sagi@grimberg.me, keith.busch@intel.com,\n\tsbates@raithlin.com, linux-block@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, hch@lst.de, axboe@kernel.dk", "X-SA-Exim-Mail-From": "logang@deltatee.com", "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00,\n\tGREYLIST_ISWHITE autolearn=ham autolearn_force=no version=3.4.1", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "X-SA-Exim-Version": "4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000)", "X-SA-Exim-Scanned": "Yes (on ale.deltatee.com)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985568, "web_url": "http://patchwork.ozlabs.org/comment/1985568/", "msgid": "<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>", "list_archive_url": null, "date": "2018-09-05T19:54:31", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 4515, "url": "http://patchwork.ozlabs.org/api/people/4515/?format=api", "name": "Jens Axboe", "email": "axboe@kernel.dk" }, "content": "On 9/5/18 1:56 PM, Christoph Hellwig wrote:\n> On Wed, Sep 05, 2018 at 01:45:04PM -0600, Jens Axboe wrote:\n>> The point is that the caller doesn't necessarily know where the bio\n>> will end up, hence the caller can't fully check if the whole stack\n>> supports P2P.\n> \n> The caller must necessarily know where the bio will end up, as for P2P\n> support we need to query if the bio target is P2P capable vs the\n> source of the P2P memory.\n\nThen what's the point of having the check at all?", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.dk", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel-dk.20150623.gappssmtp.com\n\theader.i=@kernel-dk.20150623.gappssmtp.com\n\theader.b=\"yEmc5qe/\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425Dtj1Fypz9sCh\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 05:54:37 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727715AbeIFA0S (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 20:26:18 -0400", "from mail-it0-f66.google.com ([209.85.214.66]:52629 \"EHLO\n\tmail-it0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1727364AbeIFA0R (ORCPT\n\t<rfc822;linux-pci@vger.kernel.org>); Wed, 5 Sep 2018 20:26:17 -0400", "by mail-it0-f66.google.com with SMTP id h3-v6so11623505ita.2\n\tfor <linux-pci@vger.kernel.org>; Wed, 05 Sep 2018 12:54:35 -0700 (PDT)", "from [192.168.1.56] ([216.160.245.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tk75-v6sm1426041itk.31.2018.09.05.12.54.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 05 Sep 2018 12:54:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=kernel-dk.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=hwWVca0/XHxuWyzuIAuoqX3GfXNrxFdvLjpu2OtS+xw=;\n\tb=yEmc5qe/wfgb+SCWhzJ+8L++ZYy7Zz6QIoNk8/1nu1jHwEcstMR2oBB2k+Y5u0vcFO\n\tQ8Zhz65goLl7B2pRCgrhaaIT8MJWPfVeg+2/V0ov6cbEQAig2iJJJWTKk92HHTmzeZ8g\n\tQuszrINJx0mfCCgYMxnY+dK0n8hZdWUgIDFMlg6LLhJsLPa4wZQMoLblJ1VNyfF9HOe8\n\tyjHZ2kLO4yEZBv4YZtlBd5KJbucrpSRTjism9SgdtX01dIXr2kTIl2jr2D3pMD/qLX3a\n\tn0HsWWI9UnLbNfsQUb8SvR9+WS6FLhgKXuBUYc77muHZchrUD/zlpa/vA5m9juav82o4\n\tR8bA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=hwWVca0/XHxuWyzuIAuoqX3GfXNrxFdvLjpu2OtS+xw=;\n\tb=hKVCS8jh7ke6Ja4c8Spf8jK2GO83DWtUm2FPlXNyyyLYJDEvbd687NWSgHDrawSMM9\n\tpoQxEAUkCRD5KA70sNkHJcwmyACRWB0Qcn++CpP3H+bElzQ9yngFbPx7JktA+OiDtDQB\n\tyOu/ODjEKk8zoC3b2VfTBz7LD7DblnKiIOYwbseabQzV1fugbxDTxgP0TYDZS8zngccX\n\thvAGEoXnNbE1CArI/uFWn/Ob8wONhNjRWSccimLKKLfdoyOmUHajlDAAUspcVkpl4VBS\n\tiNvJsMk3vLFzju5oDyrXj/PiPLh9PuYTeow/WUk3w/oT6aSrqIdAqcqJssIVlQCQfIjp\n\tXexQ==", "X-Gm-Message-State": "APzg51CozQFxiKSmpEg1HpCNxxt/J8SdALBQo0ruPnvcMKWUf4PSHlFz\n\tkGb5w93TFpXnegGxNrIJqeI1ZA==", "X-Google-Smtp-Source": "ANB0VdZ+jErCnNFPgjfm5LwIomY//2z4t9ognP39Ffmw2/1Fp7oHzltaUhUyJ7IBnP8pmXdp5syCsg==", "X-Received": "by 2002:a02:1515:: with SMTP id\n\tj21-v6mr28025426jad.2.1536177274908; \n\tWed, 05 Sep 2018 12:54:34 -0700 (PDT)", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "To": "Christoph Hellwig <hch@lst.de>", "Cc": "Logan Gunthorpe <logang@deltatee.com>, linux-kernel@vger.kernel.org,\n\tlinux-pci@vger.kernel.org, linux-nvme@lists.infradead.org,\n\tlinux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org,\n\tlinux-block@vger.kernel.org, Stephen Bates <sbates@raithlin.com>,\n\tKeith Busch <keith.busch@intel.com>, Sagi Grimberg <sagi@grimberg.me>,\n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>,\n\tDan Williams <dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xp?=\n\t=?utf-8?q?sse?= <jglisse@redhat.com>,\n\tBenjamin Herrenschmidt <benh@kernel.crashing.org>, Alex Williamson\n\t<alex.williamson@redhat.com>, =?utf-8?q?Christian_K=C3=B6nig?=\n\t<christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>\n\t<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>\n\t<20180905195647.GA1626@lst.de>", "From": "Jens Axboe <axboe@kernel.dk>", "Message-ID": "<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>", "Date": "Wed, 5 Sep 2018 13:54:31 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.0", "MIME-Version": "1.0", "In-Reply-To": "<20180905195647.GA1626@lst.de>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985574, "web_url": "http://patchwork.ozlabs.org/comment/1985574/", "msgid": "<20180905201152.GA1893@lst.de>", "list_archive_url": null, "date": "2018-09-05T20:11:52", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "content": "On Wed, Sep 05, 2018 at 01:54:31PM -0600, Jens Axboe wrote:\n> On 9/5/18 1:56 PM, Christoph Hellwig wrote:\n> > On Wed, Sep 05, 2018 at 01:45:04PM -0600, Jens Axboe wrote:\n> >> The point is that the caller doesn't necessarily know where the bio\n> >> will end up, hence the caller can't fully check if the whole stack\n> >> supports P2P.\n> > \n> > The caller must necessarily know where the bio will end up, as for P2P\n> > support we need to query if the bio target is P2P capable vs the\n> > source of the P2P memory.\n> \n> Then what's the point of having the check at all?\n\nJust an additional little safe guard. If you think it isn't worth\nit I guess we can just drop it for now.", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=lst.de" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425FBY5BqWz9sCn\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 06:08:21 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727795AbeIFAj7 (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 20:39:59 -0400", "from verein.lst.de ([213.95.11.211]:47098 \"EHLO newverein.lst.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1727254AbeIFAj7 (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tWed, 5 Sep 2018 20:39:59 -0400", "by newverein.lst.de (Postfix, from userid 2407)\n\tid E280468D40; Wed, 5 Sep 2018 22:11:52 +0200 (CEST)" ], "Date": "Wed, 5 Sep 2018 22:11:52 +0200", "From": "Christoph Hellwig <hch@lst.de>", "To": "Jens Axboe <axboe@kernel.dk>", "Cc": "Christoph Hellwig <hch@lst.de>, Logan Gunthorpe <logang@deltatee.com>,\n\tlinux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, \n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, \n\tStephen Bates <sbates@raithlin.com>,\n\tKeith Busch <keith.busch@intel.com>, Sagi Grimberg <sagi@grimberg.me>,\n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>,\n\tDan Williams <dan.j.williams@intel.com>, =?iso-8859-1?q?J=E9r=F4me?=\n\tGlisse <jglisse@redhat.com>, Benjamin Herrenschmidt\n\t<benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, Christian\n\t=?iso-8859-1?q?K=F6nig?= <christian.koenig@amd.com>", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "Message-ID": "<20180905201152.GA1893@lst.de>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>\n\t<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>\n\t<20180905195647.GA1626@lst.de>\n\t<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>", "User-Agent": "Mutt/1.5.17 (2007-11-01)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985577, "web_url": "http://patchwork.ozlabs.org/comment/1985577/", "msgid": "<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>", "list_archive_url": null, "date": "2018-09-05T20:09:55", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 70191, "url": "http://patchwork.ozlabs.org/api/people/70191/?format=api", "name": "Logan Gunthorpe", "email": "logang@deltatee.com" }, "content": "On 05/09/18 02:11 PM, Christoph Hellwig wrote:\n> On Wed, Sep 05, 2018 at 01:54:31PM -0600, Jens Axboe wrote:\n>> On 9/5/18 1:56 PM, Christoph Hellwig wrote:\n>>> On Wed, Sep 05, 2018 at 01:45:04PM -0600, Jens Axboe wrote:\n>>>> The point is that the caller doesn't necessarily know where the bio\n>>>> will end up, hence the caller can't fully check if the whole stack\n>>>> supports P2P.\n>>>\n>>> The caller must necessarily know where the bio will end up, as for P2P\n>>> support we need to query if the bio target is P2P capable vs the\n>>> source of the P2P memory.\n>>\n>> Then what's the point of having the check at all?\n> \n> Just an additional little safe guard. If you think it isn't worth\n> it I guess we can just drop it for now.\n\nYes, the point is to prevent driver writers from doing the wrong thing\nby not doing the necessary checks before submitting to the queue.\n\nLogan", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=deltatee.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425FDy05znz9sCh\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 06:10:26 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727850AbeIFAmK (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 20:42:10 -0400", "from ale.deltatee.com ([207.54.116.67]:53816 \"EHLO\n\tale.deltatee.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1727688AbeIFAmJ (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tWed, 5 Sep 2018 20:42:09 -0400", "from guinness.priv.deltatee.com ([172.16.1.162])\n\tby ale.deltatee.com with esmtp (Exim 4.89)\n\t(envelope-from <logang@deltatee.com>)\n\tid 1fxe7h-0005Wq-UG; Wed, 05 Sep 2018 14:09:58 -0600" ], "To": "Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>\n\t<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>\n\t<20180905195647.GA1626@lst.de>\n\t<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>\n\t<20180905201152.GA1893@lst.de>", "From": "Logan Gunthorpe <logang@deltatee.com>", "Message-ID": "<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>", "Date": "Wed, 5 Sep 2018 14:09:55 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<20180905201152.GA1893@lst.de>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-SA-Exim-Connect-IP": "172.16.1.162", "X-SA-Exim-Rcpt-To": "christian.koenig@amd.com, alex.williamson@redhat.com,\n\tbenh@kernel.crashing.org, jglisse@redhat.com,\n\tdan.j.williams@intel.com, maxg@mellanox.com, jgg@mellanox.com,\n\tbhelgaas@google.com, sagi@grimberg.me, keith.busch@intel.com,\n\tsbates@raithlin.com, linux-block@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, axboe@kernel.dk, hch@lst.de", "X-SA-Exim-Mail-From": "logang@deltatee.com", "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00,\n\tGREYLIST_ISWHITE autolearn=ham autolearn_force=no version=3.4.1", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "X-SA-Exim-Version": "4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000)", "X-SA-Exim-Scanned": "Yes (on ale.deltatee.com)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985579, "web_url": "http://patchwork.ozlabs.org/comment/1985579/", "msgid": "<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>", "list_archive_url": null, "date": "2018-09-05T20:14:48", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 4515, "url": "http://patchwork.ozlabs.org/api/people/4515/?format=api", "name": "Jens Axboe", "email": "axboe@kernel.dk" }, "content": "On 9/5/18 2:09 PM, Logan Gunthorpe wrote:\n> \n> \n> On 05/09/18 02:11 PM, Christoph Hellwig wrote:\n>> On Wed, Sep 05, 2018 at 01:54:31PM -0600, Jens Axboe wrote:\n>>> On 9/5/18 1:56 PM, Christoph Hellwig wrote:\n>>>> On Wed, Sep 05, 2018 at 01:45:04PM -0600, Jens Axboe wrote:\n>>>>> The point is that the caller doesn't necessarily know where the bio\n>>>>> will end up, hence the caller can't fully check if the whole stack\n>>>>> supports P2P.\n>>>>\n>>>> The caller must necessarily know where the bio will end up, as for P2P\n>>>> support we need to query if the bio target is P2P capable vs the\n>>>> source of the P2P memory.\n>>>\n>>> Then what's the point of having the check at all?\n>>\n>> Just an additional little safe guard. If you think it isn't worth\n>> it I guess we can just drop it for now.\n> \n> Yes, the point is to prevent driver writers from doing the wrong thing\n> by not doing the necessary checks before submitting to the queue.\n\nBut if the caller must absolutely know where the bio will end up, then\nit seems super redundant. So I'd vote for killing this check, it buys\nus absolutely nothing and isn't even exhaustive in its current form.", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.dk", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel-dk.20150623.gappssmtp.com\n\theader.i=@kernel-dk.20150623.gappssmtp.com\n\theader.b=\"Z6lGVNAJ\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425FL60xbzz9sCs\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 06:14:54 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727959AbeIFAqi (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 20:46:38 -0400", "from mail-it0-f53.google.com ([209.85.214.53]:38182 \"EHLO\n\tmail-it0-f53.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1727599AbeIFAqi (ORCPT\n\t<rfc822;linux-pci@vger.kernel.org>); Wed, 5 Sep 2018 20:46:38 -0400", "by mail-it0-f53.google.com with SMTP id p129-v6so11174986ite.3\n\tfor <linux-pci@vger.kernel.org>; Wed, 05 Sep 2018 13:14:51 -0700 (PDT)", "from [192.168.1.56] ([216.160.245.98])\n\tby smtp.gmail.com with ESMTPSA id\n\td134-v6sm902201iog.84.2018.09.05.13.14.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 05 Sep 2018 13:14:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=kernel-dk.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=EwfboM9jZUO13Bzodil9bm0IpV5Cci/yRxwfapPgYIM=;\n\tb=Z6lGVNAJl3O/T2p0V8Chgvp1lYSDbbf2kiJT5XwnguCr8BY3C80QNvhFQsOvuBIPVw\n\tveQhd/eWuruhWF95e9TyWJMlBm5uJb4rxKViCUSwLBdvZ7tWFoF0dguhqGxO1o6R2fYw\n\tPJwD5umAYc8BFCO4f+WiQc4VKbu7VtrlFe5EPc1r/Kl/XDGIU06IXbzXV62aO8UnJDmL\n\t9jsyYtbXfALo+ksqIchPVlrVr48gi/SXtwLc/iyZAgDaUUKGIsvIQPlAxltU5a6XgHDh\n\t3F70BNzXEZwXjdVTh/dJGoJUW4nk5NdFFfO/F7vhoH6uB+Ml9KDPQpNz0uow2Pi2S6j0\n\tBfBg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=EwfboM9jZUO13Bzodil9bm0IpV5Cci/yRxwfapPgYIM=;\n\tb=PFTSq2sPK2uvXV4yajQI0hWC4KbqT0IKsQZXCuazbAw4kKYDfsPAjg3uRsCW1/2JMS\n\t46xaPMJsyvN9qEjm4HP2Pxivg+tQZovBbuGJphNDLN68Z5uyxtkQ1MYHJUX4+zr7DoPF\n\tH5VQtLM0QxfdK9YGdS97In73v7RdiaIUWLCfbbvr0+T6N/8wgBrtf2E7mqi8VBVpKZ8m\n\tNJobl8PfvupBPA3ANmetF+Y0QmuDnDzWX9DJmptgjfx/IXbOXtXqQRBN1chv/UvgryDO\n\tgwNm3WheLdjkAWU2mWnFWgnPc/4SgAS73uqE9YRMyhk89iqjEHY+Vf5G6RCApqnz+r88\n\tggWg==", "X-Gm-Message-State": "APzg51B+8wkjNL7LPUk4TJJA9oVUzndQdS2MY5qH49MP3hsXtTpUvAcW\n\ttSTslH3GphVmANN7oLhpbZnXsQ==", "X-Google-Smtp-Source": "ANB0VdZu6dDvBOUmeN+DPI1YAgZitD7XIt58kVWxMmjic3lCjlwWeMYu31KW2ZjLPD9OV48GNVQaTQ==", "X-Received": "by 2002:a24:5004:: with SMTP id m4-v6mr59900itb.38.1536178491314;\n\tWed, 05 Sep 2018 13:14:51 -0700 (PDT)", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "To": "Logan Gunthorpe <logang@deltatee.com>, Christoph Hellwig <hch@lst.de>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>\n\t<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>\n\t<20180905195647.GA1626@lst.de>\n\t<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>\n\t<20180905201152.GA1893@lst.de>\n\t<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>", "From": "Jens Axboe <axboe@kernel.dk>", "Message-ID": "<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>", "Date": "Wed, 5 Sep 2018 14:14:48 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.0", "MIME-Version": "1.0", "In-Reply-To": "<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985581, "web_url": "http://patchwork.ozlabs.org/comment/1985581/", "msgid": "<e3ef26e6-6c8d-25b8-fa64-14594a51263c@deltatee.com>", "list_archive_url": null, "date": "2018-09-05T20:18:03", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 70191, "url": "http://patchwork.ozlabs.org/api/people/70191/?format=api", "name": "Logan Gunthorpe", "email": "logang@deltatee.com" }, "content": "On 05/09/18 02:14 PM, Jens Axboe wrote:\n> But if the caller must absolutely know where the bio will end up, then\n> it seems super redundant. So I'd vote for killing this check, it buys\n> us absolutely nothing and isn't even exhaustive in its current form.\n\n\nOk, I'll remove it for v6.\n\nLogan", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=deltatee.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425FQC6Cd2z9sCn\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 06:18:27 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727692AbeIFAuI (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 20:50:08 -0400", "from ale.deltatee.com ([207.54.116.67]:53898 \"EHLO\n\tale.deltatee.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1727599AbeIFAuI (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tWed, 5 Sep 2018 20:50:08 -0400", "from guinness.priv.deltatee.com ([172.16.1.162])\n\tby ale.deltatee.com with esmtp (Exim 4.89)\n\t(envelope-from <logang@deltatee.com>)\n\tid 1fxeFY-0005al-7K; Wed, 05 Sep 2018 14:18:04 -0600" ], "To": "Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>\n\t<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>\n\t<20180905195647.GA1626@lst.de>\n\t<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>\n\t<20180905201152.GA1893@lst.de>\n\t<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>\n\t<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>", "From": "Logan Gunthorpe <logang@deltatee.com>", "Message-ID": "<e3ef26e6-6c8d-25b8-fa64-14594a51263c@deltatee.com>", "Date": "Wed, 5 Sep 2018 14:18:03 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-SA-Exim-Connect-IP": "172.16.1.162", "X-SA-Exim-Rcpt-To": "christian.koenig@amd.com, alex.williamson@redhat.com,\n\tbenh@kernel.crashing.org, jglisse@redhat.com,\n\tdan.j.williams@intel.com, maxg@mellanox.com, jgg@mellanox.com,\n\tbhelgaas@google.com, sagi@grimberg.me, keith.busch@intel.com,\n\tsbates@raithlin.com, linux-block@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, hch@lst.de, axboe@kernel.dk", "X-SA-Exim-Mail-From": "logang@deltatee.com", "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00,\n\tGREYLIST_ISWHITE autolearn=ham autolearn_force=no version=3.4.1", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "X-SA-Exim-Version": "4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000)", "X-SA-Exim-Scanned": "Yes (on ale.deltatee.com)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985582, "web_url": "http://patchwork.ozlabs.org/comment/1985582/", "msgid": "<3af4d1d4-da07-c0a6-8464-9ddc1378f2f4@kernel.dk>", "list_archive_url": null, "date": "2018-09-05T20:19:39", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 4515, "url": "http://patchwork.ozlabs.org/api/people/4515/?format=api", "name": "Jens Axboe", "email": "axboe@kernel.dk" }, "content": "On 9/5/18 2:18 PM, Logan Gunthorpe wrote:\n> \n> \n> On 05/09/18 02:14 PM, Jens Axboe wrote:\n>> But if the caller must absolutely know where the bio will end up, then\n>> it seems super redundant. So I'd vote for killing this check, it buys\n>> us absolutely nothing and isn't even exhaustive in its current form.\n> \n> \n> Ok, I'll remove it for v6.\n\nSince the drivers needs to know it's doing it right, it might not\nhurt to add a sanity check helper for that. Just have the driver\ncall it, and don't add it in the normal IO submission path.", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.dk", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel-dk.20150623.gappssmtp.com\n\theader.i=@kernel-dk.20150623.gappssmtp.com\n\theader.b=\"uKNMms6J\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425FRk6BMpz9sCn\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 06:19:46 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727986AbeIFAvb (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 20:51:31 -0400", "from mail-it0-f46.google.com ([209.85.214.46]:33381 \"EHLO\n\tmail-it0-f46.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1727848AbeIFAva (ORCPT\n\t<rfc822;linux-pci@vger.kernel.org>); Wed, 5 Sep 2018 20:51:30 -0400", "by mail-it0-f46.google.com with SMTP id j198-v6so17819294ita.0\n\tfor <linux-pci@vger.kernel.org>; Wed, 05 Sep 2018 13:19:42 -0700 (PDT)", "from [192.168.1.56] ([216.160.245.98])\n\tby smtp.gmail.com with ESMTPSA id\n\te129-v6sm1371708ite.35.2018.09.05.13.19.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 05 Sep 2018 13:19:40 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=kernel-dk.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=I2A46jX71yroumZdLirx89tBYPtjvNrtZpAe6pwPsIw=;\n\tb=uKNMms6JWhE33FlQRWls0EgRXlbMKZhk+/WMR/5xDPUIs3rNAH1Dg6VPV4/QVRI2L+\n\tO7pqwoyEFNLl94EjrLN9REKWPvRmxJluaPTaQLa3FAaLVzjwkbn0uHQ05e/M0SLc2uNS\n\tVSxTXl/bMVlVmzm2/etVXutbedoT/+a3HZFFtCykXIrTkr6EzVP7jszwJT5gZeFWKve1\n\tJHZYvmhLRw+IaSqhrKGQ8xrpvZckCLRi17rGwY+3+YMSe2oG1scJOpahwqtnkotLaGq1\n\tiIKjLaR+Oa8DpqCVSFDqk2RLlEHoLZ2I4ZgQtzt+p301HQGeNOlJH3RoUlmTsjgaZIeQ\n\t0XZg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=I2A46jX71yroumZdLirx89tBYPtjvNrtZpAe6pwPsIw=;\n\tb=SZjItSXyL5V/xcu7ZOXgzEeRe8oejQp42c/cmlT5C2b6DXbBpZGKa+plfMynF596Dy\n\tIFJrTNyRsklYv3+uhFefQhQ30kPdoqb4re0yePEPJWwBM5e61UGdIEfCzvrXjFJRHfEf\n\t4oH8JmisPH1H3fgxq6rorn1zRWK9/+UptcahgFiHrFQzJsjMr9OKtbfPIPOf/A9pGvMN\n\twMTDPyPGp5e9K5HLgOLHtBaDZvXE2xTIkrAkTEqSBVpm7TclrD+bR+PDYumaWX+e23Kc\n\tbZo/wTtcrTfTstV9B5ofPmS3BGMFvQE15wp/hia91woUMIY+Vc1odye70Z5S5BsyvFtg\n\tegjw==", "X-Gm-Message-State": "APzg51AzcZHME2mb6Qs2+sNrXIawRp37wT0A05MMbgWk/MxeZXjz988n\n\t05itN4b1mwDlALha640uunILgw==", "X-Google-Smtp-Source": "ANB0VdYpQiJ1z0uHxCVA4YQQAwT2AjnQSnTCoyZas6qbncRw9k/nmT+11SVvxsfYRoD8/xbrkZ1qCg==", "X-Received": "by 2002:a24:4c90:: with SMTP id\n\ta138-v6mr48194itb.138.1536178782002; \n\tWed, 05 Sep 2018 13:19:42 -0700 (PDT)", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "To": "Logan Gunthorpe <logang@deltatee.com>, Christoph Hellwig <hch@lst.de>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>\n\t<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>\n\t<20180905195647.GA1626@lst.de>\n\t<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>\n\t<20180905201152.GA1893@lst.de>\n\t<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>\n\t<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>\n\t<e3ef26e6-6c8d-25b8-fa64-14594a51263c@deltatee.com>", "From": "Jens Axboe <axboe@kernel.dk>", "Message-ID": "<3af4d1d4-da07-c0a6-8464-9ddc1378f2f4@kernel.dk>", "Date": "Wed, 5 Sep 2018 14:19:39 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.0", "MIME-Version": "1.0", "In-Reply-To": "<e3ef26e6-6c8d-25b8-fa64-14594a51263c@deltatee.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985585, "web_url": "http://patchwork.ozlabs.org/comment/1985585/", "msgid": "<f9e660cd-b597-bb6e-56a2-82fe71cb3649@deltatee.com>", "list_archive_url": null, "date": "2018-09-05T20:32:06", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 70191, "url": "http://patchwork.ozlabs.org/api/people/70191/?format=api", "name": "Logan Gunthorpe", "email": "logang@deltatee.com" }, "content": "On 05/09/18 02:19 PM, Jens Axboe wrote:\n> On 9/5/18 2:18 PM, Logan Gunthorpe wrote:\n>>\n>>\n>> On 05/09/18 02:14 PM, Jens Axboe wrote:\n>>> But if the caller must absolutely know where the bio will end up, then\n>>> it seems super redundant. So I'd vote for killing this check, it buys\n>>> us absolutely nothing and isn't even exhaustive in its current form.\n>>\n>>\n>> Ok, I'll remove it for v6.\n> \n> Since the drivers needs to know it's doing it right, it might not\n> hurt to add a sanity check helper for that. Just have the driver\n> call it, and don't add it in the normal IO submission path.\n\nI'm not sure I really see the value in that. It's the same principle in\nasking the driver to do the WARN: if the developer knew enough to use\nthe special helper, they probably knew well enough to do the rest correctly.\n\nI guess one other thing to point out is that, on x86, if a driver\nsubmits P2P pages to a PCI device that doesn't have kernel support,\neverything will likely just work. Even though the driver isn't doing any\nof the work correctly and the requests are not being mapped with\npci_p2pdma_map() functions. Such code on other arches would likely\nbreak. So developers may be lulled into thinking they're doing the\ncorrect thing when in fact they are not and the WARN in the common code\nwould prevent that.\n\nLogan", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=deltatee.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425FkP5Yfgz9s3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 06:32:29 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727692AbeIFBES (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 21:04:18 -0400", "from ale.deltatee.com ([207.54.116.67]:54040 \"EHLO\n\tale.deltatee.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1727645AbeIFBES (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tWed, 5 Sep 2018 21:04:18 -0400", "from guinness.priv.deltatee.com ([172.16.1.162])\n\tby ale.deltatee.com with esmtp (Exim 4.89)\n\t(envelope-from <logang@deltatee.com>)\n\tid 1fxeT9-0005h5-6D; Wed, 05 Sep 2018 14:32:08 -0600" ], "To": "Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>\n\t<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>\n\t<20180905195647.GA1626@lst.de>\n\t<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>\n\t<20180905201152.GA1893@lst.de>\n\t<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>\n\t<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>\n\t<e3ef26e6-6c8d-25b8-fa64-14594a51263c@deltatee.com>\n\t<3af4d1d4-da07-c0a6-8464-9ddc1378f2f4@kernel.dk>", "From": "Logan Gunthorpe <logang@deltatee.com>", "Message-ID": "<f9e660cd-b597-bb6e-56a2-82fe71cb3649@deltatee.com>", "Date": "Wed, 5 Sep 2018 14:32:06 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<3af4d1d4-da07-c0a6-8464-9ddc1378f2f4@kernel.dk>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-SA-Exim-Connect-IP": "172.16.1.162", "X-SA-Exim-Rcpt-To": "christian.koenig@amd.com, alex.williamson@redhat.com,\n\tbenh@kernel.crashing.org, jglisse@redhat.com,\n\tdan.j.williams@intel.com, maxg@mellanox.com, jgg@mellanox.com,\n\tbhelgaas@google.com, sagi@grimberg.me, keith.busch@intel.com,\n\tsbates@raithlin.com, linux-block@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, hch@lst.de, axboe@kernel.dk", "X-SA-Exim-Mail-From": "logang@deltatee.com", "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00,\n\tGREYLIST_ISWHITE autolearn=ham autolearn_force=no version=3.4.1", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "X-SA-Exim-Version": "4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000)", "X-SA-Exim-Scanned": "Yes (on ale.deltatee.com)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985594, "web_url": "http://patchwork.ozlabs.org/comment/1985594/", "msgid": "<34d9b2f7-9e6d-4a0a-77e5-ec0e99610f5c@kernel.dk>", "list_archive_url": null, "date": "2018-09-05T20:36:56", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 4515, "url": "http://patchwork.ozlabs.org/api/people/4515/?format=api", "name": "Jens Axboe", "email": "axboe@kernel.dk" }, "content": "On 9/5/18 2:32 PM, Logan Gunthorpe wrote:\n> \n> \n> On 05/09/18 02:19 PM, Jens Axboe wrote:\n>> On 9/5/18 2:18 PM, Logan Gunthorpe wrote:\n>>>\n>>>\n>>> On 05/09/18 02:14 PM, Jens Axboe wrote:\n>>>> But if the caller must absolutely know where the bio will end up, then\n>>>> it seems super redundant. So I'd vote for killing this check, it buys\n>>>> us absolutely nothing and isn't even exhaustive in its current form.\n>>>\n>>>\n>>> Ok, I'll remove it for v6.\n>>\n>> Since the drivers needs to know it's doing it right, it might not\n>> hurt to add a sanity check helper for that. Just have the driver\n>> call it, and don't add it in the normal IO submission path.\n> \n> I'm not sure I really see the value in that. It's the same principle in\n> asking the driver to do the WARN: if the developer knew enough to use\n> the special helper, they probably knew well enough to do the rest correctly.\n\nI don't agree with that at all. It's a \"is my request valid\" helper,\nit's not some obscure and rarely used functionality. You're making up\nthis API right now, if you really want it done for every IO, make it\npart of the p2p submission process. You could even hide it behind a\ndebug thing, if you like.\n\n> I guess one other thing to point out is that, on x86, if a driver\n> submits P2P pages to a PCI device that doesn't have kernel support,\n> everything will likely just work. Even though the driver isn't doing any\n> of the work correctly and the requests are not being mapped with\n> pci_p2pdma_map() functions. Such code on other arches would likely\n> break. So developers may be lulled into thinking they're doing the\n> correct thing when in fact they are not and the WARN in the common code\n> would prevent that.\n\nIf you're adamant about having it in common code, put it in your\ncommon submission code. Most folks aren't going to care about P2P, let the\nones that do have the checks.", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.dk", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel-dk.20150623.gappssmtp.com\n\theader.i=@kernel-dk.20150623.gappssmtp.com\n\theader.b=\"lkmEPxUH\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425Fql1DLcz9sCn\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 06:37:07 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727981AbeIFBIv (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 21:08:51 -0400", "from mail-io0-f196.google.com ([209.85.223.196]:38507 \"EHLO\n\tmail-io0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1727959AbeIFBIv (ORCPT\n\t<rfc822;linux-pci@vger.kernel.org>); Wed, 5 Sep 2018 21:08:51 -0400", "by mail-io0-f196.google.com with SMTP id y3-v6so7096528ioc.5\n\tfor <linux-pci@vger.kernel.org>; Wed, 05 Sep 2018 13:36:59 -0700 (PDT)", "from [192.168.1.56] ([216.160.245.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tv3-v6sm2145245ita.6.2018.09.05.13.36.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 05 Sep 2018 13:36:57 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=kernel-dk.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=gY5o9ua+f1nyI7zjfo+Jmm/sZ/ain01iPpxJ1bvEMMU=;\n\tb=lkmEPxUHVGyhlJ8XyftPS7q76JZUvTtq8Rsypl3G05eHs7YQEAAEjjqbORqTNwvgH0\n\tA8L4WKl6lNT3M9NWA+OxUN8cVCFCIfA0uuu3w5k4F6CVwxEsd9MxSpeVutjApijJ12Xu\n\tUDtgxdk/v8vNytsv4Z4E32P7q+waTBiqDDAwC6C6u4/+/q9YW/npXuudvXVV3KJ0tgBW\n\trfvEJyOUmwIK/uG0sJaycUm0Ii7CqyIpsgI30+xUs7/5zoKxoVLmqcLvUUDjjZg0oSv1\n\tkmAljYw1Ri1YfVJpo5PxgToEWKz9GHUKroIK8K9v/M/pytFpS46uHFP+5I2ZAOWSN0rA\n\t5NXw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=gY5o9ua+f1nyI7zjfo+Jmm/sZ/ain01iPpxJ1bvEMMU=;\n\tb=Z8IDu17x60K904SpQwjr+Ub68PPlFzJZvLbLgYeF2ZrTvgKsAPhXp5vaS+dm5U4MHQ\n\tS+rr83Sn+cBJnjP4sPpYFe0FbF8Q56B0OA2RYihC2phzlo1vehhQ4+6yuzcdKqH6vj/F\n\tWt57cd1K7WWq4TSlBYw8imtK4wjJ3q7J0LiKigyJiqYW0fK5wpPsBnYsuZ42MUK7t7ZC\n\tfR5D4mBUVuMQH0krg5H6d6aAi3J9vrpu4wB90GbDJKttygcioDD+bZGLykLNrwZqHWUD\n\tLsYf/Xalmj78kb3RYGA6UXVpNJOLvgRSF2W06cWj/cHq1c+l+eD/o/04bO+wI5aDtKD6\n\tOySg==", "X-Gm-Message-State": "APzg51AJTfmTX09e1tauEvutkxd6RXlLyl49cVoCufNjLIYfSQHcUU4N\n\t7+e2RpzN7ogJdwdlvGY1bIT8eA==", "X-Google-Smtp-Source": "ANB0Vda1odh/MnEXgunylann8L2l6J+F0MWotCcMfDLoBFEoaaKtnahEQ5nyZV2uVIdaPRod+iGDSg==", "X-Received": "by 2002:a6b:25d2:: with SMTP id\n\tl201-v6mr26958207iol.115.1536179819165; \n\tWed, 05 Sep 2018 13:36:59 -0700 (PDT)", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "To": "Logan Gunthorpe <logang@deltatee.com>, Christoph Hellwig <hch@lst.de>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>\n\t<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>\n\t<20180905195647.GA1626@lst.de>\n\t<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>\n\t<20180905201152.GA1893@lst.de>\n\t<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>\n\t<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>\n\t<e3ef26e6-6c8d-25b8-fa64-14594a51263c@deltatee.com>\n\t<3af4d1d4-da07-c0a6-8464-9ddc1378f2f4@kernel.dk>\n\t<f9e660cd-b597-bb6e-56a2-82fe71cb3649@deltatee.com>", "From": "Jens Axboe <axboe@kernel.dk>", "Message-ID": "<34d9b2f7-9e6d-4a0a-77e5-ec0e99610f5c@kernel.dk>", "Date": "Wed, 5 Sep 2018 14:36:56 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.0", "MIME-Version": "1.0", "In-Reply-To": "<f9e660cd-b597-bb6e-56a2-82fe71cb3649@deltatee.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985613, "web_url": "http://patchwork.ozlabs.org/comment/1985613/", "msgid": "<c41c802c-9235-5383-2dfa-af9c1553f11b@deltatee.com>", "list_archive_url": null, "date": "2018-09-05T21:03:18", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 70191, "url": "http://patchwork.ozlabs.org/api/people/70191/?format=api", "name": "Logan Gunthorpe", "email": "logang@deltatee.com" }, "content": "On 05/09/18 02:36 PM, Jens Axboe wrote:\n> On 9/5/18 2:32 PM, Logan Gunthorpe wrote:\n>>\n>>\n>> On 05/09/18 02:19 PM, Jens Axboe wrote:\n>>> On 9/5/18 2:18 PM, Logan Gunthorpe wrote:\n>>>>\n>>>>\n>>>> On 05/09/18 02:14 PM, Jens Axboe wrote:\n>>>>> But if the caller must absolutely know where the bio will end up, then\n>>>>> it seems super redundant. So I'd vote for killing this check, it buys\n>>>>> us absolutely nothing and isn't even exhaustive in its current form.\n>>>>\n>>>>\n>>>> Ok, I'll remove it for v6.\n>>>\n>>> Since the drivers needs to know it's doing it right, it might not\n>>> hurt to add a sanity check helper for that. Just have the driver\n>>> call it, and don't add it in the normal IO submission path.\n>>\n>> I'm not sure I really see the value in that. It's the same principle in\n>> asking the driver to do the WARN: if the developer knew enough to use\n>> the special helper, they probably knew well enough to do the rest correctly.\n> \n> I don't agree with that at all. It's a \"is my request valid\" helper,\n> it's not some obscure and rarely used functionality. You're making up\n> this API right now, if you really want it done for every IO, make it\n> part of the p2p submission process. You could even hide it behind a\n> debug thing, if you like.\n\nThere is no special p2p submission process. In the nvme-of case we are\nusing the existing process and with the code in blk-core it didn't\nchange it's process at all. Creating a helper will create one and I can\nlook at making a pci_p2pdma_submit_bio() for v6; but if the developer\nscrews up and still calls the regular submit_bio() things will only be\nvery subtly broken and that won't be obvious.\n\nLogan", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=deltatee.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425GQW51CYz9sBy\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 07:03:47 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727675AbeIFBfg (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 21:35:36 -0400", "from ale.deltatee.com ([207.54.116.67]:54260 \"EHLO\n\tale.deltatee.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1727669AbeIFBfg (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tWed, 5 Sep 2018 21:35:36 -0400", "from guinness.priv.deltatee.com ([172.16.1.162])\n\tby ale.deltatee.com with esmtp (Exim 4.89)\n\t(envelope-from <logang@deltatee.com>)\n\tid 1fxexN-0006AE-HK; Wed, 05 Sep 2018 15:03:22 -0600" ], "To": "Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>\n\t<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>\n\t<20180905195647.GA1626@lst.de>\n\t<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>\n\t<20180905201152.GA1893@lst.de>\n\t<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>\n\t<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>\n\t<e3ef26e6-6c8d-25b8-fa64-14594a51263c@deltatee.com>\n\t<3af4d1d4-da07-c0a6-8464-9ddc1378f2f4@kernel.dk>\n\t<f9e660cd-b597-bb6e-56a2-82fe71cb3649@deltatee.com>\n\t<34d9b2f7-9e6d-4a0a-77e5-ec0e99610f5c@kernel.dk>", "From": "Logan Gunthorpe <logang@deltatee.com>", "Message-ID": "<c41c802c-9235-5383-2dfa-af9c1553f11b@deltatee.com>", "Date": "Wed, 5 Sep 2018 15:03:18 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<34d9b2f7-9e6d-4a0a-77e5-ec0e99610f5c@kernel.dk>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-SA-Exim-Connect-IP": "172.16.1.162", "X-SA-Exim-Rcpt-To": "christian.koenig@amd.com, alex.williamson@redhat.com,\n\tbenh@kernel.crashing.org, jglisse@redhat.com,\n\tdan.j.williams@intel.com, maxg@mellanox.com, jgg@mellanox.com,\n\tbhelgaas@google.com, sagi@grimberg.me, keith.busch@intel.com,\n\tsbates@raithlin.com, linux-block@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, hch@lst.de, axboe@kernel.dk", "X-SA-Exim-Mail-From": "logang@deltatee.com", "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00,\n\tGREYLIST_ISWHITE autolearn=ham autolearn_force=no version=3.4.1", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "X-SA-Exim-Version": "4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000)", "X-SA-Exim-Scanned": "Yes (on ale.deltatee.com)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985617, "web_url": "http://patchwork.ozlabs.org/comment/1985617/", "msgid": "<20180905211351.GA2927@lst.de>", "list_archive_url": null, "date": "2018-09-05T21:13:51", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "content": "On Wed, Sep 05, 2018 at 03:03:18PM -0600, Logan Gunthorpe wrote:\n> There is no special p2p submission process. In the nvme-of case we are\n> using the existing process and with the code in blk-core it didn't\n> change it's process at all. Creating a helper will create one and I can\n> look at making a pci_p2pdma_submit_bio() for v6; but if the developer\n> screws up and still calls the regular submit_bio() things will only be\n> very subtly broken and that won't be obvious.\n\nI thought about that when reviewing the previous series, and even\nstarted hacking it up. In the end I decided against it for the above\nreason - it just adds code, but doesn't actually help with anything\nas it is trivial to forget, and not using it will in fact just work.", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=lst.de" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425GZ52czCz9sBy\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 07:10:21 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727695AbeIFBmL (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 21:42:11 -0400", "from verein.lst.de ([213.95.11.211]:47314 \"EHLO newverein.lst.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1727069AbeIFBmK (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tWed, 5 Sep 2018 21:42:10 -0400", "by newverein.lst.de (Postfix, from userid 2407)\n\tid 2441468D40; Wed, 5 Sep 2018 23:13:51 +0200 (CEST)" ], "Date": "Wed, 5 Sep 2018 23:13:51 +0200", "From": "Christoph Hellwig <hch@lst.de>", "To": "Logan Gunthorpe <logang@deltatee.com>", "Cc": "Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,\n\tlinux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, \n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?iso-8859-1?q?J=E9r=F4me?=\n\tGlisse <jglisse@redhat.com>, Benjamin Herrenschmidt\n\t<benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, Christian\n\t=?iso-8859-1?q?K=F6nig?= <christian.koenig@amd.com>", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "Message-ID": "<20180905211351.GA2927@lst.de>", "References": "<20180905195647.GA1626@lst.de>\n\t<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>\n\t<20180905201152.GA1893@lst.de>\n\t<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>\n\t<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>\n\t<e3ef26e6-6c8d-25b8-fa64-14594a51263c@deltatee.com>\n\t<3af4d1d4-da07-c0a6-8464-9ddc1378f2f4@kernel.dk>\n\t<f9e660cd-b597-bb6e-56a2-82fe71cb3649@deltatee.com>\n\t<34d9b2f7-9e6d-4a0a-77e5-ec0e99610f5c@kernel.dk>\n\t<c41c802c-9235-5383-2dfa-af9c1553f11b@deltatee.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<c41c802c-9235-5383-2dfa-af9c1553f11b@deltatee.com>", "User-Agent": "Mutt/1.5.17 (2007-11-01)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1985624, "web_url": "http://patchwork.ozlabs.org/comment/1985624/", "msgid": "<957591a9-3b9d-e730-9919-508349735db9@kernel.dk>", "list_archive_url": null, "date": "2018-09-05T21:18:48", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 4515, "url": "http://patchwork.ozlabs.org/api/people/4515/?format=api", "name": "Jens Axboe", "email": "axboe@kernel.dk" }, "content": "On 9/5/18 3:03 PM, Logan Gunthorpe wrote:\n> \n> \n> On 05/09/18 02:36 PM, Jens Axboe wrote:\n>> On 9/5/18 2:32 PM, Logan Gunthorpe wrote:\n>>>\n>>>\n>>> On 05/09/18 02:19 PM, Jens Axboe wrote:\n>>>> On 9/5/18 2:18 PM, Logan Gunthorpe wrote:\n>>>>>\n>>>>>\n>>>>> On 05/09/18 02:14 PM, Jens Axboe wrote:\n>>>>>> But if the caller must absolutely know where the bio will end up, then\n>>>>>> it seems super redundant. So I'd vote for killing this check, it buys\n>>>>>> us absolutely nothing and isn't even exhaustive in its current form.\n>>>>>\n>>>>>\n>>>>> Ok, I'll remove it for v6.\n>>>>\n>>>> Since the drivers needs to know it's doing it right, it might not\n>>>> hurt to add a sanity check helper for that. Just have the driver\n>>>> call it, and don't add it in the normal IO submission path.\n>>>\n>>> I'm not sure I really see the value in that. It's the same principle in\n>>> asking the driver to do the WARN: if the developer knew enough to use\n>>> the special helper, they probably knew well enough to do the rest correctly.\n>>\n>> I don't agree with that at all. It's a \"is my request valid\" helper,\n>> it's not some obscure and rarely used functionality. You're making up\n>> this API right now, if you really want it done for every IO, make it\n>> part of the p2p submission process. You could even hide it behind a\n>> debug thing, if you like.\n> \n> There is no special p2p submission process. In the nvme-of case we are\n> using the existing process and with the code in blk-core it didn't\n> change it's process at all. Creating a helper will create one and I can\n> look at making a pci_p2pdma_submit_bio() for v6; but if the developer\n> screws up and still calls the regular submit_bio() things will only be\n> very subtly broken and that won't be obvious.\n\nI'm very sure that something that basic will be caught in review. I\ndon't care if you wrap the submission or just require the caller to\ncall some validity helper check first, fwiw.\n\nAnd I think we're done beating the dead horse at this point.", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.dk", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel-dk.20150623.gappssmtp.com\n\theader.i=@kernel-dk.20150623.gappssmtp.com\n\theader.b=\"Sm171yVX\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 425Gm335h2z9sBy\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 6 Sep 2018 07:18:59 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727611AbeIFBuw (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 5 Sep 2018 21:50:52 -0400", "from mail-it0-f65.google.com ([209.85.214.65]:35605 \"EHLO\n\tmail-it0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1727586AbeIFBuw (ORCPT\n\t<rfc822;linux-pci@vger.kernel.org>); Wed, 5 Sep 2018 21:50:52 -0400", "by mail-it0-f65.google.com with SMTP id 139-v6so11433491itf.0\n\tfor <linux-pci@vger.kernel.org>; Wed, 05 Sep 2018 14:18:52 -0700 (PDT)", "from [192.168.1.56] ([216.160.245.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tw64-v6sm1504239ita.7.2018.09.05.14.18.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 05 Sep 2018 14:18:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=kernel-dk.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=GwJUhWIlZtUps0pRNip9h+XIuNpEKn2US8IDJRkXeOA=;\n\tb=Sm171yVX29ibBhdwfvrMEUziKQRXaoDq6xUtF+ndCedzskbCeKjqaKU0rpkSaSyxN/\n\tIvRDb05WEkm6i8BVJNhJAtbksR++YVmpIxAOTf9kutMPVMatW/52G3e/5HztldPLDSVT\n\tvPLdlnubPS0ZVeJ57sxU9Vlsf99Li/5lmWKzpzF2I8iXb3soZAK6vhvDFq441au1IUt5\n\tcTuG/Csk2USHUdtOmsfj4KZ9ehvthTqXPVTfxQjWfl4Kkbz3Ya091tlp2OeXOc2rwSrI\n\tbfZSNGCuHipzYpXK1Y6O2XvKMo7RAVLjYYk3nUpS5k8QFk8F/rk5/HYH0kUad2RlO1wE\n\tS66g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=GwJUhWIlZtUps0pRNip9h+XIuNpEKn2US8IDJRkXeOA=;\n\tb=cX9Fgzrwfa69a99YqJOjtS7ltPCy6/y/ZNLG/g+HHk41uiD1RMMT3jTxXRWbFjDv3j\n\tqwAtkGM0I2WP1TSYo1HPZ2Q42ohLzggS/cuPANa2uhzGJx7950tfCrdJTAN1qIT/cKb9\n\tcrSybhlqKpzBAF6XxuTnXf9DY4AzW9AwZEqnLszoFLfig1miGUZtZtgcp84amRlaNZhN\n\txlNdyadA2uRKPArtUztN4Q/H8i0Amfe/WSZx3TfWjJA1QcN19K/hAdn4qiYAfQLZ07iD\n\tVJSvibtbmfQhGY3nfgKvK0M1Tb2ztznW8XIH9ZULoKn3m6AHfLBY0wtfcQTCwoC0vpE0\n\tfQ0Q==", "X-Gm-Message-State": "APzg51DM0H/SCW2kdppsx3XCWulljjmd7t+o5/lTt8nUIFloEYtKb6up\n\t/ZZvTcrhDAGe9slTTKJPKJRTqA==", "X-Google-Smtp-Source": "ANB0VdZ3rfD2uAhlKTGqzdCVuUnXC+Grr7YUAia9PhW7MKCXehLjWJ6HQN1FGZCyFn3sELLOSasOQQ==", "X-Received": "by 2002:a24:be8f:: with SMTP id\n\ti137-v6mr197941itf.61.1536182331670; \n\tWed, 05 Sep 2018 14:18:51 -0700 (PDT)", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "To": "Logan Gunthorpe <logang@deltatee.com>, Christoph Hellwig <hch@lst.de>", "Cc": "linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?=\n\t<jglisse@redhat.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, \n\t=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>", "References": "<20180830185352.3369-1-logang@deltatee.com>\n\t<20180830185352.3369-8-logang@deltatee.com>\n\t<b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk>\n\t<20180901082812.GB670@lst.de>\n\t<5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com>\n\t<59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk>\n\t<1b4283da-44df-4a02-3167-e295243cef78@deltatee.com>\n\t<09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk>\n\t<20180905195647.GA1626@lst.de>\n\t<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>\n\t<20180905201152.GA1893@lst.de>\n\t<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>\n\t<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>\n\t<e3ef26e6-6c8d-25b8-fa64-14594a51263c@deltatee.com>\n\t<3af4d1d4-da07-c0a6-8464-9ddc1378f2f4@kernel.dk>\n\t<f9e660cd-b597-bb6e-56a2-82fe71cb3649@deltatee.com>\n\t<34d9b2f7-9e6d-4a0a-77e5-ec0e99610f5c@kernel.dk>\n\t<c41c802c-9235-5383-2dfa-af9c1553f11b@deltatee.com>", "From": "Jens Axboe <axboe@kernel.dk>", "Message-ID": "<957591a9-3b9d-e730-9919-508349735db9@kernel.dk>", "Date": "Wed, 5 Sep 2018 15:18:48 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.0", "MIME-Version": "1.0", "In-Reply-To": "<c41c802c-9235-5383-2dfa-af9c1553f11b@deltatee.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1987935, "web_url": "http://patchwork.ozlabs.org/comment/1987935/", "msgid": "<20180910164144.GA24591@lst.de>", "list_archive_url": null, "date": "2018-09-10T16:41:44", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "content": "On Wed, Sep 05, 2018 at 03:03:18PM -0600, Logan Gunthorpe wrote:\n> There is no special p2p submission process. In the nvme-of case we are\n> using the existing process and with the code in blk-core it didn't\n> change it's process at all. Creating a helper will create one and I can\n> look at making a pci_p2pdma_submit_bio() for v6; but if the developer\n> screws up and still calls the regular submit_bio() things will only be\n> very subtly broken and that won't be obvious.\n\nI just saw you added that \"helper\" in your tree. Please don't, it is\na negative value add as it doesn't help anything with the checking.", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=lst.de" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 428DGw34RBz9s2P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 11 Sep 2018 02:37:28 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1728187AbeIJVcV (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tMon, 10 Sep 2018 17:32:21 -0400", "from verein.lst.de ([213.95.11.211]:38583 \"EHLO newverein.lst.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1728137AbeIJVcV (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tMon, 10 Sep 2018 17:32:21 -0400", "by newverein.lst.de (Postfix, from userid 2407)\n\tid 2A5D167357; Mon, 10 Sep 2018 18:41:44 +0200 (CEST)" ], "Date": "Mon, 10 Sep 2018 18:41:44 +0200", "From": "Christoph Hellwig <hch@lst.de>", "To": "Logan Gunthorpe <logang@deltatee.com>", "Cc": "Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,\n\tlinux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, \n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?iso-8859-1?q?J=E9r=F4me?=\n\tGlisse <jglisse@redhat.com>, Benjamin Herrenschmidt\n\t<benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, Christian\n\t=?iso-8859-1?q?K=F6nig?= <christian.koenig@amd.com>", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "Message-ID": "<20180910164144.GA24591@lst.de>", "References": "<20180905195647.GA1626@lst.de>\n\t<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>\n\t<20180905201152.GA1893@lst.de>\n\t<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>\n\t<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>\n\t<e3ef26e6-6c8d-25b8-fa64-14594a51263c@deltatee.com>\n\t<3af4d1d4-da07-c0a6-8464-9ddc1378f2f4@kernel.dk>\n\t<f9e660cd-b597-bb6e-56a2-82fe71cb3649@deltatee.com>\n\t<34d9b2f7-9e6d-4a0a-77e5-ec0e99610f5c@kernel.dk>\n\t<c41c802c-9235-5383-2dfa-af9c1553f11b@deltatee.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<c41c802c-9235-5383-2dfa-af9c1553f11b@deltatee.com>", "User-Agent": "Mutt/1.5.17 (2007-11-01)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1988004, "web_url": "http://patchwork.ozlabs.org/comment/1988004/", "msgid": "<fc4f14ae-9490-f901-a60c-2bd1522ef137@deltatee.com>", "list_archive_url": null, "date": "2018-09-10T18:11:01", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 70191, "url": "http://patchwork.ozlabs.org/api/people/70191/?format=api", "name": "Logan Gunthorpe", "email": "logang@deltatee.com" }, "content": "On 10/09/18 10:41 AM, Christoph Hellwig wrote:\n> On Wed, Sep 05, 2018 at 03:03:18PM -0600, Logan Gunthorpe wrote:\n>> There is no special p2p submission process. In the nvme-of case we are\n>> using the existing process and with the code in blk-core it didn't\n>> change it's process at all. Creating a helper will create one and I can\n>> look at making a pci_p2pdma_submit_bio() for v6; but if the developer\n>> screws up and still calls the regular submit_bio() things will only be\n>> very subtly broken and that won't be obvious.\n> \n> I just saw you added that \"helper\" in your tree. Please don't, it is\n> a negative value add as it doesn't help anything with the checking.\n\nAlright, so what's the consensus then? Just have a check in\nnvmet_bdev_execute_rw() to add REQ_NOMERGE when appropriate? Jens is\npretty dead set against adding to the common path.\n\nLogan\n\n\nP.S. Here's the commit in question for anyone else on the list:\n\nhttps://github.com/sbates130272/linux-p2pmem/commit/eeabe0bc94491d3eec4fe872274a9e3b4cdea538", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=deltatee.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 428GMb427Xz9s4s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 11 Sep 2018 04:11:39 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727701AbeIJXGu (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tMon, 10 Sep 2018 19:06:50 -0400", "from ale.deltatee.com ([207.54.116.67]:49796 \"EHLO\n\tale.deltatee.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1726657AbeIJXGu (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tMon, 10 Sep 2018 19:06:50 -0400", "from guinness.priv.deltatee.com ([172.16.1.162])\n\tby ale.deltatee.com with esmtp (Exim 4.89)\n\t(envelope-from <logang@deltatee.com>)\n\tid 1fzQeR-0002BG-NJ; Mon, 10 Sep 2018 12:11:08 -0600" ], "To": "Christoph Hellwig <hch@lst.de>", "Cc": "Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org,\n\tlinux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, \n\tlinux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, \n\tlinux-block@vger.kernel.org, Stephen Bates <sbates@raithlin.com>, \n\tKeith Busch <keith.busch@intel.com>, Sagi Grimberg <sagi@grimberg.me>,\n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>,\n\tDan Williams <dan.j.williams@intel.com>, =?utf-8?b?SsOpcsO0bWUgR2xp?=\n\t=?utf-8?q?sse?= <jglisse@redhat.com>,\n\tBenjamin Herrenschmidt <benh@kernel.crashing.org>, Alex Williamson\n\t<alex.williamson@redhat.com>, =?utf-8?q?Christian_K=C3=B6nig?=\n\t<christian.koenig@amd.com>", "References": "<20180905195647.GA1626@lst.de>\n\t<bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk>\n\t<20180905201152.GA1893@lst.de>\n\t<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>\n\t<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>\n\t<e3ef26e6-6c8d-25b8-fa64-14594a51263c@deltatee.com>\n\t<3af4d1d4-da07-c0a6-8464-9ddc1378f2f4@kernel.dk>\n\t<f9e660cd-b597-bb6e-56a2-82fe71cb3649@deltatee.com>\n\t<34d9b2f7-9e6d-4a0a-77e5-ec0e99610f5c@kernel.dk>\n\t<c41c802c-9235-5383-2dfa-af9c1553f11b@deltatee.com>\n\t<20180910164144.GA24591@lst.de>", "From": "Logan Gunthorpe <logang@deltatee.com>", "Message-ID": "<fc4f14ae-9490-f901-a60c-2bd1522ef137@deltatee.com>", "Date": "Mon, 10 Sep 2018 12:11:01 -0600", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.9.1", "MIME-Version": "1.0", "In-Reply-To": "<20180910164144.GA24591@lst.de>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-SA-Exim-Connect-IP": "172.16.1.162", "X-SA-Exim-Rcpt-To": "christian.koenig@amd.com, alex.williamson@redhat.com,\n\tbenh@kernel.crashing.org, jglisse@redhat.com,\n\tdan.j.williams@intel.com, maxg@mellanox.com, jgg@mellanox.com,\n\tbhelgaas@google.com, sagi@grimberg.me, keith.busch@intel.com,\n\tsbates@raithlin.com, linux-block@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org,\n\tlinux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, axboe@kernel.dk, hch@lst.de", "X-SA-Exim-Mail-From": "logang@deltatee.com", "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com", "X-Spam-Level": "", "X-Spam-Status": "No, score=-7.9 required=5.0 tests=ALL_TRUSTED,BAYES_00,\n\tGREYLIST_ISWHITE,\n\tLR_URI_NUMERIC_ENDING autolearn=ham autolearn_force=no\n\tversion=3.4.1", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "X-SA-Exim-Version": "4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000)", "X-SA-Exim-Scanned": "Yes (on ale.deltatee.com)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } }, { "id": 1988300, "web_url": "http://patchwork.ozlabs.org/comment/1988300/", "msgid": "<20180911071055.GA6609@lst.de>", "list_archive_url": null, "date": "2018-09-11T07:10:55", "subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "submitter": { "id": 82, "url": "http://patchwork.ozlabs.org/api/people/82/?format=api", "name": "Christoph Hellwig", "email": "hch@lst.de" }, "content": "On Mon, Sep 10, 2018 at 12:11:01PM -0600, Logan Gunthorpe wrote:\n> > I just saw you added that \"helper\" in your tree. Please don't, it is\n> > a negative value add as it doesn't help anything with the checking.\n> \n> Alright, so what's the consensus then? Just have a check in\n> nvmet_bdev_execute_rw() to add REQ_NOMERGE when appropriate?\n\nYes.", "headers": { "Return-Path": "<linux-pci-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=lst.de" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 428bYm3C6Yz9s4s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 11 Sep 2018 17:06:36 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1726441AbeIKME1 (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tTue, 11 Sep 2018 08:04:27 -0400", "from verein.lst.de ([213.95.11.211]:41259 \"EHLO newverein.lst.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1726325AbeIKME1 (ORCPT <rfc822;linux-pci@vger.kernel.org>);\n\tTue, 11 Sep 2018 08:04:27 -0400", "by newverein.lst.de (Postfix, from userid 2407)\n\tid 0DDEF68BF4; Tue, 11 Sep 2018 09:10:56 +0200 (CEST)" ], "Date": "Tue, 11 Sep 2018 09:10:55 +0200", "From": "Christoph Hellwig <hch@lst.de>", "To": "Logan Gunthorpe <logang@deltatee.com>", "Cc": "Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,\n\tlinux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, \n\tlinux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, \n\tlinux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates\n\t<sbates@raithlin.com>, Keith Busch <keith.busch@intel.com>,\n\tSagi Grimberg <sagi@grimberg.me>, \n\tBjorn Helgaas <bhelgaas@google.com>, Jason Gunthorpe <jgg@mellanox.com>, \n\tMax Gurtovoy <maxg@mellanox.com>, Dan Williams\n\t<dan.j.williams@intel.com>, =?iso-8859-1?q?J=E9r=F4me?=\n\tGlisse <jglisse@redhat.com>, Benjamin Herrenschmidt\n\t<benh@kernel.crashing.org>, \n\tAlex Williamson <alex.williamson@redhat.com>, Christian\n\t=?iso-8859-1?q?K=F6nig?= <christian.koenig@amd.com>", "Subject": "Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and\n\tcheck support for requests", "Message-ID": "<20180911071055.GA6609@lst.de>", "References": "<20180905201152.GA1893@lst.de>\n\t<eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com>\n\t<2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>\n\t<e3ef26e6-6c8d-25b8-fa64-14594a51263c@deltatee.com>\n\t<3af4d1d4-da07-c0a6-8464-9ddc1378f2f4@kernel.dk>\n\t<f9e660cd-b597-bb6e-56a2-82fe71cb3649@deltatee.com>\n\t<34d9b2f7-9e6d-4a0a-77e5-ec0e99610f5c@kernel.dk>\n\t<c41c802c-9235-5383-2dfa-af9c1553f11b@deltatee.com>\n\t<20180910164144.GA24591@lst.de>\n\t<fc4f14ae-9490-f901-a60c-2bd1522ef137@deltatee.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<fc4f14ae-9490-f901-a60c-2bd1522ef137@deltatee.com>", "User-Agent": "Mutt/1.5.17 (2007-11-01)", "Sender": "linux-pci-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pci.vger.kernel.org>", "X-Mailing-List": "linux-pci@vger.kernel.org" } } ]