Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/823509/?format=api
{ "id": 823509, "url": "http://patchwork.ozlabs.org/api/patches/823509/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/0ed87fbe-c250-23db-c321-c007f03d31d6@users.sourceforge.net/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<0ed87fbe-c250-23db-c321-c007f03d31d6@users.sourceforge.net>", "list_archive_url": null, "date": "2017-10-09T20:50:49", "name": "[2/3] net/atm: Improve a size determination in 12 functions", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "099e0a67a159591c72757f0d8ddc29b1dfcaffe1", "submitter": { "id": 65077, "url": "http://patchwork.ozlabs.org/api/people/65077/?format=api", "name": "SF Markus Elfring", "email": "elfring@users.sourceforge.net" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/0ed87fbe-c250-23db-c321-c007f03d31d6@users.sourceforge.net/mbox/", "series": [ { "id": 7242, "url": "http://patchwork.ozlabs.org/api/series/7242/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=7242", "date": "2017-10-09T20:48:11", "name": "net-ATM: Adjustments for several function implementations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/7242/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/823509/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/823509/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y9sq53mwzz9sRq\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 10 Oct 2017 07:51:29 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755310AbdJIUvQ (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 9 Oct 2017 16:51:16 -0400", "from mout.web.de ([212.227.17.11]:64959 \"EHLO mout.web.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1754506AbdJIUvO (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 9 Oct 2017 16:51:14 -0400", "from [192.168.1.2] ([77.181.206.143]) by smtp.web.de (mrweb103\n\t[213.165.67.124]) with ESMTPSA (Nemesis) id 0MNtLj-1duGMI0H3T-007YYj;\n\tMon, 09 Oct 2017 22:50:53 +0200" ], "Subject": "[PATCH 2/3] net/atm: Improve a size determination in 12 functions", "From": "SF Markus Elfring <elfring@users.sourceforge.net>", "To": "netdev@vger.kernel.org, Alexey Dobriyan <adobriyan@gmail.com>,\n\tAndrew Morton <akpm@linux-foundation.org>,\n\tAugusto Mecking Caringi <augustocaringi@gmail.com>,\n\tBhumika Goyal <bhumirks@gmail.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tDavid Windsor <dwindsor@gmail.com>,\n\tElena Reshetova <elena.reshetova@intel.com>,\n\tHans Liljestrand <ishkamiel@gmail.com>, Jarod Wilson <jarod@redhat.com>,\n\tJohannes Berg <johannes.berg@intel.com>,\n\tKees Cook <keescook@chromium.org>, Mitchell Blank Jr <mitch@sfgoth.com>,\n\tRoopa Prabhu <roopa@cumulusnetworks.com>", "Cc": "LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org", "References": "<10a92558-1105-b947-86a2-6ac763cca36d@users.sourceforge.net>", "Message-ID": "<0ed87fbe-c250-23db-c321-c007f03d31d6@users.sourceforge.net>", "Date": "Mon, 9 Oct 2017 22:50:49 +0200", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0", "MIME-Version": "1.0", "In-Reply-To": "<10a92558-1105-b947-86a2-6ac763cca36d@users.sourceforge.net>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-GB", "Content-Transfer-Encoding": "8bit", "X-Provags-ID": "V03:K0:OrKOdNqVlLUQUJVvVQzH0eLwQyW0ArKEveNmSAvCmI5oNwst/m/\n\tJ/dqIxDd3O1qX3JJei5ntoC4b46GQE7jU181bxwh5h3Js8TRS0e10pkExEHFl1d4w313NlM\n\td+UHc/BBpO9nPpLTrK0YF7RtjcCbTTEuEWQdOqRw3Ukh+LAHjGhh3pinKCJWsCp2MN0eaVB\n\t8wsLh9MNgw5/aEhtF+Brg==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:dOPFjPzQ80A=:vF/j5mINSvWlD7g2pU3/yP\n\tbMG84qfUu1HkWzH+lYwoIurqC7W6H6rJ5r+4307WHKEOHQGYrv472QwTLhRaERELdEKesc8NM\n\tSaOYhzLvT+SAQhdyofKhi82m/XUCQECa3u7pfnVMKOVB4D5Z8zwglIWetKeAnYx8wInhwynMY\n\txu+K2n/mJNRiMS7AhLjA++3P719k7M3T2bAlpDav7EPZMief/lxF1WfUw6U9qnTrU5b1O259q\n\t9e10jMCjvLyBBlTX2BiCOnAgng5EVw51eSSrahIPQulD4859bnLcOJ6Aj128FerTwfkv8Syfl\n\tpVLGCDVo7oqwXjGRNoX2/Z7bTgANQmwnu3xb+z2TbqxEEfYlSI+n6uBSCVYP+bS4cNVMSazjO\n\teoxbCV/QP97LSdcE8mChWWtn1fj4wc6qJPaCFm+q/v9frG93ltuTyjYOy1405jiPhimBtxRom\n\tOcjMHRV4yGZCabckjmJzAF84pKy/a4+psdQr8dhLI6rNa16LtPZStQEjPZFR0EVmGmQGGqujP\n\tLjqkzNR2ceFJWwO1QffqKeyWx7CbcD5vubi+++/i21cV7tqlQGFGH/HfUnK5SKwZD1hxdAhOt\n\tfDynRCMLxtS8rNKip8geALf8LcHgo58o3ZUsfgQ3HWWRJjAZv5lxGImM6kxTsgm579b3bHPFZ\n\tuw3zLKWjJQ98/u2thtU01jxDxmIlRfJ86bmufpiuKBxFXuP5JAWVXH3cOCyIj6Tn/emxNKaSB\n\ta4VKXpwiS24rLHxf/O7zeILalPh5nJGvUKjnsoXWCH9GR06kNbTH7ZHaAB+eCAKBF3CHeejtG\n\tC72ZqRgyBxfLaK62J3mzdOTkIcw8fderGz6HHjihijADMXAXGs=", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Markus Elfring <elfring@users.sourceforge.net>\nDate: Mon, 9 Oct 2017 22:00:19 +0200\n\nReplace the specification of data structures by pointer dereferences\nas the parameter for the operator \"sizeof\" to make the corresponding size\ndetermination a bit safer according to the Linux coding style convention.\n\nThis issue was detected by using the Coccinelle software.\n\nSigned-off-by: Markus Elfring <elfring@users.sourceforge.net>\n---\n net/atm/addr.c | 2 +-\n net/atm/br2684.c | 2 +-\n net/atm/clip.c | 4 ++--\n net/atm/lec.c | 6 +++---\n net/atm/mpc.c | 4 ++--\n net/atm/mpoa_caches.c | 4 ++--\n net/atm/signaling.c | 2 +-\n 7 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/net/atm/addr.c b/net/atm/addr.c\nindex dcda35c66f15..048e6d192818 100644\n--- a/net/atm/addr.c\n+++ b/net/atm/addr.c\n@@ -86,7 +86,7 @@ int atm_add_addr(struct atm_dev *dev, const struct sockaddr_atmsvc *addr,\n \t\t\treturn -EEXIST;\n \t\t}\n \t}\n-\tthis = kmalloc(sizeof(struct atm_dev_addr), GFP_ATOMIC);\n+\tthis = kmalloc(sizeof(*this), GFP_ATOMIC);\n \tif (!this) {\n \t\tspin_unlock_irqrestore(&dev->lock, flags);\n \t\treturn -ENOMEM;\ndiff --git a/net/atm/br2684.c b/net/atm/br2684.c\nindex 4e111196f902..f5b601c01f38 100644\n--- a/net/atm/br2684.c\n+++ b/net/atm/br2684.c\n@@ -538,7 +538,7 @@ static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg)\n \n \tif (copy_from_user(&be, arg, sizeof be))\n \t\treturn -EFAULT;\n-\tbrvcc = kzalloc(sizeof(struct br2684_vcc), GFP_KERNEL);\n+\tbrvcc = kzalloc(sizeof(*brvcc), GFP_KERNEL);\n \tif (!brvcc)\n \t\treturn -ENOMEM;\n \t/*\ndiff --git a/net/atm/clip.c b/net/atm/clip.c\nindex 65f706e4344c..041d519b8771 100644\n--- a/net/atm/clip.c\n+++ b/net/atm/clip.c\n@@ -60,7 +60,7 @@ static int to_atmarpd(enum atmarp_ctrl_type type, int itf, __be32 ip)\n \tskb = alloc_skb(sizeof(struct atmarp_ctrl), GFP_ATOMIC);\n \tif (!skb)\n \t\treturn -ENOMEM;\n-\tctrl = skb_put(skb, sizeof(struct atmarp_ctrl));\n+\tctrl = skb_put(skb, sizeof(*ctrl));\n \tctrl->type = type;\n \tctrl->itf_num = itf;\n \tctrl->ip = ip;\n@@ -418,7 +418,7 @@ static int clip_mkip(struct atm_vcc *vcc, int timeout)\n \n \tif (!vcc->push)\n \t\treturn -EBADFD;\n-\tclip_vcc = kmalloc(sizeof(struct clip_vcc), GFP_KERNEL);\n+\tclip_vcc = kmalloc(sizeof(*clip_vcc), GFP_KERNEL);\n \tif (!clip_vcc)\n \t\treturn -ENOMEM;\n \tpr_debug(\"%p vcc %p\\n\", clip_vcc, vcc);\ndiff --git a/net/atm/lec.c b/net/atm/lec.c\nindex f5be0b931978..74a794602412 100644\n--- a/net/atm/lec.c\n+++ b/net/atm/lec.c\n@@ -690,7 +690,7 @@ static int lec_vcc_attach(struct atm_vcc *vcc, void __user *arg)\n \tif (ioc_data.dev_num < 0 || ioc_data.dev_num >= MAX_LEC_ITF ||\n \t !dev_lec[ioc_data.dev_num])\n \t\treturn -EINVAL;\n-\tvpriv = kmalloc(sizeof(struct lec_vcc_priv), GFP_KERNEL);\n+\tvpriv = kmalloc(sizeof(*vpriv), GFP_KERNEL);\n \tif (!vpriv)\n \t\treturn -ENOMEM;\n \tvpriv->xoff = 0;\n@@ -1552,7 +1552,7 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,\n {\n \tstruct lec_arp_table *to_return;\n \n-\tto_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC);\n+\tto_return = kzalloc(sizeof(*to_return), GFP_ATOMIC);\n \tif (!to_return)\n \t\treturn NULL;\n \n@@ -2155,7 +2155,7 @@ static int lec_mcast_make(struct lec_priv *priv, struct atm_vcc *vcc)\n \tstruct lec_vcc_priv *vpriv;\n \tint err = 0;\n \n-\tvpriv = kmalloc(sizeof(struct lec_vcc_priv), GFP_KERNEL);\n+\tvpriv = kmalloc(sizeof(*vpriv), GFP_KERNEL);\n \tif (!vpriv)\n \t\treturn -ENOMEM;\n \tvpriv->xoff = 0;\ndiff --git a/net/atm/mpc.c b/net/atm/mpc.c\nindex dd57d05b5dcc..d6729d797107 100644\n--- a/net/atm/mpc.c\n+++ b/net/atm/mpc.c\n@@ -183,7 +183,7 @@ struct atm_mpoa_qos *atm_mpoa_add_qos(__be32 dst_ip, struct atm_qos *qos)\n \t\treturn entry;\n \t}\n \n-\tentry = kmalloc(sizeof(struct atm_mpoa_qos), GFP_KERNEL);\n+\tentry = kmalloc(sizeof(*entry), GFP_KERNEL);\n \tif (!entry)\n \t\treturn entry;\n \n@@ -279,7 +279,7 @@ static struct mpoa_client *alloc_mpc(void)\n {\n \tstruct mpoa_client *mpc;\n \n-\tmpc = kzalloc(sizeof(struct mpoa_client), GFP_KERNEL);\n+\tmpc = kzalloc(sizeof(*mpc), GFP_KERNEL);\n \tif (mpc == NULL)\n \t\treturn NULL;\n \trwlock_init(&mpc->ingress_lock);\ndiff --git a/net/atm/mpoa_caches.c b/net/atm/mpoa_caches.c\nindex 7495b42d59eb..23f36e5a20ee 100644\n--- a/net/atm/mpoa_caches.c\n+++ b/net/atm/mpoa_caches.c\n@@ -96,7 +96,7 @@ static in_cache_entry *in_cache_get_by_vcc(struct atm_vcc *vcc,\n static in_cache_entry *in_cache_add_entry(__be32 dst_ip,\n \t\t\t\t\t struct mpoa_client *client)\n {\n-\tin_cache_entry *entry = kzalloc(sizeof(in_cache_entry), GFP_KERNEL);\n+\tin_cache_entry *entry = kzalloc(sizeof(*entry), GFP_KERNEL);\n \n \tif (!entry)\n \t\treturn NULL;\n@@ -456,7 +456,7 @@ static void eg_cache_remove_entry(eg_cache_entry *entry,\n static eg_cache_entry *eg_cache_add_entry(struct k_message *msg,\n \t\t\t\t\t struct mpoa_client *client)\n {\n-\teg_cache_entry *entry = kzalloc(sizeof(eg_cache_entry), GFP_KERNEL);\n+\teg_cache_entry *entry = kzalloc(sizeof(*entry), GFP_KERNEL);\n \n \tif (!entry)\n \t\treturn NULL;\ndiff --git a/net/atm/signaling.c b/net/atm/signaling.c\nindex 0a20f6e953ac..225234f5cb5f 100644\n--- a/net/atm/signaling.c\n+++ b/net/atm/signaling.c\n@@ -150,7 +150,7 @@ void sigd_enq2(struct atm_vcc *vcc, enum atmsvc_msg_type type,\n \tpr_debug(\"%d (0x%p)\\n\", (int)type, vcc);\n \twhile (!(skb = alloc_skb(sizeof(struct atmsvc_msg), GFP_KERNEL)))\n \t\tschedule();\n-\tmsg = skb_put_zero(skb, sizeof(struct atmsvc_msg));\n+\tmsg = skb_put_zero(skb, sizeof(*msg));\n \tmsg->type = type;\n \t*(struct atm_vcc **) &msg->vcc = vcc;\n \t*(struct atm_vcc **) &msg->listen_vcc = listen_vcc;\n", "prefixes": [ "2/3" ] }