diff mbox series

[1/1,Jammy,linux-realtime] UBUNTU: [Packaging] Change do_extras_package to true and create dependency on linux-modules-extra

Message ID ffa40a1c62414bd8e581b988b25bc0225e32265e.1637702476.git.joseph.salisbury@canonical.com
State New
Headers show
Series UBUNTU: [Packaging] Fix for LP#1950968 | expand

Commit Message

Joseph Salisbury Nov. 23, 2021, 9:31 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1950968

Boot tests are failing for the linux-realtime kernel when testing specific
hardware in the lab.  The testing hardware requires the qede driver for
networking.  This driver is included in the linux-modules-extra package.

Create dependency on the modules-extra package, which is already done for
the generic kernel.

Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
---
 debian.realtime/rules.d/amd64.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.32.0

Comments

Krzysztof Kozlowski Nov. 24, 2021, 8:58 a.m. UTC | #1
On 23/11/2021 22:31, Joseph Salisbury wrote:
> BugLink: https://bugs.launchpad.net/bugs/1950968
> 
> Boot tests are failing for the linux-realtime kernel when testing specific
> hardware in the lab.  The testing hardware requires the qede driver for
> networking.  This driver is included in the linux-modules-extra package.

Please mention the hardware platform which is failing.

> 
> Create dependency on the modules-extra package, which is already done for
> the generic kernel.
> 
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> ---
>  debian.realtime/rules.d/amd64.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.realtime/rules.d/amd64.mk b/debian.realtime/rules.d/amd64.mk
> index eb3b563fc728..7b2794a3e079 100644
> --- a/debian.realtime/rules.d/amd64.mk
> +++ b/debian.realtime/rules.d/amd64.mk
> @@ -16,7 +16,7 @@ do_tools_bpftool = true
>  do_tools_x86	= true
>  do_tools_hyperv	= true
>  do_tools_host = false
> -do_extras_package = false
> +do_extras_package = true

I am not sure how does this solve arm64 kernel problem...

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 24, 2021, 6:20 p.m. UTC | #2
On 24/11/2021 17:35, Joseph Salisbury wrote:
> BugLink: https://bugs.launchpad.net/bugs/1950968
> 
> Boot tests are failing for the linux-realtime kernel when testing on arm64
> Cavium ThunderX2 hardware in the lab.  The testing hardware requires the qede
> driver for QLogic FastLinQ QL41000 Series network cards.
> This driver is included in the linux-modules-extra package.
> 
> A new dependency was created on the linux-modules-extra package in
> linux-meta-realtime.  See commit: ("UBUNTU: [Packaging] Add
>  dependency for linux-modules-extra in debian control file") in that
> repo.
> 
> Because of this new dependancy, we need to build the linux-modules-extra
> package for amd64 in addition to arm64.


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 24, 2021, 6:21 p.m. UTC | #3
On 23/11/2021 22:31, Joseph Salisbury wrote:
> BugLink: https://bugs.launchpad.net/bugs/1950968
> 
> Boot tests are failing for the linux-realtime kernel when testing specific
> hardware in the lab.  The testing hardware requires the qede driver for
> networking.  This driver is included in the linux-modules-extra package.
> 
> Create dependency on the modules-extra package, which is already done for
> the generic kernel.
> 
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> ---
>  debian.realtime/rules.d/amd64.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

There is a v2, so explicitly NAK this one.


Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 25, 2021, 8 a.m. UTC | #4
On 24/11/2021 17:35, Joseph Salisbury wrote:
> BugLink: https://bugs.launchpad.net/bugs/1950968
> 
> Boot tests are failing for the linux-realtime kernel when testing on arm64
> Cavium ThunderX2 hardware in the lab.  The testing hardware requires the qede
> driver for QLogic FastLinQ QL41000 Series network cards.
> This driver is included in the linux-modules-extra package.
> 
> A new dependency was created on the linux-modules-extra package in
> linux-meta-realtime.  See commit: ("UBUNTU: [Packaging] Add
>  dependency for linux-modules-extra in debian control file") in that
> repo.
> 
> Because of this new dependancy, we need to build the linux-modules-extra
> package for amd64 in addition to arm64.
> 
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> ---
>  debian.realtime/rules.d/amd64.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/debian.realtime/rules.d/amd64.mk b/debian.realtime/rules.d/amd64.mk
index eb3b563fc728..7b2794a3e079 100644
--- a/debian.realtime/rules.d/amd64.mk
+++ b/debian.realtime/rules.d/amd64.mk
@@ -16,7 +16,7 @@  do_tools_bpftool = true
 do_tools_x86	= true
 do_tools_hyperv	= true
 do_tools_host = false
-do_extras_package = false
+do_extras_package = true
 do_tools_common = false
 do_tools_acpidbg = false
 do_zfs		= false