mbox

[Quantal,Pull,Request] SAUCE: UBUNTU: (upstream) Modify UEFI anti-bricking code

Message ID 87fvvnafgr.fsf@canonical.com
State New
Headers show

Pull-request

git://kernel.ubuntu.com/henrix/ubuntu-quantal.git master-next

Message

Luis Henriques July 9, 2013, 4:03 p.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1199401

This set of patches will bring upstream commit f8b8404 "Modify UEFI
anti-bricking code" into the Quantal kernel.  All the required
dependencies have also been pulled in, along with a fix to a buffer
memory allocation.

Most of the backports have been based on Ben Hutchings' backports to
upstream 3.2 kernel.

A good amount of testing has already done by Colin on 5 different UEFI
systems, but some more testing/review is probably required.

The following changes since commit 9eb23a9a671de0e5d51b7605da00e9caaf5bed5c:

  UBUNTU: Ubuntu-3.5.0-37.58 (2013-07-08 14:22:53 -0700)

are available in the git repository at:

  git://kernel.ubuntu.com/henrix/ubuntu-quantal.git master-next

for you to fetch changes up to 73315cc8d3fff99f32d76e6431d8323030139902:

  UBUNTU: SAUCE: (upstream) x86/efi: Fix dummy variable buffer allocation (2013-07-09 16:39:59 +0100)

----------------------------------------------------------------
Ben Hutchings (1):
      UBUNTU: SAUCE: (upstream) x86/efi: Fix dummy variable buffer allocation

Matt Fleming (1):
      UBUNTU: SAUCE: (upstream) x86, efivars: firmware bug workarounds should be in platform code

Matthew Garrett (2):
      UBUNTU: SAUCE: (upstream) efi: be more paranoid about available space when creating variables
      UBUNTU: SAUCE: (upstream) Modify UEFI anti-bricking code

Richard Weinberger (2):
      UBUNTU: SAUCE: (upstream) x86,efi: Check max_size only if it is non-zero.
      UBUNTU: SAUCE: (upstream) x86,efi: Implement efi_no_storage_paranoia parameter

Seiji Aguchi (2):
      UBUNTU: SAUCE: (upstream) efi_pstore: Check remaining space with QueryVariableInfo() before writing data
      UBUNTU: SAUCE: (upstream) efivars: Disable external interrupt while holding efivars->lock

Sergey Vlasov (1):
      UBUNTU: SAUCE: (upstream) efi: Export efi_query_variable_store() for efivars.ko

 Documentation/kernel-parameters.txt |   6 ++
 arch/x86/platform/efi/efi.c         | 105 ++++++++++++++++++++++++++++++
 drivers/firmware/efivars.c          | 125 ++++++++++++++++++++++++++++--------
 include/linux/efi.h                 |   8 +++
 4 files changed, 219 insertions(+), 25 deletions(-)

Comments

Tim Gardner July 9, 2013, 7:40 p.m. UTC | #1
On 07/09/2013 10:03 AM, Luis Henriques wrote:
> BugLink: http://bugs.launchpad.net/bugs/1199401
> 
> This set of patches will bring upstream commit f8b8404 "Modify UEFI
> anti-bricking code" into the Quantal kernel.  All the required
> dependencies have also been pulled in, along with a fix to a buffer
> memory allocation.
> 
> Most of the backports have been based on Ben Hutchings' backports to
> upstream 3.2 kernel.
> 
> A good amount of testing has already done by Colin on 5 different UEFI
> systems, but some more testing/review is probably required.
> 

I'm curious why you aren't running this through 3.5.y stable ?
Luis Henriques July 10, 2013, 9:22 a.m. UTC | #2
Tim Gardner <tim.gardner@canonical.com> writes:

> On 07/09/2013 10:03 AM, Luis Henriques wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1199401
>> 
>> This set of patches will bring upstream commit f8b8404 "Modify UEFI
>> anti-bricking code" into the Quantal kernel.  All the required
>> dependencies have also been pulled in, along with a fix to a buffer
>> memory allocation.
>> 
>> Most of the backports have been based on Ben Hutchings' backports to
>> upstream 3.2 kernel.
>> 
>> A good amount of testing has already done by Colin on 5 different UEFI
>> systems, but some more testing/review is probably required.
>> 
>
> I'm curious why you aren't running this through 3.5.y stable ?

The plan is to include them in 3.5.y stable as well.  We just wanted
to make sure these patches wouldn't hit Quantal only on the SRU cycle
immediately before the next point release.

Cheers,
Tim Gardner July 10, 2013, 12:20 p.m. UTC | #3
On 07/10/2013 03:22 AM, Luis Henriques wrote:
> Tim Gardner <tim.gardner@canonical.com> writes:
> 
>> On 07/09/2013 10:03 AM, Luis Henriques wrote:
>>> BugLink: http://bugs.launchpad.net/bugs/1199401
>>>
>>> This set of patches will bring upstream commit f8b8404 "Modify UEFI
>>> anti-bricking code" into the Quantal kernel.  All the required
>>> dependencies have also been pulled in, along with a fix to a buffer
>>> memory allocation.
>>>
>>> Most of the backports have been based on Ben Hutchings' backports to
>>> upstream 3.2 kernel.
>>>
>>> A good amount of testing has already done by Colin on 5 different UEFI
>>> systems, but some more testing/review is probably required.
>>>
>>
>> I'm curious why you aren't running this through 3.5.y stable ?
> 
> The plan is to include them in 3.5.y stable as well.  We just wanted
> to make sure these patches wouldn't hit Quantal only on the SRU cycle
> immediately before the next point release.
> 
> Cheers,
> 

If we accept these patches into Quantal now, then we lose out on the
wider community review which, given the size and complexity of the patch
set, I would very much prefer.

The only time I think it is appropriate to micro-manage patches with
respect to the SRU cycle is when a point release is dependent upon them.
This is not such a case.

rtg