Message ID | 55DDEB0E.4070203@canonical.com |
---|---|
State | New |
Headers | show |
On 08/26/2015 10:36 AM, Simon Fels wrote:
> https://github.com/ubuntu-phonedations/linux mako-bluetooth
The patch set looks pretty good in general, though there are a few
things missing.
'hid: Backport hid-generic driver' has no provenance or history. I would
like the commit log to contain a proper S-O-B and a bit of history as to
where this patch originated, e.g., back ported from Linus' tree from
which commit(s).
'crypto: add CMAC support to CryptoAPI' and 'crypto: af_alg - properly
label AF_ALG socket' have no history.
'UBUNTU: backports: import HCI SMD driver' needs some provenance. Where
did that code come from ?
Finally, all of these patches need an SRU bug link. In the bug I expect
to find some notes about regression testing, though that should be
relatively easy since this kernel is destined for a single device.
rtg
On 26.08.2015 21:50, Tim Gardner wrote: > On 08/26/2015 10:36 AM, Simon Fels wrote: >> https://github.com/ubuntu-phonedations/linux mako-bluetooth > > The patch set looks pretty good in general, though there are a few > things missing. > > 'hid: Backport hid-generic driver' has no provenance or history. I would > like the commit log to contain a proper S-O-B and a bit of history as to > where this patch originated, e.g., back ported from Linus' tree from > which commit(s). > > 'crypto: add CMAC support to CryptoAPI' and 'crypto: af_alg - properly > label AF_ALG socket' have no history. > > 'UBUNTU: backports: import HCI SMD driver' needs some provenance. Where > did that code come from ? > > Finally, all of these patches need an SRU bug link. In the bug I expect > to find some notes about regression testing, though that should be > relatively easy since this kernel is destined for a single device. All those things should be fixed now. regards, Simon
On 08/27/2015 02:23 AM, Simon Fels wrote: > On 26.08.2015 21:50, Tim Gardner wrote: >> On 08/26/2015 10:36 AM, Simon Fels wrote: >>> https://github.com/ubuntu-phonedations/linux mako-bluetooth >> >> The patch set looks pretty good in general, though there are a few >> things missing. >> >> 'hid: Backport hid-generic driver' has no provenance or history. I would >> like the commit log to contain a proper S-O-B and a bit of history as to >> where this patch originated, e.g., back ported from Linus' tree from >> which commit(s). >> >> 'crypto: add CMAC support to CryptoAPI' and 'crypto: af_alg - properly >> label AF_ALG socket' have no history. >> >> 'UBUNTU: backports: import HCI SMD driver' needs some provenance. Where >> did that code come from ? >> >> Finally, all of these patches need an SRU bug link. In the bug I expect >> to find some notes about regression testing, though that should be >> relatively easy since this kernel is destined for a single device. > > All those things should be fixed now. > > regards, > Simon > Merged and pushed. The administrative changes to commit logs look fine. Test plan also looks good. Uploaded to https://launchpad.net/~canonical-kernel-team/+archive/ubuntu/ppa