[V2,j/linux-raspi,1/2] UBUNTU: [Packaging] Remove old snapcraft.yaml

This file was added more than a decade ago, and is no longer working.

Signed-off-by: Masahiro Yamada <masahiro.yamada@canonical.com>
---
 snapcraft.yaml | 36 ------------------------------------
 1 file changed, 36 deletions(-)
 delete mode 100644 snapcraft.yaml

On 16.01.24 22:54, Masahiro Yamada wrote:
> This file was added more than a decade ago, and is no longer working.
> 
> Signed-off-by: Masahiro Yamada <masahiro.yamada@canonical.com>
> ---

Rejected for the following reasons:
- If there is more than one patch a submission should have a cover email 
to group things together.

-Stefan
>   snapcraft.yaml | 36 ------------------------------------
>   1 file changed, 36 deletions(-)
>   delete mode 100644 snapcraft.yaml
> 
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> deleted file mode 100644
> index 2452c4031066..000000000000
> --- a/snapcraft.yaml
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -name: pc-kernel
> -version: null
> -version-script: |
> -    . debian/debian.env
> -    dpkg-parsechangelog -l $DEBIAN/changelog -S version
> -summary: The Ubuntu generic Linux kernel
> -description: This Ubuntu generic Linux kernel
> -grade: stable
> -confinement: strict
> -type: kernel
> -
> -parts:
> -  kernel:
> -    plugin: kernel
> -    source: .
> -    source-type: git
> -    kconfigflavour: generic
> -    kconfigs:
> -      - CONFIG_DEBUG_INFO=n
> -    override-build: |
> -      cp debian/scripts/retpoline-extract-one \
> -        $SNAPCRAFT_PART_BUILD/scripts/ubuntu-retpoline-extract-one
> -      snapcraftctl build
> -    kernel-with-firmware: false
> -  firmware:
> -    plugin: nil
> -    stage-packages:
> -      - linux-firmware
> -    organize:
> -      lib/firmware: firmware
> -    prime:
> -      - -usr
> -      - -lib
> -    build-packages:
> -      - cpio
> -      - libssl-dev

On Wed, Jan 17, 2024 at 5:07 PM Stefan Bader <stefan.bader@canonical.com> wrote:
>
> On 16.01.24 22:54, Masahiro Yamada wrote:
> > This file was added more than a decade ago, and is no longer working.
> >
> > Signed-off-by: Masahiro Yamada <masahiro.yamada@canonical.com>
> > ---
>
> Rejected for the following reasons:
> - If there is more than one patch a submission should have a cover email
> to group things together.



[COVER LETTER]

----------------------------->8------------------------------
1/2 removes non-functional old snapcraft.yaml.

2/2 adds snapcraft.yaml that creates the pi-kernel Ubuntu Core 22
----------------------------->8------------------------------











> -Stefan
> >   snapcraft.yaml | 36 ------------------------------------
> >   1 file changed, 36 deletions(-)
> >   delete mode 100644 snapcraft.yaml
> >
> > diff --git a/snapcraft.yaml b/snapcraft.yaml
> > deleted file mode 100644
> > index 2452c4031066..000000000000
> > --- a/snapcraft.yaml
> > +++ /dev/null
> > @@ -1,36 +0,0 @@
> > -name: pc-kernel
> > -version: null
> > -version-script: |
> > -    . debian/debian.env
> > -    dpkg-parsechangelog -l $DEBIAN/changelog -S version
> > -summary: The Ubuntu generic Linux kernel
> > -description: This Ubuntu generic Linux kernel
> > -grade: stable
> > -confinement: strict
> > -type: kernel
> > -
> > -parts:
> > -  kernel:
> > -    plugin: kernel
> > -    source: .
> > -    source-type: git
> > -    kconfigflavour: generic
> > -    kconfigs:
> > -      - CONFIG_DEBUG_INFO=n
> > -    override-build: |
> > -      cp debian/scripts/retpoline-extract-one \
> > -        $SNAPCRAFT_PART_BUILD/scripts/ubuntu-retpoline-extract-one
> > -      snapcraftctl build
> > -    kernel-with-firmware: false
> > -  firmware:
> > -    plugin: nil
> > -    stage-packages:
> > -      - linux-firmware
> > -    organize:
> > -      lib/firmware: firmware
> > -    prime:
> > -      - -usr
> > -      - -lib
> > -    build-packages:
> > -      - cpio
> > -      - libssl-dev
>
> --
> - Stefan
>

On Wed, Jan 17, 2024 at 6:16 PM Masahiro Yamada
<masahiro.yamada@canonical.com> wrote:
>
> On Wed, Jan 17, 2024 at 5:07 PM Stefan Bader <stefan.bader@canonical.com> wrote:
> >
> > On 16.01.24 22:54, Masahiro Yamada wrote:
> > > This file was added more than a decade ago, and is no longer working.
> > >
> > > Signed-off-by: Masahiro Yamada <masahiro.yamada@canonical.com>
> > > ---
> >
> > Rejected for the following reasons:
> > - If there is more than one patch a submission should have a cover email
> > to group things together.
>
>
>
> [COVER LETTER]
>
> ----------------------------->8------------------------------
> 1/2 removes non-functional old snapcraft.yaml.
>
> 2/2 adds snapcraft.yaml that creates the pi-kernel Ubuntu Core 22
> ----------------------------->8------------------------------
>
>
>



I do not think it is worth resending,
since it is obvious.

On 17.01.24 10:28, Masahiro Yamada wrote:
> On Wed, Jan 17, 2024 at 6:16 PM Masahiro Yamada
> <masahiro.yamada@canonical.com> wrote:
>>
>> On Wed, Jan 17, 2024 at 5:07 PM Stefan Bader <stefan.bader@canonical.com> wrote:
>>>
>>> On 16.01.24 22:54, Masahiro Yamada wrote:
>>>> This file was added more than a decade ago, and is no longer working.
>>>>
>>>> Signed-off-by: Masahiro Yamada <masahiro.yamada@canonical.com>
>>>> ---
>>>
>>> Rejected for the following reasons:
>>> - If there is more than one patch a submission should have a cover email
>>> to group things together.
               ^! This is not about what is obvious or not
>>
>>
>>
>> [COVER LETTER]
>>
>> ----------------------------->8------------------------------
>> 1/2 removes non-functional old snapcraft.yaml.
>>
>> 2/2 adds snapcraft.yaml that creates the pi-kernel Ubuntu Core 22
>> ----------------------------->8------------------------------
>>
>>
>>
> 
> 
> 
> I do not think it is worth resending,
> since it is obvious.

This submission will no longer be considered because it has been NACKed.