diff mbox series

[noble] UBUNTU: SAUCE: remove unneeded trailing slash for INSTALL_MOD_PATH

Message ID 20231204015041.2034201-1-masahiro.yamada@canonical.com
State New
Headers show
Series [noble] UBUNTU: SAUCE: remove unneeded trailing slash for INSTALL_MOD_PATH | expand

Commit Message

Masahiro Yamada Dec. 4, 2023, 1:50 a.m. UTC
You can see that the trailing slash is unneeded from the code in
the top Makefile:

  MODLIB  = $(INSTALL_MOD_PATH)/lib/modules/$(KERNELRELEASE)

Signed-off-by: Masahiro Yamada <masahiro.yamada@canonical.com>
---

 debian/rules.d/2-binary-arch.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Agathe Porte Dec. 4, 2023, 10:13 a.m. UTC | #1
2023-12-04 02:51 CET, Masahiro Yamada:
> You can see that the trailing slash is unneeded from the code in
> the top Makefile:
> 
>   MODLIB  = $(INSTALL_MOD_PATH)/lib/modules/$(KERNELRELEASE)
> 
> Signed-off-by: Masahiro Yamada <masahiro.yamada@canonical.com>
> ---
> 
>  debian/rules.d/2-binary-arch.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index b281428d3462..a0a3fd1fe9ad 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -175,7 +175,7 @@ ifeq ($(no_dumpfile),)
>  endif
>  
>  	$(build_cd) $(kmake) $(build_O) $(conc_level) modules_install $(vdso) \
> -		INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=$(pkgdir)/
> +		INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=$(pkgdir)
>  
>  	#
>  	# Build module blacklists:

Acked-by: Agathe Porte <agathe.porte@canonical.com>
Tim Gardner Dec. 4, 2023, 4:20 p.m. UTC | #2
On 12/3/23 6:50 PM, Masahiro Yamada wrote:
> You can see that the trailing slash is unneeded from the code in
> the top Makefile:
> 
>    MODLIB  = $(INSTALL_MOD_PATH)/lib/modules/$(KERNELRELEASE)
> 
> Signed-off-by: Masahiro Yamada <masahiro.yamada@canonical.com>
> ---
> 
>   debian/rules.d/2-binary-arch.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index b281428d3462..a0a3fd1fe9ad 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -175,7 +175,7 @@ ifeq ($(no_dumpfile),)
>   endif
>   
>   	$(build_cd) $(kmake) $(build_O) $(conc_level) modules_install $(vdso) \
> -		INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=$(pkgdir)/
> +		INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=$(pkgdir)
>   
>   	#
>   	# Build module blacklists:
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Dimitri John Ledkov Dec. 4, 2023, 11:59 p.m. UTC | #3
On Mon, 4 Dec 2023 at 01:51, Masahiro Yamada
<masahiro.yamada@canonical.com> wrote:
>
> You can see that the trailing slash is unneeded from the code in
> the top Makefile:
>
>   MODLIB  = $(INSTALL_MOD_PATH)/lib/modules/$(KERNELRELEASE)
>
> Signed-off-by: Masahiro Yamada <masahiro.yamada@canonical.com>
> ---
>
>  debian/rules.d/2-binary-arch.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index b281428d3462..a0a3fd1fe9ad 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -175,7 +175,7 @@ ifeq ($(no_dumpfile),)
>  endif
>
>         $(build_cd) $(kmake) $(build_O) $(conc_level) modules_install $(vdso) \
> -               INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=$(pkgdir)/
> +               INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=$(pkgdir)
>
>         #
>         # Build module blacklists:
> --
> 2.40.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff mbox series

Patch

diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
index b281428d3462..a0a3fd1fe9ad 100644
--- a/debian/rules.d/2-binary-arch.mk
+++ b/debian/rules.d/2-binary-arch.mk
@@ -175,7 +175,7 @@  ifeq ($(no_dumpfile),)
 endif
 
 	$(build_cd) $(kmake) $(build_O) $(conc_level) modules_install $(vdso) \
-		INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=$(pkgdir)/
+		INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=$(pkgdir)
 
 	#
 	# Build module blacklists: