diff mbox series

[SRU,Focal/Jammy/Lunar,2/3] net/sched: cls_fw: No longer copy tcf_result on update to avoid use-after-free

Message ID 20230816221431.39612-3-yuxuan.luo@canonical.com
State New
Headers show
Series CVE-2023-4128 | expand

Commit Message

Yuxuan Luo Aug. 16, 2023, 10:14 p.m. UTC 
From: valis <sec@valis.email>

When fw_change() is called on an existing filter, the whole
tcf_result struct is always copied into the new instance of the filter.

This causes a problem when updating a filter bound to a class,
as tcf_unbind_filter() is always called on the old instance in the
success path, decreasing filter_cnt of the still referenced class
and allowing it to be deleted, leading to a use-after-free.

Fix this by no longer copying the tcf_result struct from the old filter.

Fixes: e35a8ee5993b ("net: sched: fw use RCU")
Reported-by: valis <sec@valis.email>
Reported-by: Bing-Jhong Billy Jheng <billy@starlabs.sg>
Signed-off-by: valis <sec@valis.email>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Victor Nogueira <victor@mojatatu.com>
Reviewed-by: Pedro Tammela <pctammela@mojatatu.com>
Reviewed-by: M A Ramdhan <ramdhan@starlabs.sg>
Link: https://lore.kernel.org/r/20230729123202.72406-3-jhs@mojatatu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
(cherry picked from commit 76e42ae831991c828cffa8c37736ebfb831ad5ec)
CVE-2023-4128
Signed-off-by: Yuxuan Luo <yuxuan.luo@canonical.com>
---
 net/sched/cls_fw.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox series

Patch

diff --git a/net/sched/cls_fw.c b/net/sched/cls_fw.c
index 8641f80593179..c49d6af0e0480 100644
--- a/net/sched/cls_fw.c
+++ b/net/sched/cls_fw.c
@@ -267,7 +267,6 @@  static int fw_change(struct net *net, struct sk_buff *in_skb,
 			return -ENOBUFS;
 
 		fnew->id = f->id;
-		fnew->res = f->res;
 		fnew->ifindex = f->ifindex;
 		fnew->tp = f->tp;