diff mbox series

[SRU,Jammy:linux-intel-iotg,1/1] UBUNTU: SAUCE: (no-up) drm/i915/display : Remove support for interlace mode

Message ID 20230811061923.777766-2-jianhui.lee@canonical.com
State New
Headers show
Series fix screen flickering in multiple monitors with mirror mode output | expand

Commit Message

Jian Hui Lee Aug. 11, 2023, 6:19 a.m. UTC 
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

BugLink: https://bugs.launchpad.net/bugs/2031057

There are multiple panels with which Interlace mode is seen to cause
flickering (interlacing artifacts) with different platforms.

The issue is seen with both HDMI, DP with CML, CFL, ICL, EHL with
different display models from Acer, Benq, Dell etc.
There are some models where the issue is not seen with same setup.

Due to this, cases where multiple display are configured in clone mode,
sometimes interlaced mode gets picked up in one of the displays
and flickers are seen.

Since its difficult to pin point if issue is due to the HW or due to
panels, removing interlace mode for DP and HDMI till this is
root caused.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8395

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230614040749.1702127-1-ankit.k.nautiyal@intel.com
Signed-off-by: Jian Hui Lee <jianhui.lee@canonical.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c   | 2 --
 drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ---
 2 files changed, 5 deletions(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 74c832020390..1eecbaacb236 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4845,8 +4845,6 @@  intel_dp_init_connector(struct intel_digital_port *dig_port,
 	drm_connector_init(dev, connector, &intel_dp_connector_funcs, type);
 	drm_connector_helper_add(connector, &intel_dp_connector_helper_funcs);
 
-	if (!HAS_GMCH(dev_priv) && DISPLAY_VER(dev_priv) < 12)
-		connector->interlace_allowed = true;
 	connector->doublescan_allowed = 0;
 
 	intel_connector->polled = DRM_CONNECTOR_POLL_HPD;
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 999c1821d750..f70310fd44aa 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -2889,9 +2889,6 @@  void intel_hdmi_init_connector(struct intel_digital_port *dig_port,
 				    ddc);
 	drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);
 
-	if (DISPLAY_VER(dev_priv) < 12)
-		connector->interlace_allowed = true;
-
 	connector->doublescan_allowed = 0;
 
 	connector->stereo_allowed = true;