Message ID | 20230606230120.407292-5-witu@nvidia.com |
---|---|
State | New |
Headers | show
Return-Path: <kernel-team-bounces@lists.ubuntu.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=QZdtaYxY; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QbQw304XMz20Q8 for <incoming@patchwork.ozlabs.org>; Wed, 7 Jun 2023 09:01:55 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from <kernel-team-bounces@lists.ubuntu.com>) id 1q6fgS-0001lz-UV; Tue, 06 Jun 2023 23:01:48 +0000 Received: from mail-dm3nam02on2040.outbound.protection.outlook.com ([40.107.95.40] helo=NAM02-DM3-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from <witu@nvidia.com>) id 1q6fgR-0001j5-1W for kernel-team@lists.ubuntu.com; Tue, 06 Jun 2023 23:01:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XEMLnB2BurFdhtYuHjb2lOmjVy6HpRqwyqSqYJOXtLpxSyzLHFMlbKUyNkM9pk1HmhKFBhN/6QSJmL3Pmw7lOOP58GC6dCt9cOA1uKNbONLxGyVr1FJNgSi7hjmBFBlYKukelXK9O4P8wmnpT7d2Ng8jEerMt6DPiONEQhH+cvdAD5sTdkJYPGoSuMlYpun/OKSCI3R8HAxn0NUsgctin8jbnTMEuOTHBe99qBKGpoi1lP4WJh5iPdtvxbvC1UL6CWpOErsoiXE4rnXqmkNkrnMu+fWZa2zw2ChhN5xL1XbKrcejEMYJKS6MmSUVhd0wEbChhpDVhAyiLgq9/pc+AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZQPAJRCdARJRZqzKgsxahGLj+Ub2pd36KEeAwj4HnHc=; b=Mtm/wSq6OInE4+CuI5eLmXtbArM6JdBhHAuNBOMm9HOenf6Mou+/hhhMgmjZVj1gfWZwRPvyppvl/xn1pVr1b3dgJr4vCpqs5hNHrbeYTYw0jD4U6JIDEmn8hyKWNo0rUf57TaAd2npgOxApWIASxoAaXNCSdE5pjz0XLrlk6YNW3ZKbeybTsamkIKXH4SlEhdp6jr5d4BTiQX1OsBfWd23YeMSr08Dp6LNAYGtoN8XdDWPjgIjVQWdFZBeDEZ2M4HCPr4zo4toPlILTexi2rhSmY2p8GCBLzj03re9xCbIm4Bcr3GZSvu7QbuHFMlICz4ZCVBE8tKuQZ1rHCVotpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=canonical.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZQPAJRCdARJRZqzKgsxahGLj+Ub2pd36KEeAwj4HnHc=; b=QZdtaYxYnfHA1+ZJOSUNZO9n751jinETYQlnafEYpId9EdtO5YwkYR9221pujKb8CJ/tzRBhtzyYm4XhBkYXQYhMp81YwPzYCX64xi6hsAtFmWC0AOtFeHhzUllimGnCdPShqjzHdY4fo8uEEmF8KmJdQhtTD8T2mu/mypSoPSoY+VWoebIFMlYDPgA++jO9UgZEU1dy76kV5QRnPHBbzcGqXzdjBKI37Wr6LJuBtaXZpJEU2ojs+BPBq96hr7FvPYF40DNy8iwaeeMhIYUcp9TGX62zzA8zGQJXzBIlSRKjrNKGapNJXWM7Th71WFwLmJyKSoY4OEina+wcKA+upQ== Received: from DM6PR13CA0053.namprd13.prod.outlook.com (2603:10b6:5:134::30) by SA0PR12MB4416.namprd12.prod.outlook.com (2603:10b6:806:99::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Tue, 6 Jun 2023 23:01:44 +0000 Received: from CY4PEPF0000E9D1.namprd03.prod.outlook.com (2603:10b6:5:134:cafe::39) by DM6PR13CA0053.outlook.office365.com (2603:10b6:5:134::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.18 via Frontend Transport; Tue, 6 Jun 2023 23:01:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CY4PEPF0000E9D1.mail.protection.outlook.com (10.167.241.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.13 via Frontend Transport; Tue, 6 Jun 2023 23:01:43 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 6 Jun 2023 16:01:32 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 6 Jun 2023 16:01:32 -0700 Received: from mtl123.mtl.labs.mlnx (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Tue, 6 Jun 2023 16:01:32 -0700 Received: from sw-mtx-002.mtx.labs.mlnx (sw-mtx-002.mtx.labs.mlnx [10.9.151.106]) by mtl123.mtl.labs.mlnx (8.14.4/8.14.4) with ESMTP id 356N1LCR011133; Wed, 7 Jun 2023 02:01:29 +0300 From: William Tu <witu@nvidia.com> To: <kernel-team@lists.ubuntu.com> Subject: [SRU][J:linux-bluefield][PATCH v3 04/11] net/sched: flower: fix fl_change() error recovery path Date: Wed, 7 Jun 2023 02:01:13 +0300 Message-ID: <20230606230120.407292-5-witu@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230606230120.407292-1-witu@nvidia.com> References: <20230606230120.407292-1-witu@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D1:EE_|SA0PR12MB4416:EE_ X-MS-Office365-Filtering-Correlation-Id: a274a1d7-b0e6-4957-fb33-08db66e1ff35 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3IRn8i3V06LSw6kkVj8YNyr0LDvirkEwGB8oJ3YkgJn202z0YJc5nAu2HPG1V9F4s71yoV6/cV9sHZKUvARpY/hp2qfK9uVyfmuINKnSiDaPtzGjq6RXlYzA2vCYcjy3iwHsHiAQR9xYWT13QFd/l+m940diBzdG9gKAlWua6J1SdEjSmeC3jG3TAVLc8iEE5n+1wgUiht0bi/maXn6C+hFYVMJR4YQvpR9rIuWc1nZO3EYMeylyZd+99tOIiPKQ8PNnkMMj15EdUWgiQ0jDL0yQjXxDa0hny3nv1i0kq9FjQBfPCAjGjSndVpsUvP5aGZBzjsSx3cqAPCirN74zNGgnpDWszOUriD1JGjWjZjwJFKL6oXdkfBu74fxWggNctOugN/Ps3qfxnX7PSUjGRIn0Q5Z/sQb92xdMZtka7/Np2URhunJ3R6DQY0xQMAZmXTDrHZ/Vq58trYnywQDvE7v26NwRPNpdevcxpwxvGNBBCb2pybp9IUGVsk3NsMx2bi6pC+Vjp5km5hpWjwGfOXoaWVqCaQsSBj4T0dgD6Jl5m+FUaC7FNMkUvE8cR1833L9wDuj9pjlRROaQkJXTbnk5Q2wFIJ7FZPms7bqCrdpGp8lhKZlqgE/4VIxkT77I7T29Ad3zT436vCIaxwR7i/Sl+p8CAUxmiDqarjp4l0d2ab2Cg4j1VHwUwtigrb6GAHcDxirIlOA3LKTEkoimTsrp0+0dXN3lj/9XzmoHUMLOoch80ZuSuQjPbIC4u919Jed8iep5G7fiXd/t7jDNtDM4dl+wxbYm0aCZMWPQNJY= X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(39860400002)(396003)(376002)(451199021)(40470700004)(46966006)(36840700001)(107886003)(1076003)(186003)(26005)(2616005)(966005)(336012)(83380400001)(47076005)(36756003)(6666004)(54906003)(36860700001)(82310400005)(2906002)(8676002)(8936002)(40480700001)(82740400003)(478600001)(40460700003)(6916009)(316002)(5660300002)(4326008)(86362001)(7636003)(70206006)(70586007)(41300700001)(356005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 23:01:43.7365 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a274a1d7-b0e6-4957-fb33-08db66e1ff35 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D1.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4416 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions <kernel-team.lists.ubuntu.com> List-Unsubscribe: <https://lists.ubuntu.com/mailman/options/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe> List-Archive: <https://lists.ubuntu.com/archives/kernel-team> List-Post: <mailto:kernel-team@lists.ubuntu.com> List-Help: <mailto:kernel-team-request@lists.ubuntu.com?subject=help> List-Subscribe: <https://lists.ubuntu.com/mailman/listinfo/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe> Cc: dann.frazier@canonical.com, paulb@nvidia.com, vlad@nvidia.com, yifeid@nvidia.com, bodong@nvidia.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" <kernel-team-bounces@lists.ubuntu.com> |
Series |
Support hardware miss to tc action
|
expand
|
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index 54228e684f86..83a55b00e800 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -2036,8 +2036,9 @@ static int fl_change(struct net *net, struct sk_buff *in_skb, fnew->flags = nla_get_u32(tb[TCA_FLOWER_FLAGS]); if (!tc_flags_valid(fnew->flags)) { + kfree(fnew); err = -EINVAL; - goto errout; + goto errout_tb; } } @@ -2062,8 +2063,10 @@ static int fl_change(struct net *net, struct sk_buff *in_skb, } spin_unlock(&tp->lock); - if (err) - goto errout; + if (err) { + kfree(fnew); + goto errout_tb; + } } fnew->handle = handle; @@ -2171,7 +2174,6 @@ static int fl_change(struct net *net, struct sk_buff *in_skb, fl_mask_put(head, fnew->mask); errout_idr: idr_remove(&head->handle_idr, fnew->handle); -errout: __fl_put(fnew); errout_tb: kfree(tb);