| Message ID | 20230606081052.43700-2-koba.ko@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2,SRU,U/L/K/J] drm/i915: Use 18 fast wake AUX sync len | expand |
On Tue, Jun 06, 2023 at 04:10:51PM +0800, Koba Ko wrote: > From: Jouni Högander <jouni.hogander@intel.com> > > BugLink: https://bugs.launchpad.net/bugs/2023004 > > HW default for wake sync pulses is 18. 10 precharge and 8 preamble. There > is no reason to change this especially as it is causing problems with > certain eDP panels. > > v3: Change "Fixes:" commit > v2: Remove "fast wake" repeat from subject > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com> > Fixes: e1c71f8f9180 ("drm/i915: Fix fast wake AUX sync len") > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8475 > Reviewed-by: Luca Coelho <luciano.coelho@intel.com> > Link: https://patchwork.freedesktop.org/patch/msgid/20230530101649.2549949-1-jouni.hogander@intel.com > (cherry picked from commit b29a20f7c4995a059ed764ce42389857426397c7 > drmtip) > Signed-off-by: Koba Ko <koba.ko@canonical.com> > --- Applied to mantic/linux-unstable. Thanks, -Andrea > drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c > index faec2b8be5f46..dd399fcbb025d 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c > @@ -129,7 +129,7 @@ static int intel_dp_aux_sync_len(void) > > static int intel_dp_aux_fw_sync_len(void) > { > - int precharge = 16; /* 10-16 */ > + int precharge = 10; /* 10-16 */ > int preamble = 8; > > return precharge + preamble; > -- > 2.25.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 06.06.23 10:10, Koba Ko wrote: > From: Jouni Högander <jouni.hogander@intel.com> > > BugLink: https://bugs.launchpad.net/bugs/2023004 > > HW default for wake sync pulses is 18. 10 precharge and 8 preamble. There > is no reason to change this especially as it is causing problems with > certain eDP panels. > > v3: Change "Fixes:" commit > v2: Remove "fast wake" repeat from subject > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com> > Fixes: e1c71f8f9180 ("drm/i915: Fix fast wake AUX sync len") > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8475 > Reviewed-by: Luca Coelho <luciano.coelho@intel.com> > Link: https://patchwork.freedesktop.org/patch/msgid/20230530101649.2549949-1-jouni.hogander@intel.com > (cherry picked from commit b29a20f7c4995a059ed764ce42389857426397c7 > drmtip) > Signed-off-by: Koba Ko <koba.ko@canonical.com> > --- > drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c > index faec2b8be5f46..dd399fcbb025d 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c > @@ -129,7 +129,7 @@ static int intel_dp_aux_sync_len(void) > > static int intel_dp_aux_fw_sync_len(void) > { > - int precharge = 16; /* 10-16 */ > + int precharge = 10; /* 10-16 */ > int preamble = 8; > > return precharge + preamble; Applied to lunar:linux/master-next changing the SHA1 to the upstream reference. However this patch clearly states: Fixes: e1c71f8f9180 ("drm/i915: Fix fast wake AUX sync len") Which has NOT been applied to either Kinetic nor Jammy. Above change landed in Lunar via https://bugs.launchpad.net/bugs/2018655 which did not ask for backports into older kernels. -Stefan
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c index faec2b8be5f46..dd399fcbb025d 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c @@ -129,7 +129,7 @@ static int intel_dp_aux_sync_len(void) static int intel_dp_aux_fw_sync_len(void) { - int precharge = 16; /* 10-16 */ + int precharge = 10; /* 10-16 */ int preamble = 8; return precharge + preamble;