diff mbox series

[F-K,linux-signed-gcp] UBUNTU: [Packaging] Add sbsigntool build-dependcy on all arches

Message ID 20230127114500.900255-1-dimitri.ledkov@canonical.com
State New
Headers show
Series [F-K,linux-signed-gcp] UBUNTU: [Packaging] Add sbsigntool build-dependcy on all arches | expand

Commit Message

Dimitri John Ledkov Jan. 27, 2023, 11:45 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2004010

Add sbsigntool build-dependcy on all arches, it is used to verify
correct signing in the signing archive.

Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
---

 This needs to apply to all linux-signed-{gcp,gke}{,-*} in at least
 focal to kinetic, that build on arm64. If this is reviewed, I can go
 through all the repositories and push this change to them all.

 I am not sure when or why this build-dependency happened like this,
 given that sbsigntool has existed on arm64 for a very long time and
 used by all other arm64 linux-signed packages.

 debian/control.stub | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Gardner Jan. 29, 2023, 3:52 p.m. UTC | #1
On 1/27/23 04:45, Dimitri John Ledkov wrote:
> BugLink: https://bugs.launchpad.net/bugs/2004010
> 
> Add sbsigntool build-dependcy on all arches, it is used to verify
> correct signing in the signing archive.
> 
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> ---
> 
>   This needs to apply to all linux-signed-{gcp,gke}{,-*} in at least
>   focal to kinetic, that build on arm64. If this is reviewed, I can go
>   through all the repositories and push this change to them all.
> 
>   I am not sure when or why this build-dependency happened like this,
>   given that sbsigntool has existed on arm64 for a very long time and
>   used by all other arm64 linux-signed packages.
> 
>   debian/control.stub | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian/control.stub b/debian/control.stub
> index a597cadad1..7227aab2a9 100644
> --- a/debian/control.stub
> +++ b/debian/control.stub
> @@ -8,6 +8,6 @@ Build-Depends:
>    python3,
>    python3-apt,
>   Build-Depends-Arch:
> - sbsigntool [amd64],
> + sbsigntool,
>    @DEPENDS@,
>   Standards-Version: 3.9.4
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Dimitri John Ledkov Feb. 8, 2023, 2:14 p.m. UTC | #2
Applied to all the relevant linux-signed-gcp/gke/gkeop[-*]

On Sun, 29 Jan 2023 at 15:52, Tim Gardner <tim.gardner@canonical.com> wrote:
>
> On 1/27/23 04:45, Dimitri John Ledkov wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2004010
> >
> > Add sbsigntool build-dependcy on all arches, it is used to verify
> > correct signing in the signing archive.
> >
> > Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> > ---
> >
> >   This needs to apply to all linux-signed-{gcp,gke}{,-*} in at least
> >   focal to kinetic, that build on arm64. If this is reviewed, I can go
> >   through all the repositories and push this change to them all.
> >
> >   I am not sure when or why this build-dependency happened like this,
> >   given that sbsigntool has existed on arm64 for a very long time and
> >   used by all other arm64 linux-signed packages.
> >
> >   debian/control.stub | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/debian/control.stub b/debian/control.stub
> > index a597cadad1..7227aab2a9 100644
> > --- a/debian/control.stub
> > +++ b/debian/control.stub
> > @@ -8,6 +8,6 @@ Build-Depends:
> >    python3,
> >    python3-apt,
> >   Build-Depends-Arch:
> > - sbsigntool [amd64],
> > + sbsigntool,
> >    @DEPENDS@,
> >   Standards-Version: 3.9.4
> Acked-by: Tim Gardner <tim.gardner@canonical.com>
> --
> -----------
> Tim Gardner
> Canonical, Inc
>
diff mbox series

Patch

diff --git a/debian/control.stub b/debian/control.stub
index a597cadad1..7227aab2a9 100644
--- a/debian/control.stub
+++ b/debian/control.stub
@@ -8,6 +8,6 @@  Build-Depends:
  python3,
  python3-apt,
 Build-Depends-Arch:
- sbsigntool [amd64],
+ sbsigntool,
  @DEPENDS@,
 Standards-Version: 3.9.4