diff mbox series

[L/unstable,08/13] UBUNTU: [Packaging] use olddefconfig in stamp-prepare-tree

Message ID 20221205085619.257813-9-masahiro.yamada@canonical.com
State New
Headers show
Series [L/unstable,01/13] UBUNTU: [Packaging] mark phony targets | expand

Commit Message

Masahiro Yamada Dec. 5, 2022, 8:56 a.m. UTC 
You do not need to invoke syncconfig here because Kbuild takes care of
it before staring the build. prepare and scripts are unneeded for the
same reason.

All the use of 'syncconfig' in debian/rules is suspicous because
syncconfig may stop to ask for user's preference when it finds a
new config option. There is nobody to answer the Kconfig's question
when the package is being built in auto-builders such as cbd, launchpad.

Presumably what you want here is olddefconfig, which is a non-interactive
command to set any config option to its default.

Signed-off-by: Masahiro Yamada <masahiro.yamada@canonical.com>
---
 debian/rules.d/2-binary-arch.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
index 2737638d1134..f32767671705 100644
--- a/debian/rules.d/2-binary-arch.mk
+++ b/debian/rules.d/2-binary-arch.mk
@@ -36,7 +36,7 @@  $(stampdir)/stamp-prepare-tree-%: debian/scripts/fix-filenames
 		sed -ie 's/.*CONFIG_UBUNTU_ODM_DRIVERS.*/# CONFIG_UBUNTU_ODM_DRIVERS is not set/' \
 		    $(builddir)/build-$*/.config
 	find $(builddir)/build-$* -name "*.ko" | xargs rm -f
-	$(build_cd) $(kmake) $(build_O) -j1 syncconfig prepare scripts
+	$(build_cd) $(kmake) $(build_O) -j1 olddefconfig
 	touch $@
 
 # Used by developers as a shortcut to prepare a tree for compilation.