diff mbox series

[SRU,B] HID: asus: Add depends on USB_HID to HID_ASUS Kconfig option

Message ID 20220202130037.173324-1-krzysztof.kozlowski@canonical.com
State New
Headers show
Series [SRU,B] HID: asus: Add depends on USB_HID to HID_ASUS Kconfig option | expand

Commit Message

Krzysztof Kozlowski Feb. 2, 2022, 1 p.m. UTC 
From: Hans de Goede <hdegoede@redhat.com>

BugLink: https://bugs.launchpad.net/bugs/1959762

Since commit 4bc43a421218 ("HID: asus: Add
hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
fix missing symbols errors in hid-asus when USB_HID is not enabled.

Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
(cherry picked from commit c4f0126d487f3c68ab19ccb7c561e8fbf3ea2247)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Tim Gardner Feb. 2, 2022, 2:07 p.m. UTC | #1 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 2/2/22 6:00 AM, Krzysztof Kozlowski wrote:
> From: Hans de Goede <hdegoede@redhat.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1959762
> 
> Since commit 4bc43a421218 ("HID: asus: Add
> hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
> on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
> fix missing symbols errors in hid-asus when USB_HID is not enabled.
> 
> Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> (cherry picked from commit c4f0126d487f3c68ab19ccb7c561e8fbf3ea2247)
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>   drivers/hid/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 904ba2d3c664..455c670b05b4 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -148,6 +148,7 @@ config HID_APPLEIR
>   
>   config HID_ASUS
>   	tristate "Asus"
> +	depends on USB_HID
>   	depends on LEDS_CLASS
>   	---help---
>   	Support for Asus notebook built-in keyboard and touchpad via i2c, and
Stefan Bader Feb. 8, 2022, 8:27 a.m. UTC | #2 
On 02.02.22 14:00, Krzysztof Kozlowski wrote:
> From: Hans de Goede <hdegoede@redhat.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1959762
> 
> Since commit 4bc43a421218 ("HID: asus: Add
> hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
> on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
> fix missing symbols errors in hid-asus when USB_HID is not enabled.
> 
> Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> (cherry picked from commit c4f0126d487f3c68ab19ccb7c561e8fbf3ea2247)
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>   drivers/hid/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 904ba2d3c664..455c670b05b4 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -148,6 +148,7 @@ config HID_APPLEIR
>   
>   config HID_ASUS
>   	tristate "Asus"
> +	depends on USB_HID
>   	depends on LEDS_CLASS
>   	---help---
>   	Support for Asus notebook built-in keyboard and touchpad via i2c, and
Krzysztof Kozlowski Feb. 9, 2022, 10:52 a.m. UTC | #3 
On 02/02/2022 14:00, Krzysztof Kozlowski wrote:
> From: Hans de Goede <hdegoede@redhat.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1959762
> 
> Since commit 4bc43a421218 ("HID: asus: Add
> hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
> on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
> fix missing symbols errors in hid-asus when USB_HID is not enabled.
> 
> Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> (cherry picked from commit c4f0126d487f3c68ab19ccb7c561e8fbf3ea2247)
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  drivers/hid/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

This seems to be needed also on v5.4 kernels, so +[F] in subject.


Best regards,
Krzysztof
Stefan Bader Feb. 9, 2022, 2:07 p.m. UTC | #4 
On 09.02.22 11:52, Krzysztof Kozlowski wrote:
> On 02/02/2022 14:00, Krzysztof Kozlowski wrote:
>> From: Hans de Goede <hdegoede@redhat.com>
>>
>> BugLink: https://bugs.launchpad.net/bugs/1959762
>>
>> Since commit 4bc43a421218 ("HID: asus: Add
>> hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
>> on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
>> fix missing symbols errors in hid-asus when USB_HID is not enabled.
>>
>> Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>> (cherry picked from commit c4f0126d487f3c68ab19ccb7c561e8fbf3ea2247)
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
>>   drivers/hid/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
> 
> This seems to be needed also on v5.4 kernels, so +[F] in subject.

Then the bug report also should be nominated for focal.

-Stefan

> 
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Feb. 9, 2022, 2:08 p.m. UTC | #5 
On 09/02/2022 15:07, Stefan Bader wrote:
> On 09.02.22 11:52, Krzysztof Kozlowski wrote:
>> On 02/02/2022 14:00, Krzysztof Kozlowski wrote:
>>> From: Hans de Goede <hdegoede@redhat.com>
>>>
>>> BugLink: https://bugs.launchpad.net/bugs/1959762
>>>
>>> Since commit 4bc43a421218 ("HID: asus: Add
>>> hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
>>> on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
>>> fix missing symbols errors in hid-asus when USB_HID is not enabled.
>>>
>>> Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
>>> Reported-by: kbuild test robot <lkp@intel.com>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>>> (cherry picked from commit c4f0126d487f3c68ab19ccb7c561e8fbf3ea2247)
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> ---
>>>   drivers/hid/Kconfig | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>
>> This seems to be needed also on v5.4 kernels, so +[F] in subject.
> 
> Then the bug report also should be nominated for focal.
> 

I already added a sub-task for bug report for Focal. Anything else is
needed?


Best regards,
Krzysztof
Stefan Bader Feb. 9, 2022, 2:14 p.m. UTC | #6 
On 09.02.22 15:08, Krzysztof Kozlowski wrote:
> On 09/02/2022 15:07, Stefan Bader wrote:
>> On 09.02.22 11:52, Krzysztof Kozlowski wrote:
>>> On 02/02/2022 14:00, Krzysztof Kozlowski wrote:
>>>> From: Hans de Goede <hdegoede@redhat.com>
>>>>
>>>> BugLink: https://bugs.launchpad.net/bugs/1959762
>>>>
>>>> Since commit 4bc43a421218 ("HID: asus: Add
>>>> hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
>>>> on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
>>>> fix missing symbols errors in hid-asus when USB_HID is not enabled.
>>>>
>>>> Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
>>>> Reported-by: kbuild test robot <lkp@intel.com>
>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>>>> (cherry picked from commit c4f0126d487f3c68ab19ccb7c561e8fbf3ea2247)
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>>> ---
>>>>    drivers/hid/Kconfig | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>
>>> This seems to be needed also on v5.4 kernels, so +[F] in subject.
>>
>> Then the bug report also should be nominated for focal.
>>
> 
> I already added a sub-task for bug report for Focal. Anything else is
> needed?
> 

No, you added a sub-tags to the jira issue. Not

https://bugs.launchpad.net/bugs/1959762

-Stefan
> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski Feb. 9, 2022, 2:16 p.m. UTC | #7 
On 09/02/2022 15:14, Stefan Bader wrote:
> On 09.02.22 15:08, Krzysztof Kozlowski wrote:
>> On 09/02/2022 15:07, Stefan Bader wrote:
>>> On 09.02.22 11:52, Krzysztof Kozlowski wrote:
>>>> On 02/02/2022 14:00, Krzysztof Kozlowski wrote:
>>>>> From: Hans de Goede <hdegoede@redhat.com>
>>>>>
>>>>> BugLink: https://bugs.launchpad.net/bugs/1959762
>>>>>
>>>>> Since commit 4bc43a421218 ("HID: asus: Add
>>>>> hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
>>>>> on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
>>>>> fix missing symbols errors in hid-asus when USB_HID is not enabled.
>>>>>
>>>>> Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
>>>>> Reported-by: kbuild test robot <lkp@intel.com>
>>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>>> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>>>>> (cherry picked from commit c4f0126d487f3c68ab19ccb7c561e8fbf3ea2247)
>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>>>> ---
>>>>>    drivers/hid/Kconfig | 1 +
>>>>>    1 file changed, 1 insertion(+)
>>>>>
>>>>
>>>> This seems to be needed also on v5.4 kernels, so +[F] in subject.
>>>
>>> Then the bug report also should be nominated for focal.
>>>
>>
>> I already added a sub-task for bug report for Focal. Anything else is
>> needed?
>>
> 
> No, you added a sub-tags to the jira issue. Not
> 
> https://bugs.launchpad.net/bugs/1959762

D'oh! Right. Thanks for patience :)


Best regards,
Krzysztof
Stefan Bader Feb. 11, 2022, 3:40 p.m. UTC | #8 
On 02.02.22 14:00, Krzysztof Kozlowski wrote:
> From: Hans de Goede <hdegoede@redhat.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1959762
> 
> Since commit 4bc43a421218 ("HID: asus: Add
> hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
> on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
> fix missing symbols errors in hid-asus when USB_HID is not enabled.
> 
> Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> (cherry picked from commit c4f0126d487f3c68ab19ccb7c561e8fbf3ea2247)
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---

This was actually included in upstream v5.4.170 which just got applied. I have 
added the additional bug reference. Thanks.

-Stefan

>   drivers/hid/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 904ba2d3c664..455c670b05b4 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -148,6 +148,7 @@ config HID_APPLEIR
>   
>   config HID_ASUS
>   	tristate "Asus"
> +	depends on USB_HID
>   	depends on LEDS_CLASS
>   	---help---
>   	Support for Asus notebook built-in keyboard and touchpad via i2c, and
Kleber Sacilotto de Souza Feb. 11, 2022, 4:09 p.m. UTC | #9 
On 2/2/22 14:00, Krzysztof Kozlowski wrote:
> From: Hans de Goede <hdegoede@redhat.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1959762
> 
> Since commit 4bc43a421218 ("HID: asus: Add
> hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
> on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
> fix missing symbols errors in hid-asus when USB_HID is not enabled.
> 
> Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> (cherry picked from commit c4f0126d487f3c68ab19ccb7c561e8fbf3ea2247)
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>   drivers/hid/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 904ba2d3c664..455c670b05b4 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -148,6 +148,7 @@ config HID_APPLEIR
>   
>   config HID_ASUS
>   	tristate "Asus"
> +	depends on USB_HID
>   	depends on LEDS_CLASS
>   	---help---
>   	Support for Asus notebook built-in keyboard and touchpad via i2c, and


This patch was also already applied to Bionic via "Bionic update: upstream stable
patchset 2022-01-27" (LP #1959335).


Thanks,
Kleber
diff mbox series

Patch

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 904ba2d3c664..455c670b05b4 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -148,6 +148,7 @@  config HID_APPLEIR
 
 config HID_ASUS
 	tristate "Asus"
+	depends on USB_HID
 	depends on LEDS_CLASS
 	---help---
 	Support for Asus notebook built-in keyboard and touchpad via i2c, and