diff mbox series

[hirsute:linux-gcp] UBUNTU: [Config] gcp: Disable CONFIG_DELL_SMBIOS_SMM, CONFIG_DELL_UART_BACKLIGHT, CONFIG_I2C_AMD_MP2

Message ID 20210518140418.7506-1-tim.gardner@canonical.com
State New
Headers show
Series [hirsute:linux-gcp] UBUNTU: [Config] gcp: Disable CONFIG_DELL_SMBIOS_SMM, CONFIG_DELL_UART_BACKLIGHT, CONFIG_I2C_AMD_MP2 | expand

Commit Message

Tim Gardner May 18, 2021, 2:04 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1925241

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>

A ML review was requested for this patch during crank review. Hence the patch
to a specific ABI file.
https://trello.com/c/6DRp8uPI/37-crank-1-hirsute-linux-gcp-kernel

---
 debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules | 1 -
 debian.gcp/config/config.common.ubuntu         | 6 +++---
 2 files changed, 3 insertions(+), 4 deletions(-)

Comments

Stefan Bader May 18, 2021, 2:41 p.m. UTC | #1
On 18.05.21 16:04, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1925241
> 
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> 
> A ML review was requested for this patch during crank review. Hence the patch
> to a specific ABI file.
> https://trello.com/c/6DRp8uPI/37-crank-1-hirsute-linux-gcp-kernel
> 
> ---

Why not use the same message as for Groovy?

"Enforcement annotations indicate that these config options should never have
been set."

And that should have been sent together with the Groovy one when that was done 
and it had been clear hirsute should be the same... anyhow, if the decription is 
made the same as G when applying.

Acked-by: Stefan Bader <stefan.bader@canonical.com>

>   debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules | 1 -
>   debian.gcp/config/config.common.ubuntu         | 6 +++---
>   2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules b/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules
> index a0c869dbdf66..ffea16f056dc 100644
> --- a/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules
> +++ b/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules
> @@ -971,7 +971,6 @@ dell-rbtn
>   dell-smbios
>   dell-smm-hwmon
>   dell-smo8800
> -dell-uart-backlight
>   dell-wmi
>   dell-wmi-aio
>   dell-wmi-descriptor
> diff --git a/debian.gcp/config/config.common.ubuntu b/debian.gcp/config/config.common.ubuntu
> index a0677e77464c..af2dbd339643 100644
> --- a/debian.gcp/config/config.common.ubuntu
> +++ b/debian.gcp/config/config.common.ubuntu
> @@ -1673,10 +1673,10 @@ CONFIG_DELL_LAPTOP=m
>   CONFIG_DELL_RBTN=m
>   CONFIG_DELL_RBU=m
>   CONFIG_DELL_SMBIOS=m
> -CONFIG_DELL_SMBIOS_SMM=y
> +# CONFIG_DELL_SMBIOS_SMM is not set
>   CONFIG_DELL_SMBIOS_WMI=y
>   CONFIG_DELL_SMO8800=m
> -CONFIG_DELL_UART_BACKLIGHT=m
> +# CONFIG_DELL_UART_BACKLIGHT is not set
>   CONFIG_DELL_WMI=m
>   CONFIG_DELL_WMI_AIO=m
>   CONFIG_DELL_WMI_DESCRIPTOR=m
> @@ -3055,7 +3055,7 @@ CONFIG_I2C_ALI15X3=m
>   CONFIG_I2C_AMD756=m
>   CONFIG_I2C_AMD756_S4882=m
>   CONFIG_I2C_AMD8111=m
> -CONFIG_I2C_AMD_MP2=y
> +# CONFIG_I2C_AMD_MP2 is not set
>   CONFIG_I2C_BOARDINFO=y
>   CONFIG_I2C_CBUS_GPIO=m
>   CONFIG_I2C_CHARDEV=y
>
Kleber Sacilotto de Souza May 19, 2021, 8:41 a.m. UTC | #2
On 18.05.21 16:04, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1925241
> 
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>

With the commit message fixed:

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks


> 
> A ML review was requested for this patch during crank review. Hence the patch
> to a specific ABI file.
> https://trello.com/c/6DRp8uPI/37-crank-1-hirsute-linux-gcp-kernel
> 
> ---
>   debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules | 1 -
>   debian.gcp/config/config.common.ubuntu         | 6 +++---
>   2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules b/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules
> index a0c869dbdf66..ffea16f056dc 100644
> --- a/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules
> +++ b/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules
> @@ -971,7 +971,6 @@ dell-rbtn
>   dell-smbios
>   dell-smm-hwmon
>   dell-smo8800
> -dell-uart-backlight
>   dell-wmi
>   dell-wmi-aio
>   dell-wmi-descriptor
> diff --git a/debian.gcp/config/config.common.ubuntu b/debian.gcp/config/config.common.ubuntu
> index a0677e77464c..af2dbd339643 100644
> --- a/debian.gcp/config/config.common.ubuntu
> +++ b/debian.gcp/config/config.common.ubuntu
> @@ -1673,10 +1673,10 @@ CONFIG_DELL_LAPTOP=m
>   CONFIG_DELL_RBTN=m
>   CONFIG_DELL_RBU=m
>   CONFIG_DELL_SMBIOS=m
> -CONFIG_DELL_SMBIOS_SMM=y
> +# CONFIG_DELL_SMBIOS_SMM is not set
>   CONFIG_DELL_SMBIOS_WMI=y
>   CONFIG_DELL_SMO8800=m
> -CONFIG_DELL_UART_BACKLIGHT=m
> +# CONFIG_DELL_UART_BACKLIGHT is not set
>   CONFIG_DELL_WMI=m
>   CONFIG_DELL_WMI_AIO=m
>   CONFIG_DELL_WMI_DESCRIPTOR=m
> @@ -3055,7 +3055,7 @@ CONFIG_I2C_ALI15X3=m
>   CONFIG_I2C_AMD756=m
>   CONFIG_I2C_AMD756_S4882=m
>   CONFIG_I2C_AMD8111=m
> -CONFIG_I2C_AMD_MP2=y
> +# CONFIG_I2C_AMD_MP2 is not set
>   CONFIG_I2C_BOARDINFO=y
>   CONFIG_I2C_CBUS_GPIO=m
>   CONFIG_I2C_CHARDEV=y
>
Tim Gardner May 20, 2021, 11:12 a.m. UTC | #3
Applied to hirsute:linux-gcp. Thanks.

-rtg

On 5/18/21 8:04 AM, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1925241
> 
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> 
> A ML review was requested for this patch during crank review. Hence the patch
> to a specific ABI file.
> https://trello.com/c/6DRp8uPI/37-crank-1-hirsute-linux-gcp-kernel
> 
> ---
>   debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules | 1 -
>   debian.gcp/config/config.common.ubuntu         | 6 +++---
>   2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules b/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules
> index a0c869dbdf66..ffea16f056dc 100644
> --- a/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules
> +++ b/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules
> @@ -971,7 +971,6 @@ dell-rbtn
>   dell-smbios
>   dell-smm-hwmon
>   dell-smo8800
> -dell-uart-backlight
>   dell-wmi
>   dell-wmi-aio
>   dell-wmi-descriptor
> diff --git a/debian.gcp/config/config.common.ubuntu b/debian.gcp/config/config.common.ubuntu
> index a0677e77464c..af2dbd339643 100644
> --- a/debian.gcp/config/config.common.ubuntu
> +++ b/debian.gcp/config/config.common.ubuntu
> @@ -1673,10 +1673,10 @@ CONFIG_DELL_LAPTOP=m
>   CONFIG_DELL_RBTN=m
>   CONFIG_DELL_RBU=m
>   CONFIG_DELL_SMBIOS=m
> -CONFIG_DELL_SMBIOS_SMM=y
> +# CONFIG_DELL_SMBIOS_SMM is not set
>   CONFIG_DELL_SMBIOS_WMI=y
>   CONFIG_DELL_SMO8800=m
> -CONFIG_DELL_UART_BACKLIGHT=m
> +# CONFIG_DELL_UART_BACKLIGHT is not set
>   CONFIG_DELL_WMI=m
>   CONFIG_DELL_WMI_AIO=m
>   CONFIG_DELL_WMI_DESCRIPTOR=m
> @@ -3055,7 +3055,7 @@ CONFIG_I2C_ALI15X3=m
>   CONFIG_I2C_AMD756=m
>   CONFIG_I2C_AMD756_S4882=m
>   CONFIG_I2C_AMD8111=m
> -CONFIG_I2C_AMD_MP2=y
> +# CONFIG_I2C_AMD_MP2 is not set
>   CONFIG_I2C_BOARDINFO=y
>   CONFIG_I2C_CBUS_GPIO=m
>   CONFIG_I2C_CHARDEV=y
>
diff mbox series

Patch

diff --git a/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules b/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules
index a0c869dbdf66..ffea16f056dc 100644
--- a/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules
+++ b/debian.gcp/abi/5.11.0-1006.6/amd64/gcp.modules
@@ -971,7 +971,6 @@  dell-rbtn
 dell-smbios
 dell-smm-hwmon
 dell-smo8800
-dell-uart-backlight
 dell-wmi
 dell-wmi-aio
 dell-wmi-descriptor
diff --git a/debian.gcp/config/config.common.ubuntu b/debian.gcp/config/config.common.ubuntu
index a0677e77464c..af2dbd339643 100644
--- a/debian.gcp/config/config.common.ubuntu
+++ b/debian.gcp/config/config.common.ubuntu
@@ -1673,10 +1673,10 @@  CONFIG_DELL_LAPTOP=m
 CONFIG_DELL_RBTN=m
 CONFIG_DELL_RBU=m
 CONFIG_DELL_SMBIOS=m
-CONFIG_DELL_SMBIOS_SMM=y
+# CONFIG_DELL_SMBIOS_SMM is not set
 CONFIG_DELL_SMBIOS_WMI=y
 CONFIG_DELL_SMO8800=m
-CONFIG_DELL_UART_BACKLIGHT=m
+# CONFIG_DELL_UART_BACKLIGHT is not set
 CONFIG_DELL_WMI=m
 CONFIG_DELL_WMI_AIO=m
 CONFIG_DELL_WMI_DESCRIPTOR=m
@@ -3055,7 +3055,7 @@  CONFIG_I2C_ALI15X3=m
 CONFIG_I2C_AMD756=m
 CONFIG_I2C_AMD756_S4882=m
 CONFIG_I2C_AMD8111=m
-CONFIG_I2C_AMD_MP2=y
+# CONFIG_I2C_AMD_MP2 is not set
 CONFIG_I2C_BOARDINFO=y
 CONFIG_I2C_CBUS_GPIO=m
 CONFIG_I2C_CHARDEV=y