| Message ID | 20201013070414.745784-2-jeremy.szu@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | alsa/hda: The front Mic doesn't work on a HP machine | expand |
On 13.10.20 09:04, Jeremy Szu wrote: > BugLink: https://bugs.launchpad.net/bugs/1899508 > > On a HP ZCentral, the front Mic could not be detected. > > The codec of the HP ZCentrol is alc671 and it needs to override the pin > configuration to enable the headset mic. > > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> Hi Jeremy, Do you have a link to the upstream submission for reference? It would be good to have a reference to the upstream discussion if we have it. Apart from that the patch looks good. Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index b44219859d82..44144470ef5f 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9311,6 +9311,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = { > SND_PCI_QUIRK(0x1028, 0x0698, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x1028, 0x069f, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800), > + SND_PCI_QUIRK(0x103c, 0x873e, "HP", ALC671_FIXUP_HP_HEADSET_MIC2), > SND_PCI_QUIRK(0x1043, 0x1080, "Asus UX501VW", ALC668_FIXUP_HEADSET_MODE), > SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50), > SND_PCI_QUIRK(0x1043, 0x13df, "Asus N550JX", ALC662_FIXUP_BASS_1A), >
Hi Kleber, Thanks for quick response. Here is upstream link: https://lkml.org/lkml/2020/10/8/324 On Tue, Oct 13, 2020 at 3:40 PM Kleber Souza <kleber.souza@canonical.com> wrote: > On 13.10.20 09:04, Jeremy Szu wrote: > > BugLink: https://bugs.launchpad.net/bugs/1899508 > > > > On a HP ZCentral, the front Mic could not be detected. > > > > The codec of the HP ZCentrol is alc671 and it needs to override the pin > > configuration to enable the headset mic. > > > > Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> > > Hi Jeremy, > > Do you have a link to the upstream submission for reference? It would be > good to have a reference to the upstream discussion if we have it. > Apart from that the patch looks good. > > Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> > > > --- > > sound/pci/hda/patch_realtek.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sound/pci/hda/patch_realtek.c > b/sound/pci/hda/patch_realtek.c > > index b44219859d82..44144470ef5f 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -9311,6 +9311,7 @@ static const struct snd_pci_quirk > alc662_fixup_tbl[] = { > > SND_PCI_QUIRK(0x1028, 0x0698, "Dell", > ALC668_FIXUP_DELL_MIC_NO_PRESENCE), > > SND_PCI_QUIRK(0x1028, 0x069f, "Dell", > ALC668_FIXUP_DELL_MIC_NO_PRESENCE), > > SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800), > > + SND_PCI_QUIRK(0x103c, 0x873e, "HP", ALC671_FIXUP_HP_HEADSET_MIC2), > > SND_PCI_QUIRK(0x1043, 0x1080, "Asus UX501VW", > ALC668_FIXUP_HEADSET_MODE), > > SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50), > > SND_PCI_QUIRK(0x1043, 0x13df, "Asus N550JX", ALC662_FIXUP_BASS_1A), > > > >
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index b44219859d82..44144470ef5f 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9311,6 +9311,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0698, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x069f, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800), + SND_PCI_QUIRK(0x103c, 0x873e, "HP", ALC671_FIXUP_HP_HEADSET_MIC2), SND_PCI_QUIRK(0x1043, 0x1080, "Asus UX501VW", ALC668_FIXUP_HEADSET_MODE), SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50), SND_PCI_QUIRK(0x1043, 0x13df, "Asus N550JX", ALC662_FIXUP_BASS_1A),
BugLink: https://bugs.launchpad.net/bugs/1899508 On a HP ZCentral, the front Mic could not be detected. The codec of the HP ZCentrol is alc671 and it needs to override the pin configuration to enable the headset mic. Signed-off-by: Jeremy Szu <jeremy.szu@canonical.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)