| Message ID | 20200831093555.1546137-2-vicamo.yang@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1,SRU,OEM-5.6/G] UBUNTU: SAUCE: PCI/ASPM: VMD: add ASPM quirk for 8086:a0bc | expand |
> On Aug 31, 2020, at 17:35, You-Sheng Yang <vicamo.yang@canonical.com> wrote: > > BugLink: https://bugs.launchpad.net/bugs/1893194 > > One VMD equipped platform has another PCI bridge with PCI ID [8086:a0bc] > that is not already in Ubuntu sauced PCI_DEV_FLAGS_ENABLE_ASPM list. > Link Capability Register shows ASPM L1 supported, but has ASPM Disabled > in Link Control status: > > 10000:e0:1c.4 PCI bridge [0604]: Intel Corporation Device [8086:a0bc] > (rev 20) (prog-if 00 [Normal decode]) > ... > Capabilities: [40] Express (v2) Root Port (Slot+), MSI 00 > ... > LnkCap: Port #5, Speed 8GT/s, Width x4, ASPM L1, Exit Latency L1 <16us > ClockPM- Surprise- LLActRep+ BwNot+ ASPMOptComp+ > LnkCtl: ASPM Disabled; RCB 64 bytes Disabled- CommClk+ > ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt- > > This adds an additional device [8086:a0bc], a PCI bridge behind VMD > controller, to enable its ASPM. > > Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com> Will send a new fix that doesn't need this patch. Kai-Heng > --- > drivers/pci/quirks.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 44df82ede565..1feba9773b74 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -5652,3 +5652,4 @@ static void pci_fixup_enable_aspm(struct pci_dev *pdev) > } > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a09, pci_fixup_enable_aspm); > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa0b0, pci_fixup_enable_aspm); > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa0bc, pci_fixup_enable_aspm); > -- > 2.27.0 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 44df82ede565..1feba9773b74 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -5652,3 +5652,4 @@ static void pci_fixup_enable_aspm(struct pci_dev *pdev) } DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a09, pci_fixup_enable_aspm); DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa0b0, pci_fixup_enable_aspm); +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa0bc, pci_fixup_enable_aspm);
BugLink: https://bugs.launchpad.net/bugs/1893194 One VMD equipped platform has another PCI bridge with PCI ID [8086:a0bc] that is not already in Ubuntu sauced PCI_DEV_FLAGS_ENABLE_ASPM list. Link Capability Register shows ASPM L1 supported, but has ASPM Disabled in Link Control status: 10000:e0:1c.4 PCI bridge [0604]: Intel Corporation Device [8086:a0bc] (rev 20) (prog-if 00 [Normal decode]) ... Capabilities: [40] Express (v2) Root Port (Slot+), MSI 00 ... LnkCap: Port #5, Speed 8GT/s, Width x4, ASPM L1, Exit Latency L1 <16us ClockPM- Surprise- LLActRep+ BwNot+ ASPMOptComp+ LnkCtl: ASPM Disabled; RCB 64 bytes Disabled- CommClk+ ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt- This adds an additional device [8086:a0bc], a PCI bridge behind VMD controller, to enable its ASPM. Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com> --- drivers/pci/quirks.c | 1 + 1 file changed, 1 insertion(+)