| Message ID | 20181129060212.18932-2-acelan.kao@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Power leakage at S5 with Qualcomm Atheros QCA9377 802.11ac Wireless Network Adapter | expand |
On 29.11.18 07:02, AceLan Kao wrote: > BugLink: https://bugs.launchpad.net/bugs/1805607 > > The reset function helps with the S5 power consumption, make the power > consumption reduce from 0.52W to 0.23W at S5. > > Signed-off-by: AceLan Kao <acelan.kao@canonical.com> Acked-by: Stefan Bader <stefan.bader@canonical.com> > --- If there still is no replacement to that, well ok. Just please let us know this is really true. Also noting that this should be "UBUNTU: SAUCE: ..." > drivers/net/wireless/ath/ath10k/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c > index e9c316274ee0..b4b88708a288 100644 > --- a/drivers/net/wireless/ath/ath10k/pci.c > +++ b/drivers/net/wireless/ath/ath10k/pci.c > @@ -3254,7 +3254,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev, > case QCA9377_1_0_DEVICE_ID: > hw_rev = ATH10K_HW_QCA9377; > pci_ps = true; > - pci_soft_reset = NULL; > + pci_soft_reset = ath10k_pci_warm_reset; > pci_hard_reset = ath10k_pci_qca6174_chip_reset; > targ_cpu_to_ce_addr = ath10k_pci_qca988x_targ_cpu_to_ce_addr; > break; >
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index e9c316274ee0..b4b88708a288 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -3254,7 +3254,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev, case QCA9377_1_0_DEVICE_ID: hw_rev = ATH10K_HW_QCA9377; pci_ps = true; - pci_soft_reset = NULL; + pci_soft_reset = ath10k_pci_warm_reset; pci_hard_reset = ath10k_pci_qca6174_chip_reset; targ_cpu_to_ce_addr = ath10k_pci_qca988x_targ_cpu_to_ce_addr; break;
BugLink: https://bugs.launchpad.net/bugs/1805607 The reset function helps with the S5 power consumption, make the power consumption reduce from 0.52W to 0.23W at S5. Signed-off-by: AceLan Kao <acelan.kao@canonical.com> --- drivers/net/wireless/ath/ath10k/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)