| Message ID | 20170620035015.19187-2-manoj.iyer@canonical.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Jun 19, 2017 at 10:50:15PM -0500, Manoj Iyer wrote: > From: Tyler Baicar <tbaicar@codeaurora.org> > > Check for pending errors when probing GHES entries. It is possible > that a fatal error is already pending at this point, so we should > handle it as soon as the driver is probed. This also avoids a > potential issue if there was an interrupt that was already > cleared for an error since the GHES driver wasn't present. > > BugLink: https://launchpad.net/bugs/1698448 > > Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org> > Reviewed-by: Borislav Petkov <bp@suse.de> > Signed-off-by: Will Deacon <will.deacon@arm.com> > (cherry picked from commit f561618d9b8019d3590950f19e2f75f9e20ed0c7) Where did this patch come from? I can't find this sha1 or any commit with this subject in Linus' tree. If it came from somewhere else you need to indicate where. Seth
On Tue, Jun 20, 2017 at 8:09 AM, Seth Forshee <seth.forshee@canonical.com> wrote: > On Mon, Jun 19, 2017 at 10:50:15PM -0500, Manoj Iyer wrote: >> From: Tyler Baicar <tbaicar@codeaurora.org> >> >> Check for pending errors when probing GHES entries. It is possible >> that a fatal error is already pending at this point, so we should >> handle it as soon as the driver is probed. This also avoids a >> potential issue if there was an interrupt that was already >> cleared for an error since the GHES driver wasn't present. >> >> BugLink: https://launchpad.net/bugs/1698448 >> >> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org> >> Reviewed-by: Borislav Petkov <bp@suse.de> >> Signed-off-by: Will Deacon <will.deacon@arm.com> >> (cherry picked from commit f561618d9b8019d3590950f19e2f75f9e20ed0c7) > > Where did this patch come from? I can't find this sha1 or any commit > with this subject in Linus' tree. If it came from somewhere else you > need to indicate where. I mentioned this in my cover letter to the patch that this is from Will Deacon's arm64 for-next git repo. git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git. > > > Seth >
On Tue, Jun 20, 2017 at 08:18:38AM -0500, Manoj Iyer wrote: > On Tue, Jun 20, 2017 at 8:09 AM, Seth Forshee <seth.forshee@canonical.com> > wrote: > > On Mon, Jun 19, 2017 at 10:50:15PM -0500, Manoj Iyer wrote: > > > From: Tyler Baicar <tbaicar@codeaurora.org> > > > > > > Check for pending errors when probing GHES entries. It is possible > > > that a fatal error is already pending at this point, so we should > > > handle it as soon as the driver is probed. This also avoids a > > > potential issue if there was an interrupt that was already > > > cleared for an error since the GHES driver wasn't present. > > > > > > BugLink: https://launchpad.net/bugs/1698448 > > > > > > Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org> > > > Reviewed-by: Borislav Petkov <bp@suse.de> > > > Signed-off-by: Will Deacon <will.deacon@arm.com> > > > (cherry picked from commit f561618d9b8019d3590950f19e2f75f9e20ed0c7) > > > > Where did this patch come from? I can't find this sha1 or any commit > > with this subject in Linus' tree. If it came from somewhere else you > > need to indicate where. > > I mentioned this in my cover letter to the patch that this is from Will > Deacon's arm64 for-next git repo. > git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git. Okay, so then your cherry picked statement should look like this: (cherry picked from commit f561618d9b8019d3590950f19e2f75f9e20ed0c7 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git) or perhaps just (cherry picked from ... linux-next) since it's likely the commit is also in linux-next. A sha1 by itself isn't useful, we also need the repository it came from, and someone looking at the tree isn't going to have the context of the cover letter. When you cherry pick it from anywhere but Linus' tree you need to include that information.
On Tue, Jun 20, 2017 at 8:31 AM, Seth Forshee <seth.forshee@canonical.com> wrote: > On Tue, Jun 20, 2017 at 08:18:38AM -0500, Manoj Iyer wrote: >> On Tue, Jun 20, 2017 at 8:09 AM, Seth Forshee >> <seth.forshee@canonical.com> >> wrote: >> > On Mon, Jun 19, 2017 at 10:50:15PM -0500, Manoj Iyer wrote: >> > > From: Tyler Baicar <tbaicar@codeaurora.org> >> > > >> > > Check for pending errors when probing GHES entries. It is >> possible >> > > that a fatal error is already pending at this point, so we >> should >> > > handle it as soon as the driver is probed. This also avoids a >> > > potential issue if there was an interrupt that was already >> > > cleared for an error since the GHES driver wasn't present. >> > > >> > > BugLink: https://launchpad.net/bugs/1698448 >> > > >> > > Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org> >> > > Reviewed-by: Borislav Petkov <bp@suse.de> >> > > Signed-off-by: Will Deacon <will.deacon@arm.com> >> > > (cherry picked from commit >> f561618d9b8019d3590950f19e2f75f9e20ed0c7) >> > >> > Where did this patch come from? I can't find this sha1 or any >> commit >> > with this subject in Linus' tree. If it came from somewhere else >> you >> > need to indicate where. >> >> I mentioned this in my cover letter to the patch that this is from >> Will >> Deacon's arm64 for-next git repo. >> git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git. > > Okay, so then your cherry picked statement should look like this: > > (cherry picked from commit f561618d9b8019d3590950f19e2f75f9e20ed0c7 > git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git) > > or perhaps just (cherry picked from ... linux-next) since it's likely > the commit is also in linux-next. A sha1 by itself isn't useful, we > also > need the repository it came from, and someone looking at the tree > isn't > going to have the context of the cover letter. When you cherry pick it > from anywhere but Linus' tree you need to include that information. Looks like the same applys for the RAS patches I sent out previously .. only the cover letter has the repo info.. did you want me to resubmit these with repo added?
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index e53bef6cf53c..b640fb6e2fb3 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -1039,6 +1039,9 @@ static int ghes_probe(struct platform_device *ghes_dev) } platform_set_drvdata(ghes_dev, ghes); + /* Handle any pending errors right away */ + ghes_proc(ghes); + return 0; err_edac_unreg: ghes_edac_unregister(ghes);