| Message ID | 1649780717-20982-1-git-send-email-bodong@nvidia.com |
|---|---|
| State | New |
| Headers | show |
| Series | UBUNTU: [Config] Bluefield: Enable CONFIG_NET_DEVLINK | expand |
On 4/12/2022 11:25 AM, Bodong Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1968751 > > Devlink is needed for all switch offload features. At least one > network vendor is needed to enable devlink, as mlx5_core wasn't > in sync with devlink, enable BNXT to expose DEVLINK option. BNXT > won't be probed inside Bluefield. > > Signed-off-by: Bodong Wang <bodong@nvidia.com> > --- > debian.bluefield/config/config.common.ubuntu | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/debian.bluefield/config/config.common.ubuntu b/debian.bluefield/config/config.common.ubuntu > index 21dbeae..fbdc820 100644 > --- a/debian.bluefield/config/config.common.ubuntu > +++ b/debian.bluefield/config/config.common.ubuntu > @@ -2758,6 +2758,7 @@ CONFIG_NET_CLS_RSVP6=m > CONFIG_NET_CLS_TCINDEX=m > CONFIG_NET_CLS_U32=m > CONFIG_NET_CORE=y > +CONFIG_NET_DEVLINK=y > # CONFIG_NET_DROP_MONITOR is not set > # CONFIG_NET_DSA is not set > CONFIG_NET_EGRESS=y > @@ -2849,7 +2850,11 @@ CONFIG_NET_UDP_TUNNEL=m > # CONFIG_NET_VENDOR_ARC is not set > # CONFIG_NET_VENDOR_ATHEROS is not set > # CONFIG_NET_VENDOR_AURORA is not set > -# CONFIG_NET_VENDOR_BROADCOM is not set > +CONFIG_BNXT=m > +# CONFIG_BNXT_SRIOV is not set > +# CONFIG_BNXT_FLOWER_OFFLOAD is not set > +# CONFIG_BNXT_DCB is not set > +# CONFIG_BNXT_HWMON is not set > # CONFIG_NET_VENDOR_BROCADE is not set > # CONFIG_NET_VENDOR_CADENCE is not set > # CONFIG_NET_VENDOR_CAVIUM is not set Tim/Alex, I believe the config file was changed when merging from my pull request. My original patch is here: ~bodong-wang/ubuntu/+source/linux-bluefield - [no description] (launchpad.net) <https://git.launchpad.net/~bodong-wang/ubuntu/+source/linux-bluefield/commit/?h=nvidia-devlink&id=09a66fe06ab223b63bbbdc6b6d2fa4472cb84411> This blocks us from build and releasing, can you apply as critical fix and rebuild the deb packages?
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 4/12/22 10:25, Bodong Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1968751 > > Devlink is needed for all switch offload features. At least one > network vendor is needed to enable devlink, as mlx5_core wasn't > in sync with devlink, enable BNXT to expose DEVLINK option. BNXT > won't be probed inside Bluefield. > > Signed-off-by: Bodong Wang <bodong@nvidia.com> > --- > debian.bluefield/config/config.common.ubuntu | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/debian.bluefield/config/config.common.ubuntu b/debian.bluefield/config/config.common.ubuntu > index 21dbeae..fbdc820 100644 > --- a/debian.bluefield/config/config.common.ubuntu > +++ b/debian.bluefield/config/config.common.ubuntu > @@ -2758,6 +2758,7 @@ CONFIG_NET_CLS_RSVP6=m > CONFIG_NET_CLS_TCINDEX=m > CONFIG_NET_CLS_U32=m > CONFIG_NET_CORE=y > +CONFIG_NET_DEVLINK=y > # CONFIG_NET_DROP_MONITOR is not set > # CONFIG_NET_DSA is not set > CONFIG_NET_EGRESS=y > @@ -2849,7 +2850,11 @@ CONFIG_NET_UDP_TUNNEL=m > # CONFIG_NET_VENDOR_ARC is not set > # CONFIG_NET_VENDOR_ATHEROS is not set > # CONFIG_NET_VENDOR_AURORA is not set > -# CONFIG_NET_VENDOR_BROADCOM is not set > +CONFIG_BNXT=m > +# CONFIG_BNXT_SRIOV is not set > +# CONFIG_BNXT_FLOWER_OFFLOAD is not set > +# CONFIG_BNXT_DCB is not set > +# CONFIG_BNXT_HWMON is not set > # CONFIG_NET_VENDOR_BROCADE is not set > # CONFIG_NET_VENDOR_CADENCE is not set > # CONFIG_NET_VENDOR_CAVIUM is not set
Acked-by: Zachary Tahenakos <zachary.tahenakos@canonical.com> On 4/12/22 12:25 PM, Bodong Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1968751 > > Devlink is needed for all switch offload features. At least one > network vendor is needed to enable devlink, as mlx5_core wasn't > in sync with devlink, enable BNXT to expose DEVLINK option. BNXT > won't be probed inside Bluefield. > > Signed-off-by: Bodong Wang <bodong@nvidia.com> > --- > debian.bluefield/config/config.common.ubuntu | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/debian.bluefield/config/config.common.ubuntu b/debian.bluefield/config/config.common.ubuntu > index 21dbeae..fbdc820 100644 > --- a/debian.bluefield/config/config.common.ubuntu > +++ b/debian.bluefield/config/config.common.ubuntu > @@ -2758,6 +2758,7 @@ CONFIG_NET_CLS_RSVP6=m > CONFIG_NET_CLS_TCINDEX=m > CONFIG_NET_CLS_U32=m > CONFIG_NET_CORE=y > +CONFIG_NET_DEVLINK=y > # CONFIG_NET_DROP_MONITOR is not set > # CONFIG_NET_DSA is not set > CONFIG_NET_EGRESS=y > @@ -2849,7 +2850,11 @@ CONFIG_NET_UDP_TUNNEL=m > # CONFIG_NET_VENDOR_ARC is not set > # CONFIG_NET_VENDOR_ATHEROS is not set > # CONFIG_NET_VENDOR_AURORA is not set > -# CONFIG_NET_VENDOR_BROADCOM is not set > +CONFIG_BNXT=m > +# CONFIG_BNXT_SRIOV is not set > +# CONFIG_BNXT_FLOWER_OFFLOAD is not set > +# CONFIG_BNXT_DCB is not set > +# CONFIG_BNXT_HWMON is not set > # CONFIG_NET_VENDOR_BROCADE is not set > # CONFIG_NET_VENDOR_CADENCE is not set > # CONFIG_NET_VENDOR_CAVIUM is not set
Applied to focal:linux-bluefield. It seems that extra options needed to be enabled as there are extra config dependencies with CONFIG_BNXT=m. These were CONFIG_NET_VENDOR_BROADCOM and CONFIG_PAGE_POOL but if you are not probing it would be a no-op. - Luke On Tue, Apr 12, 2022 at 9:25 AM Bodong Wang <bodong@nvidia.com> wrote: > BugLink: https://bugs.launchpad.net/bugs/1968751 > > Devlink is needed for all switch offload features. At least one > network vendor is needed to enable devlink, as mlx5_core wasn't > in sync with devlink, enable BNXT to expose DEVLINK option. BNXT > won't be probed inside Bluefield. > > Signed-off-by: Bodong Wang <bodong@nvidia.com> > --- > debian.bluefield/config/config.common.ubuntu | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/debian.bluefield/config/config.common.ubuntu > b/debian.bluefield/config/config.common.ubuntu > index 21dbeae..fbdc820 100644 > --- a/debian.bluefield/config/config.common.ubuntu > +++ b/debian.bluefield/config/config.common.ubuntu > @@ -2758,6 +2758,7 @@ CONFIG_NET_CLS_RSVP6=m > CONFIG_NET_CLS_TCINDEX=m > CONFIG_NET_CLS_U32=m > CONFIG_NET_CORE=y > +CONFIG_NET_DEVLINK=y > # CONFIG_NET_DROP_MONITOR is not set > # CONFIG_NET_DSA is not set > CONFIG_NET_EGRESS=y > @@ -2849,7 +2850,11 @@ CONFIG_NET_UDP_TUNNEL=m > # CONFIG_NET_VENDOR_ARC is not set > # CONFIG_NET_VENDOR_ATHEROS is not set > # CONFIG_NET_VENDOR_AURORA is not set > -# CONFIG_NET_VENDOR_BROADCOM is not set > +CONFIG_BNXT=m > +# CONFIG_BNXT_SRIOV is not set > +# CONFIG_BNXT_FLOWER_OFFLOAD is not set > +# CONFIG_BNXT_DCB is not set > +# CONFIG_BNXT_HWMON is not set > # CONFIG_NET_VENDOR_BROCADE is not set > # CONFIG_NET_VENDOR_CADENCE is not set > # CONFIG_NET_VENDOR_CAVIUM is not set > -- > 1.8.3.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team >
diff --git a/debian.bluefield/config/config.common.ubuntu b/debian.bluefield/config/config.common.ubuntu index 21dbeae..fbdc820 100644 --- a/debian.bluefield/config/config.common.ubuntu +++ b/debian.bluefield/config/config.common.ubuntu @@ -2758,6 +2758,7 @@ CONFIG_NET_CLS_RSVP6=m CONFIG_NET_CLS_TCINDEX=m CONFIG_NET_CLS_U32=m CONFIG_NET_CORE=y +CONFIG_NET_DEVLINK=y # CONFIG_NET_DROP_MONITOR is not set # CONFIG_NET_DSA is not set CONFIG_NET_EGRESS=y @@ -2849,7 +2850,11 @@ CONFIG_NET_UDP_TUNNEL=m # CONFIG_NET_VENDOR_ARC is not set # CONFIG_NET_VENDOR_ATHEROS is not set # CONFIG_NET_VENDOR_AURORA is not set -# CONFIG_NET_VENDOR_BROADCOM is not set +CONFIG_BNXT=m +# CONFIG_BNXT_SRIOV is not set +# CONFIG_BNXT_FLOWER_OFFLOAD is not set +# CONFIG_BNXT_DCB is not set +# CONFIG_BNXT_HWMON is not set # CONFIG_NET_VENDOR_BROCADE is not set # CONFIG_NET_VENDOR_CADENCE is not set # CONFIG_NET_VENDOR_CAVIUM is not set
BugLink: https://bugs.launchpad.net/bugs/1968751 Devlink is needed for all switch offload features. At least one network vendor is needed to enable devlink, as mlx5_core wasn't in sync with devlink, enable BNXT to expose DEVLINK option. BNXT won't be probed inside Bluefield. Signed-off-by: Bodong Wang <bodong@nvidia.com> --- debian.bluefield/config/config.common.ubuntu | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)