| Message ID | 1501240938-30431-1-git-send-email-amitkarwar@gmail.com |
|---|---|
| State | New |
| Headers | show |
On 28.07.2017 13:22, Amitkumar Karwar wrote: > From: Prameela Rani Garnepudi <prameela.j04cs@gmail.com> > > BugLink: https://bugs.launchpad.net/bugs/1706991 > > When Coex mode is enabled, enabling power save will improve > radio sharing. Hence PS on by default flag is set. > > Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com> > Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com> Acked-by: Stefan Bader <stefan.bader@canonical.com> > --- > ubuntu/rsi/rsi_91x_mac80211.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c > index 003f49d..8a4100a 100644 > --- a/ubuntu/rsi/rsi_91x_mac80211.c > +++ b/ubuntu/rsi/rsi_91x_mac80211.c > @@ -2835,6 +2835,9 @@ int rsi_mac80211_attach(struct rsi_common *common) > // NL80211_FEATURE_P2P_GO_OPPPS); > #endif > > + if (common->coex_mode > 1) > + wiphy->flags |= WIPHY_FLAG_PS_ON_BY_DEFAULT; > + > status = ieee80211_register_hw(hw); > if (status) { > ven_rsi_dbg(ERR_ZONE, "Failed to register to mac80211\n"); >
On 07/28/17 13:22, Amitkumar Karwar wrote: > From: Prameela Rani Garnepudi <prameela.j04cs@gmail.com> > > BugLink: https://bugs.launchpad.net/bugs/1706991 > > When Coex mode is enabled, enabling power save will improve > radio sharing. Hence PS on by default flag is set. > > Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com> > Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com> Good test results and limited to the vendor driver. On the next submissions, please include a cover letter email with some technical background of the changes, as mentioned by Stefan on the first submission of this series. This is useful mainly when sending multiple patches, since ACK'ing or NACK'ing the cover letter states that this is valid for all the patches in the series. Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> > --- > ubuntu/rsi/rsi_91x_mac80211.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c > index 003f49d..8a4100a 100644 > --- a/ubuntu/rsi/rsi_91x_mac80211.c > +++ b/ubuntu/rsi/rsi_91x_mac80211.c > @@ -2835,6 +2835,9 @@ int rsi_mac80211_attach(struct rsi_common *common) > // NL80211_FEATURE_P2P_GO_OPPPS); > #endif > > + if (common->coex_mode > 1) > + wiphy->flags |= WIPHY_FLAG_PS_ON_BY_DEFAULT; > + > status = ieee80211_register_hw(hw); > if (status) { > ven_rsi_dbg(ERR_ZONE, "Failed to register to mac80211\n"); >
On Mon, Jul 31, 2017 at 3:00 PM, Kleber Souza <kleber.souza@canonical.com> wrote: > On 07/28/17 13:22, Amitkumar Karwar wrote: >> From: Prameela Rani Garnepudi <prameela.j04cs@gmail.com> >> >> BugLink: https://bugs.launchpad.net/bugs/1706991 >> >> When Coex mode is enabled, enabling power save will improve >> radio sharing. Hence PS on by default flag is set. >> >> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com> >> Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com> > > Good test results and limited to the vendor driver. > > On the next submissions, please include a cover letter email with some > technical background of the changes, as mentioned by Stefan on the first > submission of this series. This is useful mainly when sending multiple > patches, since ACK'ing or NACK'ing the cover letter states that this is > valid for all the patches in the series. > > > Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> > > Thanks, I will add cover letter and include more details in it for next patch series. Regards, Amitkumar Karwar
Applied on xenial/master-next branch. Thanks.
diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c index 003f49d..8a4100a 100644 --- a/ubuntu/rsi/rsi_91x_mac80211.c +++ b/ubuntu/rsi/rsi_91x_mac80211.c @@ -2835,6 +2835,9 @@ int rsi_mac80211_attach(struct rsi_common *common) // NL80211_FEATURE_P2P_GO_OPPPS); #endif + if (common->coex_mode > 1) + wiphy->flags |= WIPHY_FLAG_PS_ON_BY_DEFAULT; + status = ieee80211_register_hw(hw); if (status) { ven_rsi_dbg(ERR_ZONE, "Failed to register to mac80211\n");