diff mbox

[1/4,Zesty] powerpc/powernv: Require MMU_NOTIFIER to fix NPU build

Message ID 1494608620-18958-1-git-send-email-leitao@debian.org
State New
Headers show

Commit Message

Breno Leitao May 12, 2017, 5:03 p.m. UTC 
From: Alistair Popple <alistair@popple.id.au>

BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1690412

In the recent commit 1ab66d1fbada ("powerpc/powernv: Introduce address
translation services for Nvlink2") the NPU code gained a dependency on MMU
notifiers.

All our defconfigs have KVM enabled, which selects MMU_NOTIFIER, but if KVM is
not enabled then the build breaks.

Fix it by always selecting MMU_NOTIFIER when we're building powernv.

Fixes: 1ab66d1fbada ("powerpc/powernv: Introduce address translation services for Nvlink2")
Signed-off-by: Alistair Popple <alistair@popple.id.au>
[mpe: Reword change log]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

(cherry picked from commit abfe8026b505d66dad7a3e5ebe7235f12c29b67d)
Signed-off-by: Breno Leitao <breno.leitao@gmail.com>
---
 arch/powerpc/platforms/powernv/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Seth Forshee May 17, 2017, 5:49 p.m. UTC | #1 
On Fri, May 12, 2017 at 02:03:37PM -0300, Breno Leitao wrote:
> From: Alistair Popple <alistair@popple.id.au>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1690412
> 
> In the recent commit 1ab66d1fbada ("powerpc/powernv: Introduce address
> translation services for Nvlink2") the NPU code gained a dependency on MMU
> notifiers.
> 
> All our defconfigs have KVM enabled, which selects MMU_NOTIFIER, but if KVM is
> not enabled then the build breaks.
> 
> Fix it by always selecting MMU_NOTIFIER when we're building powernv.
> 
> Fixes: 1ab66d1fbada ("powerpc/powernv: Introduce address translation services for Nvlink2")
> Signed-off-by: Alistair Popple <alistair@popple.id.au>
> [mpe: Reword change log]
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> 
> (cherry picked from commit abfe8026b505d66dad7a3e5ebe7235f12c29b67d)
> Signed-off-by: Breno Leitao <breno.leitao@gmail.com>

Clean cherry picks, very little risk of regressions outside of powerpc.
For all 4:

Acked-by: Seth Forshee <seth.forshee@canonical.com>
Stefan Bader May 18, 2017, 9:43 a.m. UTC | #2
Stefan Bader May 23, 2017, 9:18 a.m. UTC | #3 
Note the follow-up that currently has not made it to upstream, yet:

[PATCH] [Zesty] SAUCE: powernv/npu-dma.c: Fix opal_npu_destroy_context call
Thadeu Lima de Souza Cascardo May 30, 2017, 5:51 p.m. UTC | #4 
Applied all four patches to zesty master-next branch.

Please, next time, send a cover letter for multiple patches series.

Thanks.
Cascardo.
diff mbox

Patch

diff --git a/arch/powerpc/platforms/powernv/Kconfig b/arch/powerpc/platforms/powernv/Kconfig
index 604190cab522..4d3ca7bf4207 100644
--- a/arch/powerpc/platforms/powernv/Kconfig
+++ b/arch/powerpc/platforms/powernv/Kconfig
@@ -18,6 +18,7 @@  config PPC_POWERNV
 	select CPU_FREQ_GOV_ONDEMAND
 	select CPU_FREQ_GOV_CONSERVATIVE
 	select PPC_DOORBELL
+	select MMU_NOTIFIER
 	default y
 
 config OPAL_PRD