| Message ID | 1464032814-23423-1-git-send-email-tim.gardner@canonical.com |
|---|---|
| State | New |
| Headers | show |
On Mon, May 23, 2016 at 01:46:54PM -0600, Tim Gardner wrote: > BugLink: http://bugs.launchpad.net/bugs/1582991 > > It seems a little odd to have a crypto module in > with the NICS, even if it is a dependent module. > > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > --- > debian.master/d-i/modules/nic-modules | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/debian.master/d-i/modules/nic-modules b/debian.master/d-i/modules/nic-modules > index bd6e37a..681ce7c 100644 > --- a/debian.master/d-i/modules/nic-modules > +++ b/debian.master/d-i/modules/nic-modules > @@ -19,7 +19,6 @@ airport ? > alx ? > amd8111e ? > aquantia ? > -arc4 ? > arcnet ? > arc-rawmode ? > arc-rimi ? These are d-i fixes. As the debian-installer is not respun in the older releases in general, I am not sure these will ever have any effect? The Xenial one might for 16.04.1 other than that not. -apw
On 05/25/2016 01:06 AM, Andy Whitcroft wrote: > On Mon, May 23, 2016 at 01:46:54PM -0600, Tim Gardner wrote: >> BugLink: http://bugs.launchpad.net/bugs/1582991 >> >> It seems a little odd to have a crypto module in >> with the NICS, even if it is a dependent module. >> >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> >> --- >> debian.master/d-i/modules/nic-modules | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/debian.master/d-i/modules/nic-modules b/debian.master/d-i/modules/nic-modules >> index bd6e37a..681ce7c 100644 >> --- a/debian.master/d-i/modules/nic-modules >> +++ b/debian.master/d-i/modules/nic-modules >> @@ -19,7 +19,6 @@ airport ? >> alx ? >> amd8111e ? >> aquantia ? >> -arc4 ? >> arcnet ? >> arc-rawmode ? >> arc-rimi ? > > These are d-i fixes. As the debian-installer is not respun in the older > releases in general, I am not sure these will ever have any effect? The > Xenial one might for 16.04.1 other than that not. > > -apw > I thought the net install bits got respun for each new kernel. rtg
On Wed, May 25, 2016 at 08:57:06AM -0600, Tim Gardner wrote: > On 05/25/2016 01:06 AM, Andy Whitcroft wrote: > > On Mon, May 23, 2016 at 01:46:54PM -0600, Tim Gardner wrote: > >> BugLink: http://bugs.launchpad.net/bugs/1582991 > >> > >> It seems a little odd to have a crypto module in > >> with the NICS, even if it is a dependent module. > >> > >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > >> --- > >> debian.master/d-i/modules/nic-modules | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/debian.master/d-i/modules/nic-modules b/debian.master/d-i/modules/nic-modules > >> index bd6e37a..681ce7c 100644 > >> --- a/debian.master/d-i/modules/nic-modules > >> +++ b/debian.master/d-i/modules/nic-modules > >> @@ -19,7 +19,6 @@ airport ? > >> alx ? > >> amd8111e ? > >> aquantia ? > >> -arc4 ? > >> arcnet ? > >> arc-rawmode ? > >> arc-rimi ? > > > > These are d-i fixes. As the debian-installer is not respun in the older > > releases in general, I am not sure these will ever have any effect? The > > Xenial one might for 16.04.1 other than that not. > > > > -apw > > > > I thought the net install bits got respun for each new kernel. A good point well made. Did you confirm that the nic-modules depends on the foo-modules in which arc4 is shipped? -apw
On 05/25/2016 09:06 AM, Andy Whitcroft wrote: > On Wed, May 25, 2016 at 08:57:06AM -0600, Tim Gardner wrote: >> On 05/25/2016 01:06 AM, Andy Whitcroft wrote: >>> On Mon, May 23, 2016 at 01:46:54PM -0600, Tim Gardner wrote: >>>> BugLink: http://bugs.launchpad.net/bugs/1582991 >>>> >>>> It seems a little odd to have a crypto module in >>>> with the NICS, even if it is a dependent module. >>>> >>>> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> >>>> --- >>>> debian.master/d-i/modules/nic-modules | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/debian.master/d-i/modules/nic-modules b/debian.master/d-i/modules/nic-modules >>>> index bd6e37a..681ce7c 100644 >>>> --- a/debian.master/d-i/modules/nic-modules >>>> +++ b/debian.master/d-i/modules/nic-modules >>>> @@ -19,7 +19,6 @@ airport ? >>>> alx ? >>>> amd8111e ? >>>> aquantia ? >>>> -arc4 ? >>>> arcnet ? >>>> arc-rawmode ? >>>> arc-rimi ? >>> >>> These are d-i fixes. As the debian-installer is not respun in the older >>> releases in general, I am not sure these will ever have any effect? The >>> Xenial one might for 16.04.1 other than that not. >>> >>> -apw >>> >> >> I thought the net install bits got respun for each new kernel. > > A good point well made. > > Did you confirm that the nic-modules depends on the foo-modules in which > arc4 is shipped? > > -apw > I have a vague recollection that kernel-wedge satisfies symbolic linkages at udeb creation time. Regardless, though, arc4 registers indirectly with the crypto engine so there can be no direct symbolic linkage with consumers of the "ARC4 Cipher Algorithm". As long as crypto-modules is included in d-i then all should be well. rtg
On Wed, May 25, 2016 at 09:20:23AM -0600, Tim Gardner wrote: > On 05/25/2016 09:06 AM, Andy Whitcroft wrote: > > Did you confirm that the nic-modules depends on the foo-modules in which > > arc4 is shipped? > > > > -apw > > > > I have a vague recollection that kernel-wedge satisfies symbolic > linkages at udeb creation time. Regardless, though, arc4 registers > indirectly with the crypto engine so there can be no direct symbolic > linkage with consumers of the "ARC4 Cipher Algorithm". As long as > crypto-modules is included in d-i then all should be well. > > rtg Andy has confirmed that he's satisfied with this. ACK for all releases. -Kamal
On Mon, May 23, 2016 at 01:46:54PM -0600, Tim Gardner wrote: > BugLink: http://bugs.launchpad.net/bugs/1582991 > > It seems a little odd to have a crypto module in > with the NICS, even if it is a dependent module. > > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> Applied to T, U, V, W, X. -Kamal > --- > debian.master/d-i/modules/nic-modules | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/debian.master/d-i/modules/nic-modules b/debian.master/d-i/modules/nic-modules > index bd6e37a..681ce7c 100644 > --- a/debian.master/d-i/modules/nic-modules > +++ b/debian.master/d-i/modules/nic-modules > @@ -19,7 +19,6 @@ airport ? > alx ? > amd8111e ? > aquantia ? > -arc4 ? > arcnet ? > arc-rawmode ? > arc-rimi ? > -- > 1.9.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
diff --git a/debian.master/d-i/modules/nic-modules b/debian.master/d-i/modules/nic-modules index bd6e37a..681ce7c 100644 --- a/debian.master/d-i/modules/nic-modules +++ b/debian.master/d-i/modules/nic-modules @@ -19,7 +19,6 @@ airport ? alx ? amd8111e ? aquantia ? -arc4 ? arcnet ? arc-rawmode ? arc-rimi ?
BugLink: http://bugs.launchpad.net/bugs/1582991 It seems a little odd to have a crypto module in with the NICS, even if it is a dependent module. Signed-off-by: Tim Gardner <tim.gardner@canonical.com> --- debian.master/d-i/modules/nic-modules | 1 - 1 file changed, 1 deletion(-)