diff mbox

[Xenial,SRU] UBUNTU: [Config] Add liblzma-dev to enable libunwind support in perf

Message ID 1462547324-29618-1-git-send-email-tim.gardner@canonical.com
State New
Headers show

Commit Message

Tim Gardner May 6, 2016, 3:08 p.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1248289

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 debian.master/control.stub.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Kamal Mostafa May 6, 2016, 8:03 p.m. UTC | #1

Andy Whitcroft May 10, 2016, 2:44 p.m. UTC | #2
On Fri, May 06, 2016 at 09:08:44AM -0600, Tim Gardner wrote:
> BugLink: http://bugs.launchpad.net/bugs/1248289
> 
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>  debian.master/control.stub.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/control.stub.in b/debian.master/control.stub.in
> index da4fe92..fa39dfc 100644
> --- a/debian.master/control.stub.in
> +++ b/debian.master/control.stub.in
> @@ -20,6 +20,7 @@ Build-Depends:
>   flex <!stage1>,
>   bison <!stage1>,
>   libunwind8-dev [amd64 arm64 armhf i386 powerpc ppc64el] <!stage1>,
> + liblzma-dev <!stage1>,
>   openssl <!stage1>,
>   libssl-dev <!stage1>,
>   libaudit-dev <!stage1>,

Looks to be in main.

Acked-by: Andy Whitcroft <apw@canonical.com>

There is some commentary in the bug that -llzma is also needed in the
perf Makefile for x86_64, did we confirm this was bogus?

-apw
Tim Gardner May 10, 2016, 3:12 p.m. UTC | #3
On 05/10/2016 08:44 AM, Andy Whitcroft wrote:
> On Fri, May 06, 2016 at 09:08:44AM -0600, Tim Gardner wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1248289
>>
>> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
>> ---
>>   debian.master/control.stub.in | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/debian.master/control.stub.in b/debian.master/control.stub.in
>> index da4fe92..fa39dfc 100644
>> --- a/debian.master/control.stub.in
>> +++ b/debian.master/control.stub.in
>> @@ -20,6 +20,7 @@ Build-Depends:
>>    flex <!stage1>,
>>    bison <!stage1>,
>>    libunwind8-dev [amd64 arm64 armhf i386 powerpc ppc64el] <!stage1>,
>> + liblzma-dev <!stage1>,
>>    openssl <!stage1>,
>>    libssl-dev <!stage1>,
>>    libaudit-dev <!stage1>,
>
> Looks to be in main.
>
> Acked-by: Andy Whitcroft <apw@canonical.com>
>
> There is some commentary in the bug that -llzma is also needed in the
> perf Makefile for x86_64, did we confirm this was bogus?
>
> -apw
>

I only looked at the build log which indicated that libunwind was 
successfully detected. Mayhap I should actually have a closer look at 
perf as well.

rtg
Tim Gardner May 10, 2016, 3:42 p.m. UTC | #4
On 05/10/2016 09:12 AM, Tim Gardner wrote:
> On 05/10/2016 08:44 AM, Andy Whitcroft wrote:
>> On Fri, May 06, 2016 at 09:08:44AM -0600, Tim Gardner wrote:
>>> BugLink: http://bugs.launchpad.net/bugs/1248289
>>>
>>> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
>>> ---
>>>   debian.master/control.stub.in | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/debian.master/control.stub.in
>>> b/debian.master/control.stub.in
>>> index da4fe92..fa39dfc 100644
>>> --- a/debian.master/control.stub.in
>>> +++ b/debian.master/control.stub.in
>>> @@ -20,6 +20,7 @@ Build-Depends:
>>>    flex <!stage1>,
>>>    bison <!stage1>,
>>>    libunwind8-dev [amd64 arm64 armhf i386 powerpc ppc64el] <!stage1>,
>>> + liblzma-dev <!stage1>,
>>>    openssl <!stage1>,
>>>    libssl-dev <!stage1>,
>>>    libaudit-dev <!stage1>,
>>
>> Looks to be in main.
>>
>> Acked-by: Andy Whitcroft <apw@canonical.com>
>>
>> There is some commentary in the bug that -llzma is also needed in the
>> perf Makefile for x86_64, did we confirm this was bogus?
>>
>> -apw
>>
>
> I only looked at the build log which indicated that libunwind was
> successfully detected. Mayhap I should actually have a closer look at
> perf as well.
>
> rtg

The commentary to which you refer in 
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1248289/comments/17 
is in reference to a fix required for Trusty. It appears that this patch 
for Xenial is sufficient.

rtg
Kamal Mostafa May 10, 2016, 4:05 p.m. UTC | #5

diff mbox

Patch

diff --git a/debian.master/control.stub.in b/debian.master/control.stub.in
index da4fe92..fa39dfc 100644
--- a/debian.master/control.stub.in
+++ b/debian.master/control.stub.in
@@ -20,6 +20,7 @@  Build-Depends:
  flex <!stage1>,
  bison <!stage1>,
  libunwind8-dev [amd64 arm64 armhf i386 powerpc ppc64el] <!stage1>,
+ liblzma-dev <!stage1>,
  openssl <!stage1>,
  libssl-dev <!stage1>,
  libaudit-dev <!stage1>,