diff mbox

[Trusty] (upstream) libata: Blacklist queued TRIM on all Samsung 800-series

Message ID 1433282888-5323-1-git-send-email-chiluk@canonical.com
State New
Headers show

Commit Message

Dave Chiluk June 2, 2015, 10:08 p.m. UTC 
From: "Martin K. Petersen" <martin.petersen@oracle.com>

BugLink: http://bugs.launchpad.net/bugs/1338706
BugLink: http://bugs.launchpad.net/bugs/1449005

The queued TRIM problems appear to be generic to Samsung's firmware and
not tied to a particular model. A recent update to the 840 EVO firmware
introduced the same issue as we saw on 850 Pro.

Blacklist queued TRIM on all 800-series drives while we work this issue
with Samsung.

Reported-by: Günter Waller <g.wal@web.de>
Reported-by: Sven Köhler <sven.koehler@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: Tejun Heo <tj@kernel.org>
(backported from commit 9a9324d3969678d44b330e1230ad2c8ae67acf81)
Signed-off-by: Dave Chiluk <chiluk@canonical.com>
---
 drivers/ata/libata-core.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Bader June 3, 2015, 6:56 a.m. UTC | #1 
And one more for T...
Colin Ian King June 3, 2015, 8:04 a.m. UTC | #2 
On 02/06/15 23:08, Dave Chiluk wrote:
> From: "Martin K. Petersen" <martin.petersen@oracle.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1338706
> BugLink: http://bugs.launchpad.net/bugs/1449005
> 
> The queued TRIM problems appear to be generic to Samsung's firmware and
> not tied to a particular model. A recent update to the 840 EVO firmware
> introduced the same issue as we saw on 850 Pro.
> 
> Blacklist queued TRIM on all 800-series drives while we work this issue
> with Samsung.
> 
> Reported-by: Günter Waller <g.wal@web.de>
> Reported-by: Sven Köhler <sven.koehler@gmail.com>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Tejun Heo <tj@kernel.org>
> (backported from commit 9a9324d3969678d44b330e1230ad2c8ae67acf81)
> Signed-off-by: Dave Chiluk <chiluk@canonical.com>
> ---
>  drivers/ata/libata-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index b81391c..25b2dc5 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4228,6 +4228,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>  	{ "Crucial_CT???M500SSD*",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
>  	{ "Micron_M550*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
>  	{ "Crucial_CT*M550SSD*",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
> +	{ "Samsung SSD 8*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
>  
>  	/*
>  	 * Some WD SATA-I drives spin up and down erratically when the link
> 
Upstream quirk, looks sane.

Acked-by: Colin Ian King <colin.king@canonical.com>
Brad Figg June 4, 2015, 3 p.m. UTC | #3 
Applied to Trusty master-next branch.
diff mbox

Patch

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b81391c..25b2dc5 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4228,6 +4228,7 @@  static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "Crucial_CT???M500SSD*",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
 	{ "Micron_M550*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
 	{ "Crucial_CT*M550SSD*",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
+	{ "Samsung SSD 8*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
 
 	/*
 	 * Some WD SATA-I drives spin up and down erratically when the link