diff mbox

[Trusty,Utopic,SRU] UBUNTU: [Config] CONFIG_PCIEASPM_DEBUG=y

Message ID 1428441418-29029-1-git-send-email-chris.j.arges@canonical.com
State New
Headers show

Commit Message

Chris J Arges April 7, 2015, 9:16 p.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1398544

CONFIG_PCIEASPM_DEBUG can be used to enable/disable ASPM settings per PCIE
device. This config option allows for easier debugging of bugs in BIOS.
Enabling this adds sysfs entires to access ASPM settings for PCIe devices.

Signed-off-by: Chris J Arges <chris.j.arges at canonical.com>
---
 debian.master/config/config.common.ubuntu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Gardner April 7, 2015, 10:51 p.m. UTC | #1

Seth Forshee April 8, 2015, 1:30 p.m. UTC | #2
On Tue, Apr 07, 2015 at 04:16:58PM -0500, Chris J Arges wrote:
> BugLink: http://bugs.launchpad.net/bugs/1398544
> 
> CONFIG_PCIEASPM_DEBUG can be used to enable/disable ASPM settings per PCIE
> device. This config option allows for easier debugging of bugs in BIOS.
> Enabling this adds sysfs entires to access ASPM settings for PCIe devices.
> 
> Signed-off-by: Chris J Arges <chris.j.arges at canonical.com>

This looks safe - the sysfs files it adds are writable only by root, and
while they're world readable the information they reveal seems harmless.
Without writing to the files there should be no change in behavior.

Acked-by: Seth Forshee <seth.forshee@canonical.com>
Tim Gardner April 8, 2015, 1:42 p.m. UTC | #3

diff mbox

Patch

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 9dc2f50..fa3da85 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -5030,7 +5030,7 @@  CONFIG_PCI200SYN=m
 CONFIG_PCIEAER=y
 # CONFIG_PCIEAER_INJECT is not set
 CONFIG_PCIEASPM=y
-# CONFIG_PCIEASPM_DEBUG is not set
+CONFIG_PCIEASPM_DEBUG=y
 CONFIG_PCIEASPM_DEFAULT=y
 # CONFIG_PCIEASPM_PERFORMANCE is not set
 # CONFIG_PCIEASPM_POWERSAVE is not set