| Message ID | 1420626499-22603-1-git-send-email-luis.henriques@canonical.com |
|---|---|
| State | New |
| Headers | show |
Hi Luis, Luis Henriques wrote: > This is a note to let you know that I have just added a patch titled > > [media] smiapp-pll: Correct clock debug prints > > to the linux-3.16.y-queue branch of the 3.16.y-ckt extended stable tree > which can be found at: > > http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.16.y-queue > > This patch is scheduled to be released in version 3.16.7-ckt4. > > If you, or anyone else, feels it should not be added to this tree, please > reply to this email. I don't know how this has ended up here, but I feel this is hardly material for a stable tree. The patch fixes a few debug prints and I'm positively certain no regular user cares about this, and very few developers as well. I propose to drop this from the stable tree.
On Wed, Jan 07, 2015 at 01:22:02PM +0200, Sakari Ailus wrote: > Hi Luis, > > Luis Henriques wrote: > >This is a note to let you know that I have just added a patch titled > > > > [media] smiapp-pll: Correct clock debug prints > > > >to the linux-3.16.y-queue branch of the 3.16.y-ckt extended stable tree > >which can be found at: > > > > http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.16.y-queue > > > >This patch is scheduled to be released in version 3.16.7-ckt4. > > > >If you, or anyone else, feels it should not be added to this tree, please > >reply to this email. > > I don't know how this has ended up here, but I feel this is hardly material > for a stable tree. The patch fixes a few debug prints and I'm positively > certain no regular user cares about this, and very few developers as well. > > I propose to drop this from the stable tree. > > -- > Kind regards, > > Sakari Ailus > sakari.ailus@linux.intel.com Thank you Sakari. The reason I'm queuing this patch for the 3.16 kernel is because it was tagged for stable, probably by the maintainer. Mauro, any feedback or shall I just drop it as requested by Sakari? Cheers, -- Luís
diff --git a/drivers/media/i2c/smiapp-pll.c b/drivers/media/i2c/smiapp-pll.c index 2335529b195c..ab5d9a3adebf 100644 --- a/drivers/media/i2c/smiapp-pll.c +++ b/drivers/media/i2c/smiapp-pll.c @@ -67,7 +67,7 @@ static void print_pll(struct device *dev, struct smiapp_pll *pll) { dev_dbg(dev, "pre_pll_clk_div\t%d\n", pll->pre_pll_clk_div); dev_dbg(dev, "pll_multiplier \t%d\n", pll->pll_multiplier); - if (pll->flags != SMIAPP_PLL_FLAG_NO_OP_CLOCKS) { + if (!(pll->flags & SMIAPP_PLL_FLAG_NO_OP_CLOCKS)) { dev_dbg(dev, "op_sys_clk_div \t%d\n", pll->op_sys_clk_div); dev_dbg(dev, "op_pix_clk_div \t%d\n", pll->op_pix_clk_div); } @@ -77,7 +77,7 @@ static void print_pll(struct device *dev, struct smiapp_pll *pll) dev_dbg(dev, "ext_clk_freq_hz \t%d\n", pll->ext_clk_freq_hz); dev_dbg(dev, "pll_ip_clk_freq_hz \t%d\n", pll->pll_ip_clk_freq_hz); dev_dbg(dev, "pll_op_clk_freq_hz \t%d\n", pll->pll_op_clk_freq_hz); - if (pll->flags & SMIAPP_PLL_FLAG_NO_OP_CLOCKS) { + if (!(pll->flags & SMIAPP_PLL_FLAG_NO_OP_CLOCKS)) { dev_dbg(dev, "op_sys_clk_freq_hz \t%d\n", pll->op_sys_clk_freq_hz); dev_dbg(dev, "op_pix_clk_freq_hz \t%d\n",
This is a note to let you know that I have just added a patch titled [media] smiapp-pll: Correct clock debug prints to the linux-3.16.y-queue branch of the 3.16.y-ckt extended stable tree which can be found at: http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.16.y-queue This patch is scheduled to be released in version 3.16.7-ckt4. If you, or anyone else, feels it should not be added to this tree, please reply to this email. For more information about the 3.16.y-ckt tree, see https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable Thanks. -Luis ------ From b47e969b12bdabf654d0acd090f5993ad36853d5 Mon Sep 17 00:00:00 2001 From: Sakari Ailus <sakari.ailus@linux.intel.com> Date: Tue, 1 Apr 2014 10:22:46 -0300 Subject: [media] smiapp-pll: Correct clock debug prints commit bc47150ab93988714d1fab7bc82fe5f505a107ad upstream. The PLL flags were not used correctly. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> Signed-off-by: Luis Henriques <luis.henriques@canonical.com> --- drivers/media/i2c/smiapp-pll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.1.4