diff mbox

[Trusty/Utopic,SRU] UBUNTU: [Debian] Add UTS_RELEASE_MINOR to version.h

Message ID 1402951935-16718-1-git-send-email-tim.gardner@canonical.com
State New
Headers show

Commit Message

Tim Gardner June 16, 2014, 8:52 p.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1327619

Provides for finer grained kernel identification for external modules.

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 debian/rules.d/2-binary-arch.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stefan Bader June 17, 2014, 12:55 p.m. UTC | #1
On 16.06.2014 22:52, Tim Gardner wrote:
> BugLink: http://bugs.launchpad.net/bugs/1327619
> 
> Provides for finer grained kernel identification for external modules.
> 
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>  debian/rules.d/2-binary-arch.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index 98fdf89..1947afc 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -244,6 +244,8 @@ endif
>  	# Copy over the compilation version.
>  	cp "$(builddir)/build-$*/include/generated/compile.h" \
>  		"$(hdrdir)/include/generated/compile.h"
> +	# Add UTS_RELEASE_MINOR to version.h
> +	echo "#define UTS_RELEASE_MINOR $(abinum)" >> $(hdrdir)/include/generated/uapi/linux/version.h
>  	# powerpc kernel arch seems to need some .o files for external module linking. Add them in.
>  ifeq ($(build_arch),powerpc)
>  	mkdir -p $(hdrdir)/arch/powerpc/lib
> 

I can see the benefit and it should not break anything existing. And the
reporter claims this would help the problem. Minor worry that the naming could
make someone expect it to be a broken out part of UTS_RELEASE. Any reason not to
name it something like UBUNTU_KERNEL_ABI ?
Tim Gardner June 17, 2014, 3:27 p.m. UTC | #2
Perhaps this version will be  a bit less subject to bike shedding.

rtg
diff mbox

Patch

diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
index 98fdf89..1947afc 100644
--- a/debian/rules.d/2-binary-arch.mk
+++ b/debian/rules.d/2-binary-arch.mk
@@ -244,6 +244,8 @@  endif
 	# Copy over the compilation version.
 	cp "$(builddir)/build-$*/include/generated/compile.h" \
 		"$(hdrdir)/include/generated/compile.h"
+	# Add UTS_RELEASE_MINOR to version.h
+	echo "#define UTS_RELEASE_MINOR $(abinum)" >> $(hdrdir)/include/generated/uapi/linux/version.h
 	# powerpc kernel arch seems to need some .o files for external module linking. Add them in.
 ifeq ($(build_arch),powerpc)
 	mkdir -p $(hdrdir)/arch/powerpc/lib